From: Sam Ravnborg Subject: Re: [PATCH 04/11] drm/tinydrm: Remove tinydrm_display_pipe_init() Date: Mon, 21 Jan 2019 07:30:27 +0100 Message-ID: <20190121063027.GB2483@ravnborg.org> References: <20190120114318.49199-1-noralf@tronnes.org> <20190120114318.49199-5-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 137966E6C6 for ; Mon, 21 Jan 2019 06:30:31 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190120114318.49199-5-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: david@lechnology.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgTm9yYWxmLgoKT24gU3VuLCBKYW4gMjAsIDIwMTkgYXQgMTI6NDM6MTFQTSArMDEwMCwgTm9y YWxmIFRyw7hubmVzIHdyb3RlOgo+IEZ1cnRoZXIgc3RyaXAgZG93biB0aW55ZHJtLmtvIGFuZCBz d2l0Y2ggdG8gZHJtX3NpbXBsZV9jb25uZWN0b3JfY3JlYXRlKCkuCgpJdCBpcyBuaWNlIGhvdyB0 aGUgdGlueWRybSBkcml2ZXJzIGdvZXMgZnJvbSBzcGVjaWFsIGRyaXZlcnMgdG8gc21hbGwKZHJp dmVycyB3aXRoIGEgbGl0dGxlIGFkZGVkIHRvIHRoZSBjb3JlLgoKVHdvIG1pbm9yIGNvbW1lbnRz IGJlbG93LiBXaXRoIHRoYXQgYWRkcmVzc2VkL3Byb2Nlc3NlZCBpdCBoYXM6ClJldmlld2VkLWJ5 OiBTYW0gUmF2bmJvcmcgPHNhbUByYXZuYm9yZy5vcmc+Cgo+IAo+IFNpZ25lZC1vZmYtYnk6IE5v cmFsZiBUcsO4bm5lcyA8bm9yYWxmQHRyb25uZXMub3JnPgo+IC0tLQo+ICBEb2N1bWVudGF0aW9u L2dwdS90aW55ZHJtLnJzdCAgICAgICAgICAgICAgIHwgICAzIC0KPiAgZHJpdmVycy9ncHUvZHJt L3Rpbnlkcm0vY29yZS9NYWtlZmlsZSAgICAgICB8ICAgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0v dGlueWRybS9jb3JlL3Rpbnlkcm0tcGlwZS5jIHwgMTgzIC0tLS0tLS0tLS0tLS0tLS0tLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS90aW55ZHJtL21pcGktZGJpLmMgICAgICAgICAgfCAgMjQgKystCj4g IGRyaXZlcnMvZ3B1L2RybS90aW55ZHJtL3JlcGFwZXIuYyAgICAgICAgICAgfCAgMTYgKy0KPiAg ZHJpdmVycy9ncHUvZHJtL3Rpbnlkcm0vc3Q3NTg2LmMgICAgICAgICAgICB8ICAxOSArLQo+ICBp bmNsdWRlL2RybS90aW55ZHJtL3Rpbnlkcm0uaCAgICAgICAgICAgICAgIHwgICA5IC0KPiAgNyBm aWxlcyBjaGFuZ2VkLCA0MyBpbnNlcnRpb25zKCspLCAyMTMgZGVsZXRpb25zKC0pCj4gIGRlbGV0 ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2dwdS9kcm0vdGlueWRybS9jb3JlL3Rpbnlkcm0tcGlwZS5j Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS90aW55ZHJtL21pcGktZGJpLmMgYi9k cml2ZXJzL2dwdS9kcm0vdGlueWRybS9taXBpLWRiaS5jCj4gaW5kZXggOTE4Zjc3YzdkZTM0Li5k MWQ1NDZmM2E2NjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3Rpbnlkcm0vbWlwaS1k YmkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS90aW55ZHJtL21pcGktZGJpLmMKPiBAQCAtMzkx LDcgKzM5MSwxMyBAQCBpbnQgbWlwaV9kYmlfaW5pdChzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVj dCBtaXBpX2RiaSAqbWlwaSwKPiAgewo+ICAJc2l6ZV90IGJ1ZnNpemUgPSBtb2RlLT52ZGlzcGxh eSAqIG1vZGUtPmhkaXNwbGF5ICogc2l6ZW9mKHUxNik7Cj4gIAlzdHJ1Y3QgdGlueWRybV9kZXZp Y2UgKnRkZXYgPSAmbWlwaS0+dGlueWRybTsKPiArCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25u ZWN0b3I7Cj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAqZHJtOwo+ICAJaW50IHJldDsKPiArCXN0YXRp YyBjb25zdCB1aW50NjRfdCBtb2RpZmllcnNbXSA9IHsKPiArCQlEUk1fRk9STUFUX01PRF9MSU5F QVIsCj4gKwkJRFJNX0ZPUk1BVF9NT0RfSU5WQUxJRAo+ICsJfTsKPiAgCj4gIAlpZiAoIW1pcGkt PmNvbW1hbmQpCj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gQEAgLTQwNiwxOCArNDEyLDIyIEBAIGlu dCBtaXBpX2RiaV9pbml0KHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IG1pcGlfZGJpICptaXBp LAo+ICAJaWYgKHJldCkKPiAgCQlyZXR1cm4gcmV0Owo+ICAKPiAtCS8qIFRPRE86IE1heWJlIGFk ZCBEUk1fTU9ERV9DT05ORUNUT1JfU1BJICovCj4gLQlyZXQgPSB0aW55ZHJtX2Rpc3BsYXlfcGlw ZV9pbml0KHRkZXYsIHBpcGVfZnVuY3MsCj4gLQkJCQkJRFJNX01PREVfQ09OTkVDVE9SX1ZJUlRV QUwsCj4gLQkJCQkJbWlwaV9kYmlfZm9ybWF0cywKPiAtCQkJCQlBUlJBWV9TSVpFKG1pcGlfZGJp X2Zvcm1hdHMpLCBtb2RlLAo+IC0JCQkJCXJvdGF0aW9uKTsKPiArCWRybSA9IHRkZXYtPmRybTsK PiArCj4gKwljb25uZWN0b3IgPSBkcm1fc2ltcGxlX2Nvbm5lY3Rvcl9jcmVhdGUoZHJtLCBEUk1f TU9ERV9DT05ORUNUT1JfVklSVFVBTCwgbW9kZSwgcm90YXRpb24pOwpMaW5lIGxlbmd0aCB0b28g bG9uZy4KVGhpcyBnb2VzIGZvciBhbGwgY2FsbHMgdG8gZHJtX3NpbXBsZV9jb25uZWN0b3JfY3Jl YXRlKCkgaW4gdGhpcyBwYXRjaC4KCldlIGFyZSBsb29zaW5nIHRoZSBjb21tZW50OgoiVE9ETzog TWF5YmUgYWRkIERSTV9NT0RFX0NPTk5FQ1RPUl9TUEkiCk9uIHB1cnBvc2U/Cgo+ICsJaWYgKElT X0VSUihjb25uZWN0b3IpKQo+ICsJCXJldHVybiBQVFJfRVJSKGNvbm5lY3Rvcik7Cj4gKwo+ICsJ cmV0ID0gZHJtX3NpbXBsZV9kaXNwbGF5X3BpcGVfaW5pdChkcm0sICZ0ZGV2LT5waXBlLCBwaXBl X2Z1bmNzLAo+ICsJCQkJCSAgIG1pcGlfZGJpX2Zvcm1hdHMsIEFSUkFZX1NJWkUobWlwaV9kYmlf Zm9ybWF0cyksCj4gKwkJCQkJICAgbW9kaWZpZXJzLCBjb25uZWN0b3IpOwo+ICAJaWYgKHJldCkK PiAgCQlyZXR1cm4gcmV0Owo+ICAKPiAgCWRybV9wbGFuZV9lbmFibGVfZmJfZGFtYWdlX2NsaXBz KCZ0ZGV2LT5waXBlLnBsYW5lKTsKPiAgCj4gLQl0ZGV2LT5kcm0tPm1vZGVfY29uZmlnLnByZWZl cnJlZF9kZXB0aCA9IDE2Owo+ICsJZHJtX3NpbXBsZV9jb25uZWN0b3Jfc2V0X21vZGVfY29uZmln KGNvbm5lY3Rvcik7Cj4gKwlkcm0tPm1vZGVfY29uZmlnLnByZWZlcnJlZF9kZXB0aCA9IDE2Owo+ ICAJbWlwaS0+cm90YXRpb24gPSByb3RhdGlvbjsKPiAgCj4gIAlkcm1fbW9kZV9jb25maWdfcmVz ZXQodGRldi0+ZHJtKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3Rpbnlkcm0vcmVw YXBlci5jIGIvZHJpdmVycy9ncHUvZHJtL3Rpbnlkcm0vcmVwYXBlci5jCj4gaW5kZXggNzJkMzAx NTFlY2Q4Li4xZDU1MTc0NGNjOWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3Rpbnlk cm0vcmVwYXBlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3Rpbnlkcm0vcmVwYXBlci5jCj4g QEAgLTkyNCwxMiArOTI0LDE0IEBAIHN0YXRpYyBpbnQgcmVwYXBlcl9wcm9iZShzdHJ1Y3Qgc3Bp X2RldmljZSAqc3BpKQo+ICAJY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGU7Cj4g IAljb25zdCBzdHJ1Y3Qgc3BpX2RldmljZV9pZCAqc3BpX2lkOwo+ICAJY29uc3Qgc3RydWN0IG9m X2RldmljZV9pZCAqbWF0Y2g7Cj4gKwlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+ ICAJc3RydWN0IGRldmljZSAqZGV2ID0gJnNwaS0+ZGV2Owo+ICAJc3RydWN0IHRpbnlkcm1fZGV2 aWNlICp0ZGV2Owo+ICAJZW51bSByZXBhcGVyX21vZGVsIG1vZGVsOwo+ICAJY29uc3QgY2hhciAq dGhlcm1hbF96b25lOwo+ICAJc3RydWN0IHJlcGFwZXJfZXBkICplcGQ7Cj4gIAlzaXplX3QgbGlu ZV9idWZmZXJfc2l6ZTsKPiArCXN0cnVjdCBkcm1fZGV2aWNlICpkcm07Cj4gIAlpbnQgcmV0Owo+ ICAKPiAgCW1hdGNoID0gb2ZfbWF0Y2hfZGV2aWNlKHJlcGFwZXJfb2ZfbWF0Y2gsIGRldik7Cj4g QEAgLTEwNjksMTMgKzEwNzEsMTkgQEAgc3RhdGljIGludCByZXBhcGVyX3Byb2JlKHN0cnVjdCBz cGlfZGV2aWNlICpzcGkpCj4gIAlpZiAocmV0KQo+ICAJCXJldHVybiByZXQ7Cj4gIAo+IC0JcmV0 ID0gdGlueWRybV9kaXNwbGF5X3BpcGVfaW5pdCh0ZGV2LCAmcmVwYXBlcl9waXBlX2Z1bmNzLAo+ IC0JCQkJCURSTV9NT0RFX0NPTk5FQ1RPUl9WSVJUVUFMLAo+IC0JCQkJCXJlcGFwZXJfZm9ybWF0 cywKPiAtCQkJCQlBUlJBWV9TSVpFKHJlcGFwZXJfZm9ybWF0cyksIG1vZGUsIDApOwo+ICsJZHJt ID0gdGRldi0+ZHJtOwo+ICsKPiArCWNvbm5lY3RvciA9IGRybV9zaW1wbGVfY29ubmVjdG9yX2Ny ZWF0ZShkcm0sIERSTV9NT0RFX0NPTk5FQ1RPUl9WSVJUVUFMLCBtb2RlLCAwKTsKPiArCWlmIChJ U19FUlIoY29ubmVjdG9yKSkKPiArCQlyZXR1cm4gUFRSX0VSUihjb25uZWN0b3IpOwo+ICsKPiAr CXJldCA9IGRybV9zaW1wbGVfZGlzcGxheV9waXBlX2luaXQoZHJtLCAmdGRldi0+cGlwZSwgJnJl cGFwZXJfcGlwZV9mdW5jcywKPiArCQkJCQkgICByZXBhcGVyX2Zvcm1hdHMsIEFSUkFZX1NJWkUo cmVwYXBlcl9mb3JtYXRzKSwKPiArCQkJCQkgICBOVUxMLCBjb25uZWN0b3IpOwpJbiBtaXBpLWRi aSBtb2RpZmllcnMgYXJlIHNwZWNpZmllZCwgbGlrZSBkb25lIGluIHRpbnktY29yZS4KQnV0IHRo aXMsIGFuZCB0aGUgb3RoZXIgZHJpdmVycywgZG8gbm90IHNwZWNpZnkgYW55IG1vZGlmaWVycy4K CkFueSBzcGVjaWZpYyByZWFzb24gd2h5IGl0IGlzIG5lZWRlZCBpbiBvbmUgcGxhY2UgYnV0IG5v dCB0aGUgb3RoZXJzPwpOb3RlOiBJIGRvIG5vdCByZWFsbHkga25vdyB0aGUgcHVycG9zZSwgYW5k IHRoZSBjb21tZW50IGlzIGFsb25lIHRyaWdnZXJlZApiZWNhdXNlIHRoZXJlIHdhcyBhIGRpZmZl cmVuY2UgaW4gdGhlIGNhbGxzIHRvIGRybV9zaW1wbGVfZGlzcGxheV9waXBlX2luaXQoKQoKPiAg CWlmIChyZXQpCj4gIAkJcmV0dXJuIHJldDsKPiAgCj4gKwlkcm1fc2ltcGxlX2Nvbm5lY3Rvcl9z ZXRfbW9kZV9jb25maWcoY29ubmVjdG9yKTsKCk5vIG5lZWQgdG8gc2V0IHByZWZlcnJlZF9kZXB0 aCBoZXJlPwooSXQgaXMgbm90IGluIHRoZSBvcmlnaW5hbCBkcml2ZXIsIHNvIGl0IHNlZW1zIHRv IHdvcmsgd2l0aG91dCBpdCkKCj4gIAlkcm1fbW9kZV9jb25maWdfcmVzZXQodGRldi0+ZHJtKTsK PiAgCXNwaV9zZXRfZHJ2ZGF0YShzcGksIHRkZXYpOwo+ICAKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==