Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 754F0C31680 for ; Mon, 21 Jan 2019 17:42:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 471E421019 for ; Mon, 21 Jan 2019 17:42:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="TPKs414y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728019AbfAURmI (ORCPT ); Mon, 21 Jan 2019 12:42:08 -0500 Received: from mail-qk1-f196.google.com ([209.85.222.196]:41171 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726020AbfAURmH (ORCPT ); Mon, 21 Jan 2019 12:42:07 -0500 Received: by mail-qk1-f196.google.com with SMTP id 189so12705602qkj.8 for ; Mon, 21 Jan 2019 09:42:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=QgJLjhuU+pzbeFOw/Q1xLWraoZ6NNNWwtuPz2LV7Mg8=; b=TPKs414yHjkp7vzC/0Yj4A7CL22v+YTgtA/yzAtxXpTdwEp0X5KJIGyBnOQi6YaYkX xe4PPDheHg/0oJa0UstxRAznhnZ2Bar/KaQrgqplwzGJ8li1iPaCwIEYi8aQu8ym0O+g Xl9n58Zlol94yPfXIw1Ld4/VAV8tYG+GYik4E3Xu5V+ssNxkycEZsAy4F5ciG/5YHKwX H5vLirIMocPhXhLyYRyLhb/tnQbK2fEZLQ6ORTyppDfwe9tUfaTyUS9bYkgER8wCAfcB S7h8Dgn4H5TSTuFys+Nt5fZCWqVwhzyFjQBTEUnbEiHvi3BmaJRduyvPGDgb5f+cjXH2 A7DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=QgJLjhuU+pzbeFOw/Q1xLWraoZ6NNNWwtuPz2LV7Mg8=; b=tT70ZU67LAyJnzuxN6oRrs5gsxt5cMljf9JAtZD7UhLFGisK4he/Y00KpMOU0UlEpI MlP0rmJhYF00RDOa8XiUIK4+NSnDn26ieyXswrXi2HSp46Jw2MODMhbGJorYhuwtMbST jawtragXao1YDOufCND+sZcJRIzoEF/AMELK+hUYqYHDcuBGKzkRgbL0biEJVovuyXIB dZ9cro8NYad6Jczg9z/jKplcF/Jn0Na7XDr/nl+8qAkh6vf6MX4GClqLDXTSt6OtHFMl ae+gRH6ogm+GSj5SOKUWyBcjL+rYtLa3EYcdU2CGxiOokbUWL0FONop3ZPZvl77H3SlW ypJA== X-Gm-Message-State: AJcUukeGYdRgR+1x9jabi23EFfgJyzQNdwX2SYIee6M3PS717SRyn0sC eI1Tr7uQGPt+ek7tvgxp4sTHLw== X-Google-Smtp-Source: ALg8bN7cO4UoYKB9UF834JG0KQC4CsJFXCiMFflnkBxGelbmTRm9GgAWbHwQIskzXPv+eB6Ra0/R0Q== X-Received: by 2002:a37:b581:: with SMTP id e123mr25056328qkf.183.1548092526712; Mon, 21 Jan 2019 09:42:06 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id z207sm52191781qka.57.2019.01.21.09.42.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Jan 2019 09:42:06 -0800 (PST) Date: Mon, 21 Jan 2019 09:42:02 -0800 From: Jakub Kicinski To: Taeung Song Cc: Daniel Borkmann , Alexei Starovoitov , netdev@vger.kernel.org, Quentin Monnet , Andrey Ignatov Subject: Re: [PATCH bpf-next v4] libbpf: Show supported ELF section names on when failed to guess a prog/attach type Message-ID: <20190121094202.2ae3717d@cakuba.netronome.com> In-Reply-To: <20190121130638.7554-1-treeze.taeung@gmail.com> References: <20190121130638.7554-1-treeze.taeung@gmail.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 21 Jan 2019 22:06:38 +0900, Taeung Song wrote: > We need to let users check their wrong ELF section name > with proper ELF section names when failed to get a prog/attach type from it. > Because users can't realize libbpf guess prog/attach types from > given ELF section names. > For example, when a 'cgroup' section name of a BPF program is used, > show available ELF section names(types). > > Before: > > $ bpftool prog load bpf-prog.o /sys/fs/bpf/prog1 > Error: failed to guess program type based on ELF section name cgroup > > After: > > libbpf: failed to guess program type based on ELF section name 'cgroup' > libbpf: supported section(type) names are: socket kprobe/ kretprobe/ classifier action tracepoint/ raw_tracepoint/ xdp perf_event lwt_in lwt_out lwt_xmit lwt_seg6local cgroup_skb/ingress cgroup_skb/egress cgroup/skb cgroup/sock cgroup/post_bind4 cgroup/post_bind6 cgroup/dev sockops sk_skb/stream_parser sk_skb/stream_verdict sk_skb sk_msg lirc_mode2 flow_dissector cgroup/bind4 cgroup/bind6 cgroup/connect4 cgroup/connect6 cgroup/sendmsg4 cgroup/sendmsg6 > > Cc: Quentin Monnet > Cc: Jakub Kicinski > Cc: Andrey Ignatov > Signed-off-by: Taeung Song Acked-by: Jakub Kicinski