From: Paul Mackerras Date: Tue, 22 Jan 2019 23:34:14 +0000 Subject: Re: [PATCH 02/13] KVM: PPC: Ultravisor: Include ultravisor header file. Message-Id: <20190122233414.GB24333@blackberry> List-Id: References: <1548172784-27414-3-git-send-email-linuxram@us.ibm.com> In-Reply-To: <1548172784-27414-3-git-send-email-linuxram@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ppc@vger.kernel.org On Tue, Jan 22, 2019 at 07:59:33AM -0800, Ram Pai wrote: > This file contains the definitions of all ultracalls. "will contain", perhaps? > Signed-off-by: Ram Pai > --- > arch/powerpc/include/asm/ucall-api.h | 5 +++++ > arch/powerpc/include/uapi/asm/uapi_uvcall.h | 10 ++++++++++ This is the wrong place for these definitions. The "u" in uapi stands for "user", and this directory is for the definition of the API that the kernel provides to userspace. This file should just go in the normal arch/powerpc/include/asm directory, and it shouldn't have "uapi" in its name. Paul.