Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC803C282C3 for ; Wed, 23 Jan 2019 00:25:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6B2F217D4 for ; Wed, 23 Jan 2019 00:25:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548203104; bh=2bUJUAQ2l12Yi5U38ACw0yeudqosaOUYuKG6SROUOI0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=k0Bla2p0ckpJvNbjs+3C3GP9g55/bwy1LKq5CIKudxBuqdh4467rJi9XK4RF3hoWD Vab9FIFVb5GDYhbQJOxMhFBigRZ/6JxufRKo+2qpq4dQWM+FFHwtv0lH1PlIOKJ+w7 fld3MdU3TF8WwpNOoP3BTfVbKKdfqgfmcnKq78b8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726329AbfAWAZE (ORCPT ); Tue, 22 Jan 2019 19:25:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:38622 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725985AbfAWAZD (ORCPT ); Tue, 22 Jan 2019 19:25:03 -0500 Received: from devbox (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2F2DB20868; Wed, 23 Jan 2019 00:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548203103; bh=2bUJUAQ2l12Yi5U38ACw0yeudqosaOUYuKG6SROUOI0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Yznok78jX1TefeKoLksSwWKoR+m74t32bqiB27JFoZOPzBOcuGuXG64dvz0jZtKXt 7FPaL8DfYd0g0QWg0Zzne9pbsqvpztgfHnJI5anShQxIQiR9R8CCchROj5LejKwcrX Boye59Pu78Qv2gISx9avMiqsl+Lvw76oqx08JDvU= Date: Wed, 23 Jan 2019 09:25:00 +0900 From: Masami Hiramatsu To: Andreas Ziegler Cc: Sasha Levin , Masami Hiramatsu , Steven Rostedt , stable@vger.kernel.org Subject: Re: [PATCH v2 3/3] tracing: probeevent: Fix to make the type of $comm string Message-Id: <20190123092500.30cc2a29440d67e51e05c498@kernel.org> In-Reply-To: <2E525341-7003-48EB-8609-187C3C27FFD8@fau.de> References: <154778672210.19927.871647535916796323.stgit@devbox> <20190122155553.880E221726@mail.kernel.org> <2E525341-7003-48EB-8609-187C3C27FFD8@fau.de> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, 22 Jan 2019 19:53:56 +0100 Andreas Ziegler wrote: > Hi, > > > On 22. Jan 2019, at 16:55, Sasha Levin wrote: > > > > Hi, > > > > [This is an automated email] > > > > This commit has been processed because it contains a "Fixes:" tag, > > fixing commit: 35abb67de744 tracing: expose current->comm to [ku]probe events. > > > > The bot has tested the following trees: v4.20.3, v4.19.16, v4.14.94, v4.9.151. > > > > v4.20.3: Build OK! > > v4.19.16: Failed to apply! Possible dependencies: > > 40b53b771806 ("tracing: probeevent: Add array type support") > > 533059281ee5 ("tracing: probeevent: Introduce new argument fetching code") > > 56de76305279 ("tracing: probeevent: Cleanup print argument functions") > > 60c2e0cebfd0 ("tracing: probeevent: Add symbol type") > > eeb07b061500 ("tracing: probeevent: Cleanup argument field definition") > > f451bc89d835 ("tracing: probeevent: Unify fetch type tables") > > > > v4.14.94: Failed to apply! Possible dependencies: > > 40b53b771806 ("tracing: probeevent: Add array type support") > > 45408c4f9250 ("tracing: kprobes: Prohibit probing on notrace function") > > 4bebdc7a85aa ("bpf: add helper bpf_perf_prog_read_value") > > 533059281ee5 ("tracing: probeevent: Introduce new argument fetching code") > > 60c2e0cebfd0 ("tracing: probeevent: Add symbol type") > > 908432ca84fc ("bpf: add helper bpf_perf_event_read_value for perf event array map") > > 97562633bcba ("bpf: perf event change needed for subsequent bpf helpers") > > 9802d86585db ("bpf: add a bpf_override_function helper") > > b4da3340eae2 ("tracing/kprobe: bpf: Check error injectable event is on function entry") > > cd86d1fd2102 ("bpf: Adding helper function bpf_getsockops") > > dd0bb688eaa2 ("bpf: add a bpf_override_function helper") > > de8f3a83b0a0 ("bpf: add meta pointer for direct access") > > f3edacbd697f ("bpf: Revert bpf_overrid_function() helper changes.") > > f451bc89d835 ("tracing: probeevent: Unify fetch type tables") > > > > v4.9.151: Failed to apply! Possible dependencies: > > 17bedab27231 ("bpf: xdp: Allow head adjustment in XDP prog") > > 1d9995771fcb ("s390: update defconfigs") > > 23a4e389bdc7 ("nfp: create separate define for max number of vectors") > > 40b53b771806 ("tracing: probeevent: Add array type support") > > 45408c4f9250 ("tracing: kprobes: Prohibit probing on notrace function") > > 533059281ee5 ("tracing: probeevent: Introduce new argument fetching code") > > 60c2e0cebfd0 ("tracing: probeevent: Add symbol type") > > 67f8b1dcb9ee ("net/mlx4_en: Refactor the XDP forwarding rings scheme") > > 68453c7a8973 ("nfp: centralize runtime reconfiguration logic") > > 6b0b7551428e ("perf/core: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS") > > 7ff5c83a1deb ("nfp: simplify nfp_net_poll()") > > 9802d86585db ("bpf: add a bpf_override_function helper") > > a4b562bb8ebd ("nfp: use unsigned int for vector/ring counts") > > b4da3340eae2 ("tracing/kprobe: bpf: Check error injectable event is on function entry") > > cbeaf7aa733a ("nfp: bring back support for different ring counts") > > ccc109b8ed24 ("net/mlx4_en: Add TX_XDP for CQ types") > > dd0bb688eaa2 ("bpf: add a bpf_override_function helper") > > e390b55d5aef ("bpf: make bpf_xdp_adjust_head support mandatory") > > ecd63a0217d5 ("nfp: add XDP support in the driver") > > f18f97ac43d7 ("tracing/kprobes: Add a helper method to return number of probe hits") > > f3edacbd697f ("bpf: Revert bpf_overrid_function() helper changes.") > > f451bc89d835 ("tracing: probeevent: Unify fetch type tables") > > > > > > How should we proceed with this patch? > > I think this should be a case of backporting, which probably > needs > > - removal of the 'parg->count ||' part from the if statement > (and the ', and not an array.' part of the comment above it). > - addition of the old 'ftbl' parameter to find_fetch_type() > > for all kernels up to v4.19.16. Right, that was expected when I was writing the code... > > While at it, 'deferred' in the newly added comment should > probably be 'dereferenced' to match the deleted comment. ah, sorry it was my typo. > > Masami, do you want to fix this up and prepare backported > patches for the stable kernels? Of course :) Thank you! > > Thanks, > > Andreas > -- Masami Hiramatsu