Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 23 Jan 2019 22:40:14 -0000 Received: from mx1.redhat.com ([209.132.183.28]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gmRBs-0001Io-Pu for speck@linutronix.de; Wed, 23 Jan 2019 23:40:13 +0100 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 63C377BDA5 for ; Wed, 23 Jan 2019 22:40:06 +0000 (UTC) Received: from treble (ovpn-124-3.rdu2.redhat.com [10.10.124.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 159EA1019633 for ; Wed, 23 Jan 2019 22:40:05 +0000 (UTC) Date: Wed, 23 Jan 2019 16:40:04 -0600 From: Josh Poimboeuf Subject: [MODERATED] Re: [PATCH v5 14/27] MDSv5 3 Message-ID: <20190123224004.ekqtemmu44vnnuoh@treble> References: <8b89fce6dd87638a00078082141d3ce5fe13d0ea.1547858934.git.ak@linux.intel.com> <20190123013525.GX6118@tassilo.jf.intel.com> <20190123160206.GZ6118@tassilo.jf.intel.com> MIME-Version: 1.0 In-Reply-To: <20190123160206.GZ6118@tassilo.jf.intel.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Wed, Jan 23, 2019 at 08:02:06AM -0800, speck for Andi Kleen wrote: > > you just sprinkle random mitigation calls around. > > > > The point is that paranoid mitigation is simply 'always invoke VERW'. The > > conditional modes and that's what we have done for the other > > vulnerabilities as well are handling the most obvious issues and leave some > > documented holes. Trying to catch everything in cond mode is just adding a > > lot of pointless crap all over the code base and will still fail to plug > > all holes unless you do a full audit of all kernel code. > > > > It would be interesting to see the following test results: > > You mean performance test results? That's in 0/0 > > The worse case slow down we've seen with the lazy flushing > is ~2% (on a benchmark that pushes data over loopback > in a tight loop). Most workloads see no change because > the existing lazy scheme works fairly well. > > With full flushing the worst case seen is 8%, but again > that was a workload that does syscalls in a tight loop, > so more an outlier. We're actually seeing some very large slowdowns -- much worse than 8%. The early results are showing more like 130% slowdown in several cases for mds=full. The mds=auto tests are in progress. I don't have much more detail than that at the moment, but I can try to provide more details about the benchmarks when I get them. It would be interesting to see if others are seeing similar results. This is on a 4.18-based RHEL kernel. -- Josh