From: Greg KH Subject: Re: [PATCH] [stable pre-4.8] can: bcm: check timer values before ktime conversion Date: Sun, 27 Jan 2019 20:34:11 +0100 Message-ID: <20190127193411.GB25051@kroah.com> References: <20190124090842.2938-1-socketcan@hartkopp.net> <20190126181718.GE30183@sasha-vm> <8a72ffa5-dac5-6de8-f01e-dfbb98b1f024@hartkopp.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <8a72ffa5-dac5-6de8-f01e-dfbb98b1f024@hartkopp.net> Sender: stable-owner@vger.kernel.org To: Oliver Hartkopp Cc: Sasha Levin , davem@davemloft.net, netdev@vger.kernel.org, stable@vger.kernel.org, linux-can@vger.kernel.org, lifeasageek@gmail.com, threeearcat@gmail.com, syzkaller@googlegroups.com, nautsch2@gmail.com, Kyungtae Kim , Marc Kleine-Budde List-Id: linux-can.vger.kernel.org On Sun, Jan 27, 2019 at 07:22:38PM +0100, Oliver Hartkopp wrote: > Hi Sasha, > > On 26.01.19 19:17, Sasha Levin wrote: > > On Thu, Jan 24, 2019 at 10:08:42AM +0100, Oliver Hartkopp wrote: > > > Kyungtae Kim detected a potential integer overflow in bcm_[rx|tx]_setup() > > > when the conversion into ktime multiplies the given value with > > > NSEC_PER_USEC > > > (1000). > > > > > > Reference: https://marc.info/?l=linux-can&m=154732118819828&w=2 > > > > > > Add a check for the given tv_usec, so that the value stays below one > > > second. > > > Additionally limit the tv_sec value to a reasonable value for CAN related > > > use-cases of 400 days and ensure all values to be positive. > > > > > > This patch is the pre-4.8 version of upstream commit 93171ba6f1deffd8 > > > > I can't find this commit id upstream, there's nothing with the same > > subject name, nor does this code exist upstream. What's going on? > > Here we are (pulled by Linus some minutes ago): > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=93171ba6f1deffd82f381d36cb13177872d023f6 > > Can you go with this pre-4.8 version now? Let me get the others into the newer kernels first please :) Should be a day or so at most... thanks, greg k-h