From: Matt Roper Subject: Re: [v6 2/6] drm/i915/glk: Fix degamma lut programming Date: Mon, 28 Jan 2019 13:34:08 -0800 Message-ID: <20190128213408.GD4563@mdroper-desk.amr.corp.intel.com> References: <1547655697-4092-1-git-send-email-uma.shankar@intel.com> <1547655697-4092-3-git-send-email-uma.shankar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6AF496E732 for ; Mon, 28 Jan 2019 21:34:09 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1547655697-4092-3-git-send-email-uma.shankar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Uma Shankar Cc: intel-gfx@lists.freedesktop.org, ville.syrjala@intel.com, maarten.lankhorst@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKYW4gMTYsIDIwMTkgYXQgMDk6NTE6MzNQTSArMDUzMCwgVW1hIFNoYW5rYXIgd3Jv dGU6Cj4gRml4ZWQgdGhlIGdsayBkZWdhbW1hIGx1dCBwcm9ncmFtbWluZyB3aGljaCBjdXJyZW50 bHkKPiB3YXMgaGFyZCBjb2RpbmcgYSBsaW5lYXIgbHV0IGFsbCB0aGUgdGltZSwgbWFraW5nIGRl Z2FtbWEKPiBibG9jayBvZiBnbGsgYmFzaWNhbGx5IGEgcGFzcyB0aHJvdWdoLgo+IAo+IEN1cnJl bnRseSBkZWdhbW1hIGx1dCBmb3IgZ2xrIGlzIGFzc2lnbmVkIGFzIDAgaW4gcGxhdGZvcm0KPiBj b25maWd1cmF0aW9uLiBVcGRhdGVkIHRoZSBzYW1lIHRvIDMzIGFzIHBlciB0aGUgaGFyZHdhcmUK PiBjYXBhYmlsaXR5LiBJR1QgdGVzdHMgZm9yIGRlZ2FtbWEgd2VyZSBnZXR0aW5nIHNraXBwZWQg ZHVlIHRvCj4gdGhpcywgc3BvdHRlZCBieSBTd2F0aS4KPiAKPiBUb0RvOiBUaGUgY3VycmVudCBn YW1tYS9kZWdhbW0gbHV0IEFCSSBoYXMganVzdCAxNmJpdCBmb3IgZWFjaAo+IGNvbG9yIGNvbXBv bmVudC4gVGhpcyBpcyBub3QgZW5vdWdoIGZvciBHTEsrLCBzaW5jZSBpbnB1dAo+IHByZWNpc2lv biBpcyBpbmNyZWFzZWQgdG8gMy4xNiB3aGljaCB3aWxsIG5lZWQgMTliaXQgZW50cmllcy4KPiAK PiBDcmVkaXRzLXRvOiBTd2F0aSBTaGFybWEgPHN3YXRpMi5zaGFybWFAaW50ZWwuY29tPgo+IFNp Z25lZC1vZmYtYnk6IFVtYSBTaGFua2FyIDx1bWEuc2hhbmthckBpbnRlbC5jb20+Cj4gLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGNpLmMgICAgfCAgMiArLQo+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jIHwgMzYgKysrKysrKysrKysrKysrKysrKysrKysrKysr Ky0tLS0tLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlv bnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wY2kuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGNpLmMKPiBpbmRleCBkZDRhZmYyLi4yNDI0OGQw IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGNpLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BjaS5jCj4gQEAgLTY5LDcgKzY5LDcgQEAKPiAgI2Rl ZmluZSBDSFZfQ09MT1JTIFwKPiAgCS5jb2xvciA9IHsgLmRlZ2FtbWFfbHV0X3NpemUgPSA2NSwg LmdhbW1hX2x1dF9zaXplID0gMjU3IH0KPiAgI2RlZmluZSBHTEtfQ09MT1JTIFwKPiAtCS5jb2xv ciA9IHsgLmRlZ2FtbWFfbHV0X3NpemUgPSAwLCAuZ2FtbWFfbHV0X3NpemUgPSAxMDI0IH0KPiAr CS5jb2xvciA9IHsgLmRlZ2FtbWFfbHV0X3NpemUgPSAzMywgLmdhbW1hX2x1dF9zaXplID0gMTAy NCB9Cj4gIAo+ICAvKiBLZWVwIGluIGdlbiBiYXNlZCBvcmRlciwgYW5kIGNocm9ub2xvZ2ljYWwg b3JkZXIgd2l0aGluIGEgZ2VuICovCj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9jb2xvci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29sb3IuYwo+ IGluZGV4IDM3ZmQ5ZGQuLjM3MTJiZDAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfY29sb3IuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9y LmMKPiBAQCAtNDkxLDcgKzQ5MSw3IEBAIHN0YXRpYyB2b2lkIGdsa19sb2FkX2RlZ2FtbWFfbHV0 KHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGNydGNfc3RhdGUtPmJhc2UuY3J0Yy0+ ZGV2KTsKPiAgCWVudW0gcGlwZSBwaXBlID0gdG9faW50ZWxfY3J0YyhjcnRjX3N0YXRlLT5iYXNl LmNydGMpLT5waXBlOwo+IC0JY29uc3QgdWludDMyX3QgbHV0X3NpemUgPSAzMzsKPiArCWNvbnN0 IHVpbnQzMl90IGx1dF9zaXplID0gSU5URUxfSU5GTyhkZXZfcHJpdiktPmNvbG9yLmRlZ2FtbWFf bHV0X3NpemU7Cj4gIAl1aW50MzJfdCBpOwo+ICAKPiAgCS8qCj4gQEAgLTUwMiwxNCArNTAyLDM0 IEBAIHN0YXRpYyB2b2lkIGdsa19sb2FkX2RlZ2FtbWFfbHV0KHN0cnVjdCBpbnRlbF9jcnRjX3N0 YXRlICpjcnRjX3N0YXRlKQo+ICAJSTkxNV9XUklURShQUkVfQ1NDX0dBTUNfSU5ERVgocGlwZSks IDApOwo+ICAJSTkxNV9XUklURShQUkVfQ1NDX0dBTUNfSU5ERVgocGlwZSksIFBSRV9DU0NfR0FN Q19BVVRPX0lOQ1JFTUVOVCk7Cj4gIAo+IC0JLyoKPiAtCSAqICBGSVhNRTogVGhlIHBpcGUgZGVn YW1tYSB0YWJsZSBpbiBnZW1pbmlsYWtlIGRvZXNuJ3Qgc3VwcG9ydAo+IC0JICogIGRpZmZlcmVu dCB2YWx1ZXMgcGVyIGNoYW5uZWwsIHNvIHRoaXMganVzdCBsb2FkcyBhIGxpbmVhciB0YWJsZS4K PiAtCSAqLwo+IC0JZm9yIChpID0gMDsgaSA8IGx1dF9zaXplOyBpKyspIHsKPiAtCQl1aW50MzJf dCB2ID0gKGkgKiAoMSA8PCAxNikpIC8gKGx1dF9zaXplIC0gMSk7Cj4gIAo+IC0JCUk5MTVfV1JJ VEUoUFJFX0NTQ19HQU1DX0RBVEEocGlwZSksIHYpOwo+ICsJaWYgKGNydGNfc3RhdGUtPmJhc2Uu ZGVnYW1tYV9sdXQpIHsKPiArCQlzdHJ1Y3QgZHJtX2NvbG9yX2x1dCAqbHV0ID0gY3J0Y19zdGF0 ZS0+YmFzZS5kZWdhbW1hX2x1dC0+ZGF0YTsKPiArCj4gKwkJZm9yIChpID0gMDsgaSA8IGx1dF9z aXplOyBpKyspIHsKPiArCQkJLyoKPiArCQkJICogRmlyc3QgMzMgZW50cmllcyByZXByZXNlbnQg cmFuZ2UgZnJvbSAwIHRvIDEuMAo+ICsJCQkgKiAzNHRoIGFuZCAzNXRoIGVudHJ5IHdpbGwgcmVw cmVzZW50IGV4dGVuZGVkIHJhbmdlCj4gKwkJCSAqIGlucHV0cyAzLjAgYW5kIDcuMCByZXNwZWN0 aXZlbHksIGN1cnJlbnRseSBjbGFtcGVkCj4gKwkJCSAqIGF0IDEuMC4gU2luY2UgdGhlIHByZWNp c2lvbiBpcyAxNmJpdCwgdGhlIHVzZXIKPiArCQkJICogdmFsdWUgY2FuIGJlIGRpcmVjdGx5IGZp bGxlZCB0byByZWdpc3Rlci4KPiArCQkJICogVGhlIHBpcGUgZGVnYW1tYSB0YWJsZSBpbiBHTEsr IG9ud2FyZHMgZG9lc24ndAo+ICsJCQkgKiBzdXBwb3J0IGRpZmZlcmVudCB2YWx1ZXMgcGVyIGNo YW5uZWwsIHNvIHRoaXMganVzdAo+ICsJCQkgKiBwcm9ncmFtcyBncmVlbiB2YWx1ZSB3aGljaCB3 aWxsIGJlIGVxdWFsIHRvIFJlZCBhbmQKPiArCQkJICogQmx1ZSBpbnRvIHRoZSBsdXQgcmVnaXN0 ZXJzLgo+ICsJCQkgKiBUb0RvOiBFeHRlbmQgdG8gbWF4IDcuMC4gRW5hYmxlIDMyIGJpdCBpbnB1 dCB2YWx1ZQo+ICsJCQkgKiBhcyBjb21wYXJlZCB0byBqdXN0IDE2IHRvIGFjaGlldmUgdGhpcy4K PiArCQkJICovCj4gKwkJCUk5MTVfV1JJVEUoUFJFX0NTQ19HQU1DX0RBVEEocGlwZSksIGx1dFtp XS5ncmVlbik7Cj4gKwkJCUk5MTVfV1JJVEUoUFJFX0NTQ19HQU1DX0RBVEEocGlwZSksIGx1dFtp XS5ncmVlbik7CgpJIGRvbid0IHRoaW5rIHRoZSBkb3VibGUtd3JpdGUgaGVyZSB3YXMgaW50ZW50 aW9uYWwgKGFuZCB3b3VsZCBwcm9iYWJseQpjYXVzZSBtb3JlIHByb2JsZW1zIHRoYW4gdXN1YWwg ZHVlIHRvIHRoZSBpbmRleCBhdXRvIGluY3JlbWVudCkuCgpPdGhlciB0aGFuIHRoYXQsCgpSZXZp ZXdlZC1ieTogTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KCj4gKwkJfQo+ ICsJfSBlbHNlIHsKPiArCQkvKiBsb2FkIGEgbGluZWFyIHRhYmxlLiAqLwo+ICsJCWZvciAoaSA9 IDA7IGkgPCBsdXRfc2l6ZTsgaSsrKSB7Cj4gKwkJCXVpbnQzMl90IHYgPSAoaSAqICgxIDw8IDE2 KSkgLyAobHV0X3NpemUgLSAxKTsKPiArCj4gKwkJCUk5MTVfV1JJVEUoUFJFX0NTQ19HQU1DX0RB VEEocGlwZSksIHYpOwo+ICsJCX0KPiAgCX0KPiAgCj4gIAkvKiBDbGFtcCB2YWx1ZXMgPiAxLjAu ICovCj4gLS0gCj4gMS45LjEKPiAKCi0tIApNYXR0IFJvcGVyCkdyYXBoaWNzIFNvZnR3YXJlIEVu Z2luZWVyCklvVEcgUGxhdGZvcm0gRW5hYmxpbmcgJiBEZXZlbG9wbWVudApJbnRlbCBDb3Jwb3Jh dGlvbgooOTE2KSAzNTYtMjc5NQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK