Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7981AC169C4 for ; Tue, 29 Jan 2019 20:28:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5382020881 for ; Tue, 29 Jan 2019 20:28:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728406AbfA2U2p (ORCPT ); Tue, 29 Jan 2019 15:28:45 -0500 Received: from mx2.suse.de ([195.135.220.15]:43404 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727383AbfA2U2p (ORCPT ); Tue, 29 Jan 2019 15:28:45 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 292AEB009; Tue, 29 Jan 2019 20:28:44 +0000 (UTC) Received: by unicorn.suse.cz (Postfix, from userid 1000) id 8F42CE012B; Tue, 29 Jan 2019 21:28:42 +0100 (CET) Date: Tue, 29 Jan 2019 21:28:42 +0100 From: Michal Kubecek To: Maciej =?iso-8859-2?Q?=AFenczykowski?= Cc: "John W. Linville" , netdev@vger.kernel.org Subject: ethtool - manual changes in ethtool-copy.h Message-ID: <20190129202842.GI24651@unicorn.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello, I'm sorry I didn't notice earlier but ethtool commit 4df55c81996d ("ethtool: change to new sane powerpc64 kernel headers") adds changes to ethtool-copy.h which are not in sync with kernel file it is generated from. This file is supposed to be a copy of the sanitized kernel UAPI header, i.e. what you get as include/linux/ethtool.h by "make headers_install" in kernel tree. (The copy in ethtool git is currently a bit behind but the missing recent changes only modify comments so that it's not really a problem.) Modifying this file manually would mean that anyone who would update it in the future (to sync with kernel changes) could not simply copy the sanitized kernel header but would have to make sure to add your fragment to it. As you only need to define the __SANE_USERSPACE_TYPES__ macro (on ppc64), it might be possible to achieve the same goal in Makefile. Michal Kubecek