From: sbabic at denx.de Date: Wed, 30 Jan 2019 09:05:21 +0000 (UTC) Subject: [U-Boot] pinctrl: imx: Fix select input issue In-Reply-To: <1546592890-41115-1-git-send-email-ye.li@nxp.com> Message-ID: <20190130090703.3119FC21DFA@lists.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > The pinctrl supports to set any bit in input register on iMX6 if > the MSB of input value is 0xff. But the driver uses signed int for > input value, so when executing the codes below, it won't meet. > Because this is arithmetic right shift. > if (input_val >> 24 == 0xff) > Fix the issue by changing the input_val, config_val and mux_mode to u32. > Signed-off-by: Ye Li > Reviewed-by: Fugang Duan > Reviewed-by: Peng Fan Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================