Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CD2EC282D7 for ; Wed, 30 Jan 2019 16:06:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2026D207E0 for ; Wed, 30 Jan 2019 16:06:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="2Ar9/so7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731803AbfA3QGq (ORCPT ); Wed, 30 Jan 2019 11:06:46 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:60950 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731788AbfA3QGp (ORCPT ); Wed, 30 Jan 2019 11:06:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=b75D1MfVlxjBqPOgJuSV1HuXRbMxv/A+k4kaABI3B/E=; b=2Ar9/so71OW7KpmhLDq0vPQ7O8 nrPxsCU0EZVJy7uGO88R6vd2R1kDMxKOmtmtsOqawjv8MXao5ia2nazber5/Q9RVmDE4RRJ/aMBvQ V3G0CStDb1rWRwanYLSncwflHBzagZeE5tO5PnfO96j71Mad046DcN2Z0x/fxof+aPhY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gosNr-0004Pl-T8; Wed, 30 Jan 2019 17:06:39 +0100 Date: Wed, 30 Jan 2019 17:06:39 +0100 From: Andrew Lunn To: Florian Fainelli Cc: netdev@vger.kernel.org, vivien.didelot@gmail.com, davem@davemloft.net, idosch@mellanox.com, jiri@mellanox.com, ilias.apalodimas@linaro.org, ivan.khoronzhuk@linaro.org, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com Subject: Re: [PATCH net-next v2 10/12] net: dsa: Wire up multicast IGMP snooping attribute notification Message-ID: <20190130160639.GE15050@lunn.ch> References: <20190130005548.2212-1-f.fainelli@gmail.com> <20190130005548.2212-11-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190130005548.2212-11-f.fainelli@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jan 29, 2019 at 04:55:46PM -0800, Florian Fainelli wrote: > The bridge can at runtime be configured with or without IGMP snooping > enabled but we were not processing the switchdev attribute that notifies > about that toggle, do this now. > > Signed-off-by: Florian Fainelli > --- > include/net/dsa.h | 2 ++ > net/dsa/dsa_priv.h | 11 +++++++++++ > net/dsa/port.c | 13 +++++++++++++ > net/dsa/slave.c | 4 ++++ > net/dsa/switch.c | 28 ++++++++++++++++++++++++++++ > 5 files changed, 58 insertions(+) > > diff --git a/include/net/dsa.h b/include/net/dsa.h > index 7f2a668ef2cc..2ee1ede7df5c 100644 > --- a/include/net/dsa.h > +++ b/include/net/dsa.h > @@ -425,6 +425,8 @@ struct dsa_switch_ops { > /* > * Multicast database > */ > + int (*port_multicast_toggle)(struct dsa_switch *ds, int port, > + bool mc_disabled); Hi Florin Looks like there is an extra tab in there? Andrew