Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BAB4C282D7 for ; Wed, 30 Jan 2019 23:20:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B937D20881 for ; Wed, 30 Jan 2019 23:20:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="4aWtRx5F" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730599AbfA3XUa (ORCPT ); Wed, 30 Jan 2019 18:20:30 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:33355 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725613AbfA3XU3 (ORCPT ); Wed, 30 Jan 2019 18:20:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/7YCC9w3SpbUAgLSWi+673JHN7OoVMRsiW8WB+FgVkI=; b=4aWtRx5FVhOa6U6zB2V6+A8CYU 7HlwrT7wWxsnl8UgTIH7oLfFclTp0kTaUgOvb4ds96TBeDQRu6lGzvs5KonpnxexC9eHB2Wg5tF5C q/Bp6xBOpbuVEnIBHPdXNqm8QJ2zflFw53z8kzVOY53Tama2ULspeWUABDpc+B4OgXvc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1goyVK-0008U0-JJ; Wed, 30 Jan 2019 23:38:46 +0100 Date: Wed, 30 Jan 2019 23:38:46 +0100 From: Andrew Lunn To: John David Anglin Cc: Russell King , Vivien Didelot , Florian Fainelli , netdev@vger.kernel.org Subject: Re: net: phylink: dsa: mv88e6xxx: flaky link detection on switch ports with internal PHYs Message-ID: <20190130223846.GB30115@lunn.ch> References: <49eec816-9238-c893-0860-602aa8965515@bell.net> <20190122202834.GB12052@lunn.ch> <09fce2e0-9dd2-ea30-7e7d-72f04eede68b@bell.net> <20190122223649.GD3634@lunn.ch> <20190123002240.GF3634@lunn.ch> <20190130172818.GJ21904@lunn.ch> <2ea9fd81-f92d-9505-dd0b-bdd0f67d8ce7@bell.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2ea9fd81-f92d-9505-dd0b-bdd0f67d8ce7@bell.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 30, 2019 at 05:24:53PM -0500, John David Anglin wrote: > On 2019-01-30 12:28 p.m., Andrew Lunn wrote: > > You need active low interrupts. Without it, i think you are always > > going to have race conditions which will cause interrupts to get > > stuck/lost. > I don't know if this is a hardware limitation or not, but currently the > armada 37xx doesn't support > level interrupts: Yes, i had a quick look at the pinctrl driver. It only has code for edges. I'd suggest you take a look at the datasheet for the 37xx and check what the hardware actually supports. You might need to extend the driver. Andrew