Received: from eggs.gnu.org ([209.51.188.92]:49510) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpcOF-0005LT-RV for qemu-devel@nongnu.org; Fri, 01 Feb 2019 12:14:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gpcOF-0000hL-1v for qemu-devel@nongnu.org; Fri, 01 Feb 2019 12:14:07 -0500 Date: Fri, 1 Feb 2019 18:13:55 +0100 From: Cornelia Huck Message-ID: <20190201181355.40201b0c.cohuck@redhat.com> In-Reply-To: <3f4345e4-611a-b231-e7c7-73a34d4f2433@redhat.com> References: <20190201124543.5945-1-cohuck@redhat.com> <6239c630-24d1-f68f-ec16-023e1f37148d@linux.ibm.com> <3f4345e4-611a-b231-e7c7-73a34d4f2433@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] s390x/pci: mark zpci devices as unmigratable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: Collin Walling , Thomas Huth , Pierre Morel , qemu-devel@nongnu.org, Christian Borntraeger , qemu-s390x@nongnu.org, Richard Henderson On Fri, 1 Feb 2019 17:06:26 +0100 David Hildenbrand wrote: > On 01.02.19 16:41, Collin Walling wrote: > > On 2/1/19 7:45 AM, Cornelia Huck wrote: > >> We currently don't migrate any state for zpci devices, which are > >> coupled with standard pci devices. This means funny things happen > >> when we e.g. try to migrate with a virtio-pci device but the s390x- > >> specific zpci state is not migrated (vfio-pci is not affected, as > >> it is not migratable anyway.) > >> > >> Until this is fixed, mark zpci devices as unmigratable. > >> > >> Reported-by: David Hildenbrand > >> Signed-off-by: Cornelia Huck > >> --- > >> > >> This is just a stop-gap measure to give us time to implement the > >> needed migration code properly. > > > > I imagine this means we'll want a single migration handler that will > > take care of PCI and zPCI in one go, that way the data stays coupled? > > > > Just throwing thoughts out there. > > Guess this won't really be possible. Each device is to migrate "itself". > We'll then also have to see which parts of the host bridge requires > migration. Most probably not that easy. Migrating timers and such. > Taking care of resets... > > As I am planning to end my journey to wondeful zpci land for now (but I > might eventually look into it again in the future), I won't be looking > into migration. > > If IBM has some resources for that, very much appreciated. And I'd be happy to queue such patches (just as I did right now for this patch :)