Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F047EC282C4 for ; Mon, 4 Feb 2019 10:37:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD9732176F for ; Mon, 4 Feb 2019 10:37:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549276674; bh=p9ts7ugc69AyPCsCEyf2XXJieltkERD9Fgpyn7XjeW8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=aNuRoYP5zKIpE8QsCQov8hfjFNxpYE+/Ekm1PCaB48YSj4W/5Cy0w1Bqs/GRy5vD6 ZA8Mqf77tygout3n3ZzG7qsUcS2kkVa6hpHLPIsIhnHAHanmF5yZon5KDg/R/mNMrq QuClqEu/9wBTrokGncbwZHysbtDIbi2aXUzHzgqY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728578AbfBDKhy (ORCPT ); Mon, 4 Feb 2019 05:37:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:33260 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728177AbfBDKhy (ORCPT ); Mon, 4 Feb 2019 05:37:54 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 041FB2070C; Mon, 4 Feb 2019 10:37:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549276673; bh=p9ts7ugc69AyPCsCEyf2XXJieltkERD9Fgpyn7XjeW8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dz924F/O5uoZykLo/nIF8YU6sifLftGm1r5iXHpjFFCBXfXG3gteTgZ/ZMv3xzJWb xjJAxI68cNyg2NOgIrvOwnAMpt33wIjZ7vSbAthMZFQm5r2aY9EzqyAaNRrySOhGBA p1hrC+DmXQatV5dWyxhgzmpSEmiH5tO/McxaMI+o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ross Lagerwall , Pravin B Shelar , "David S. Miller" Subject: [PATCH 3.18 01/31] openvswitch: Avoid OOB read when parsing flow nlattrs Date: Mon, 4 Feb 2019 11:36:16 +0100 Message-Id: <20190204103558.323632266@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190204103557.903263774@linuxfoundation.org> References: <20190204103557.903263774@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ross Lagerwall [ Upstream commit 04a4af334b971814eedf4e4a413343ad3287d9a9 ] For nested and variable attributes, the expected length of an attribute is not known and marked by a negative number. This results in an OOB read when the expected length is later used to check if the attribute is all zeros. Fix this by using the actual length of the attribute rather than the expected length. Signed-off-by: Ross Lagerwall Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/openvswitch/flow_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/openvswitch/flow_netlink.c +++ b/net/openvswitch/flow_netlink.c @@ -314,7 +314,7 @@ static int __parse_flow_nlattrs(const st return -EINVAL; } - if (!nz || !is_all_zero(nla_data(nla), expected_len)) { + if (!nz || !is_all_zero(nla_data(nla), nla_len(nla))) { attrs |= 1 << type; a[type] = nla; }