Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A400DC282C4 for ; Mon, 4 Feb 2019 13:46:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 677462081B for ; Mon, 4 Feb 2019 13:46:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="XWnUBoEx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731380AbfBDNqd (ORCPT ); Mon, 4 Feb 2019 08:46:33 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:37970 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726585AbfBDNqc (ORCPT ); Mon, 4 Feb 2019 08:46:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FG6nxCz9vNjtInJuaUWlnZetD2A/9hXNFl6LJY//8eo=; b=XWnUBoExnGBNrzuwZRVE0gQdfg EHbNw2nqogR8PyUjpfkCoDmjJ+ZAbDNWD9CFm3Dy/ajzYxg1TcGexhkKi95lmneVPvYvINt6XnIJ+ tPYrU0ZDtg8tuU9M4gImsKCpSP5ANsnUpmkLhsv5mWnjIYE4btke4IQuzqjhVCn4TPXA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gqeZy-0005MC-4F; Mon, 04 Feb 2019 14:46:30 +0100 Date: Mon, 4 Feb 2019 14:46:30 +0100 From: Andrew Lunn To: Pankaj Bansal Cc: Florian Fainelli , "netdev@vger.kernel.org" Subject: Re: [PATCH v2 2/2] netdev/phy: add MDIO bus multiplexer driven by a regmap Message-ID: <20190204134630.GC19474@lunn.ch> References: <20190204142435.21175-1-pankaj.bansal@nxp.com> <20190204142435.21175-3-pankaj.bansal@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190204142435.21175-3-pankaj.bansal@nxp.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 04, 2019 at 08:59:50AM +0000, Pankaj Bansal wrote: > Add support for an MDIO bus multiplexer controlled by a regmap > device, like an FPGA. Hi Pankaj Thanks for adding the binding documentation. > diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile > index 5805c0b7d60e..0827a700eb31 100644 > --- a/drivers/net/phy/Makefile > +++ b/drivers/net/phy/Makefile > @@ -26,6 +26,7 @@ obj-$(CONFIG_MDIO_BCM_IPROC) += mdio-bcm-iproc.o > obj-$(CONFIG_MDIO_BCM_UNIMAC) += mdio-bcm-unimac.o > obj-$(CONFIG_MDIO_BITBANG) += mdio-bitbang.o > obj-$(CONFIG_MDIO_BUS_MUX) += mdio-mux.o > +obj-$(CONFIG_MDIO_BUS_MUX_REGMAP) += mdio-mux-regmap.o > obj-$(CONFIG_MDIO_BUS_MUX_BCM_IPROC) += mdio-mux-bcm-iproc.o > obj-$(CONFIG_MDIO_BUS_MUX_GPIO) += mdio-mux-gpio.o > obj-$(CONFIG_MDIO_BUS_MUX_MMIOREG) += mdio-mux-mmioreg.o We try to keep the Makefile sorting in alphabetical order. > +/** > + * mdio_mux_regmap_uninit - relinquish the control of MDIO bus muxing using > + * regmap constructs. > + * @data: address of data allocated by mdio_mux_regmap_init > + */ > +int mdio_mux_regmap_uninit(void *data) > +{ > + struct mdio_mux_regmap_state *s = data; > + > + mdio_mux_uninit(s->mux_handle); > + > + return 0; > +} Please make this a void function, since there is nothing to return. Andrew