Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37BF1C282C4 for ; Mon, 4 Feb 2019 19:35:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4BAC20821 for ; Mon, 4 Feb 2019 19:35:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="HfXn6A9K" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728174AbfBDTf0 (ORCPT ); Mon, 4 Feb 2019 14:35:26 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:38448 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726533AbfBDTf0 (ORCPT ); Mon, 4 Feb 2019 14:35:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mnS8ZOFZTIfabaoZMEnggtg9rwXhrAiIVsn0/Vbmc9g=; b=HfXn6A9K+VY78JPAzVxj1u9e/l t0lE8iPu1kimKuLl+TrZSpsYbNdCsi4rxynwVVTvnOgQOQyaazPoAa6EjiTMACqNPGTP4EzlZYAqT MWIRS2g4QPsFO/Ri2dbq8C//YEMulSQUATFi0POvaDd1F43XciZtUwGAeS7725oz2OUI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gqk1W-0000OX-LO; Mon, 04 Feb 2019 20:35:18 +0100 Date: Mon, 4 Feb 2019 20:35:18 +0100 From: Andrew Lunn To: John David Anglin Cc: Russell King , Vivien Didelot , Florian Fainelli , netdev@vger.kernel.org Subject: Re: [PATCH] net: phylink: dsa: mv88e6xxx: Revise irq setup ordering Message-ID: <20190204193518.GE24989@lunn.ch> References: <20190122223649.GD3634@lunn.ch> <20190123002240.GF3634@lunn.ch> <20190130172818.GJ21904@lunn.ch> <2ea9fd81-f92d-9505-dd0b-bdd0f67d8ce7@bell.net> <20190130223846.GB30115@lunn.ch> <9415d82e-965b-7777-0ad0-f23d6c9f177e@bell.net> <53b49df8-53ed-704f-9197-230b18d83090@bell.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <53b49df8-53ed-704f-9197-230b18d83090@bell.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 04, 2019 at 01:37:13PM -0500, John David Anglin wrote: > This change fixes a race condition in the setup of hardware irqs and the > code enabling PHY link > detection. > > This was observed on the espressobin board where the GPIO interrupt > controller only supports edge > interrupts.  If the INTn output pin goes low before the GPIO interrupt > is enabled, PHY link interrupts > are not detected. Hi David Please break this up into two patches. Masking interrupts in the setup code before enabling the interrupt i'm happy with. The change to the interrupt handler i'm pretty sure is wrong. You have to accept with edge interrupts you are going to loose interrupts. Andrew