Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 696DDC282C4 for ; Tue, 5 Feb 2019 02:45:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32B0B20818 for ; Tue, 5 Feb 2019 02:45:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="xEaHoCRj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727119AbfBECpg (ORCPT ); Mon, 4 Feb 2019 21:45:36 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:38961 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725888AbfBECpg (ORCPT ); Mon, 4 Feb 2019 21:45:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=IKxjkWB8hCGiZyVqQI0dtVre6XCGcOVQsLbDKdhE+nU=; b=xEaHoCRjTzLsTx3iSC5mvebTab CTihCEIWSrFRImrQ/omNQI0T+0nrDcbzpE4eLJz66BQGru2vkY/YkfYsEmWCCKE8ijHFX5V6q0WHf QlLMRdukXKqy17Q74jliR13CzDtHfxLN31zuX8340Sk9rNB8HC1o00Frd5TggYfFriT8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gqqjt-0003CE-Vv; Tue, 05 Feb 2019 03:45:33 +0100 Date: Tue, 5 Feb 2019 03:45:33 +0100 From: Andrew Lunn To: Christian Lamparter Cc: netdev@vger.kernel.org, Florian Fainelli , Vivien Didelot Subject: Re: [PATCH v1] net: dsa: qca8k: implement DT-based ports <-> phy translation Message-ID: <20190205024533.GB10838@lunn.ch> References: <20190204213555.26054-1-chunkeey@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190204213555.26054-1-chunkeey@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 04, 2019 at 10:35:55PM +0100, Christian Lamparter wrote: > The QCA8337 enumerates 5 PHYs on the MDC/MDIO access: PHY0-PHY4. > Based on the System Block Diagram in Section 1.2 of the > QCA8337's datasheet. These PHYs are internally connected > to MACs of PORT 1 - PORT 5. However, neither qca8k's slave > mdio access functions qca8k_phy_read()/qca8k_phy_write() > nor the dsa framework is set up for that. > > This version of the patch uses the existing phy-handle > properties of each specified DSA Port in the DT to map > each PORT/MAC to its exposed PHY on the MDIO bus. This > is supported by the current binding document qca8k.txt > as well. Hi Christian Looking at Documentation/devicetree/bindings/net/dsa/qca8k.txt I think everything you need is already implemented. What problem do you actually have? Thanks Andrew