From: Roger Pau =?utf-8?B?TW9ubsOp?= Subject: Re: [PATCH for-4.12 2/8] amd/ntp: remove assert that prevents creating 2M MMIO entries Date: Tue, 5 Feb 2019 14:38:58 +0100 Message-ID: <20190205133858.udgiqnkgw7willkr@mac> References: <20190130103646.53649-1-roger.pau@citrix.com> <20190130103646.53649-3-roger.pau@citrix.com> <5C586EB60200007800213BDC@prv1-mh.provo.novell.com> <20190204171847.q3cymyuclraa77lm@mac> <5C593F340200007800213D19@prv1-mh.provo.novell.com> <20190205104047.ru4qqpphq5p4odyy@mac> <5C59851E0200007800213EF7@prv1-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gr0wM-0000kC-E6 for xen-devel@lists.xenproject.org; Tue, 05 Feb 2019 13:39:06 +0000 Content-Disposition: inline In-Reply-To: <5C59851E0200007800213EF7@prv1-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Jan Beulich Cc: Juergen Gross , Wei Liu , George Dunlap , Andrew Cooper , george.dunlap@citrix.com, xen-devel List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBGZWIgMDUsIDIwMTkgYXQgMDU6NDQ6MTRBTSAtMDcwMCwgSmFuIEJldWxpY2ggd3Jv dGU6Cj4gPj4+IE9uIDA1LjAyLjE5IGF0IDExOjQwLCA8cm9nZXIucGF1QGNpdHJpeC5jb20+IHdy b3RlOgo+ID4gT24gVHVlLCBGZWIgMDUsIDIwMTkgYXQgMTI6NDU6NTZBTSAtMDcwMCwgSmFuIEJl dWxpY2ggd3JvdGU6Cj4gPj4gPj4+IE9uIDA0LjAyLjE5IGF0IDE4OjE4LCA8cm9nZXIucGF1QGNp dHJpeC5jb20+IHdyb3RlOgo+ID4+ID4gT24gTW9uLCBGZWIgMDQsIDIwMTkgYXQgMDk6NTY6MjJB TSAtMDcwMCwgSmFuIEJldWxpY2ggd3JvdGU6Cj4gPj4gPj4gPj4+IE9uIDMwLjAxLjE5IGF0IDEx OjM2LCA8cm9nZXIucGF1QGNpdHJpeC5jb20+IHdyb3RlOgo+ID4+ID4+ID4gVGhlIGFzc2VydCB3 YXMgb3JpZ2luYWxseSBhZGRlZCB0byBtYWtlIHN1cmUgdGhhdCBoaWdoZXIgb3JkZXIKPiA+PiA+ PiA+IHJlZ2lvbnMgKD4gUEFHRV9PUkRFUl80SykgY291bGQgbm90IGJlIHVzZWQgdG8gYnlwYXNz IHRoZQo+ID4+ID4+ID4gbW1pb19yb19yYW5nZXMgY2hlY2sgcGVyZm9ybWVkIGJ5IHAybV90eXBl X3RvX2ZsYWdzLgo+ID4+ID4+ID4gCj4gPj4gPj4gPiBUaGlzIGhvd2V2ZXIgaXMgYWxyZWFkeSBj aGVja2VkIGluIHNldF9tbWlvX3AybV9lbnRyeSwgd2hpY2ggbWFrZXMKPiA+PiA+PiA+IHN1cmUg dGhhdCBoaWdoZXIgb3JkZXIgbWFwcGluZ3MgZG9uJ3Qgb3ZlcmxhcCB3aXRoIG1taW9fcm9fcmFu Z2VzLAo+ID4+ID4+ID4gdGh1cyBhbGxvd2luZyB0aGUgY3JlYXRpb24gb2YgaGlnaCBvcmRlciBN TUlPIG1hcHBpbmdzIHNhZmVseS4KPiA+PiA+PiAKPiA+PiA+PiBXZWxsLCB0aGUgYXNzZXJ0aW9u cyB3ZXJlIGFkZGVkIHRvIG1ha2Ugc3VyZSBubyBvdGhlciBjb2RlCj4gPj4gPj4gcGF0aCBhcHBl YXJzIHRoYXQgdmlvbGF0ZXMgdGhpcyByZXF1aXJlbWVudC4gQXJndWFibHkgZS5nLgo+ID4+ID4+ IHNldF9pZGVudGl0eV9wMm1fZW50cnkoKSBjb3VsZCBnYWluIGFuIG9yZGVyIHBhcmFtZXRlciBh bmQKPiA+PiA+PiB0aGVuIHRyeSB0byBlc3RhYmxpc2ggbGFyZ2VyIHAybV9tbWlvX2RpcmVjdCBl bnRyaWVzLgo+ID4+ID4+IAo+ID4+ID4+IERvbid0IGdldCBtZSB3cm9uZywgSSBkb24ndCBvYmpl Y3QgdG8gdGhlIHJlbW92YWwgb2YgdGhlCj4gPj4gPj4gYXNzZXJ0aW9ucywgYnV0IHRoZSBkZXNj cmlwdGlvbiBtYWtlcyBpdCBzb3VuZCBhcyBpZiB0aGV5IHdlcmUKPiA+PiA+PiBlbnRpcmVseSBy ZWR1bmRhbnQuIEV2ZW4gYmV0dGVyIHdvdWxkIGJlIHRob3VnaCBpZiB0aGV5Cj4gPj4gPj4gY291 bGQgYmUgZXh0ZW5kZWQgdG8ga2VlcCB0cmlnZ2VyaW5nIGluICJiYWQiIGNhc2VzLgo+ID4+ID4g Cj4gPj4gPiBJIGNvdWxkIGFkZCBzb21ldGhpbmcgbGlrZToKPiA+PiA+IAo+ID4+ID4gQVNTRVJU KCFyYW5nZXNldF9vdmVybGFwc19yYW5nZShtbWlvX3JvX3JhbmdlcywgbWZuX3gobWZuKSwKPiA+ PiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWZuX3gobWZuKSArIFBGTl9ET1dO KE1CKDIpKSkpOwo+ID4+ID4gCj4gPj4gPiBJIHRoaW5rIHRoaXMgc2hvdWxkIGJlIHNhZmUgYW5k IHdvdWxkIHRyaWdnZXIgaW4gY2FzZSBvZiBtaXN1c2UuCj4gPj4gCj4gPj4gTG9va3Mgb2theSwg aWYgc2xpZ2h0bHkgZXh0ZW5kZWQgKG9yIG1hZGUgY29uZGl0aW9uYWwpIHRvIGV4Y2x1ZGUKPiA+ PiB0aGUgYWRkaXRpb24gb2YgTUIoMikgdG8gTUZOX0lOVkFMSUQgdG8gd3JhcCBhbmQgcG90ZW50 aWFsbHkKPiA+PiBoaXQgYSByL28gcmFuZ2UgaW4gdGhlIGxvdyAxTWIuCj4gPiAKPiA+IEFjaywg c28gaXQgd291bGQgYmU6Cj4gPiAKPiA+IEFTU0VSVChtZm5fZXEobWZuLCBJTlZBTElEX01GTikg fHwKPiA+ICAgICAgICAhcmFuZ2VzZXRfb3ZlcmxhcHNfcmFuZ2UobW1pb19yb19yYW5nZXMsIG1m bl94KG1mbiksCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1mbl94KG1mbikg KyBQRk5fRE9XTihNQigyKSkpKTsKPiAKPiBCdXQgdGhhdCdzIHN0aWxsIGRyb3BwaW5nIHRoZSBv dGhlciBhc3BlY3Qgb2YgdGhlIG9yaWdpbmFsIEFTU0VSVCgpOgo+IAo+ID4+ID4+ID4gLS0tIGEv eGVuL2FyY2gveDg2L21tL3AybS1wdC5jCj4gPj4gPj4gPiArKysgYi94ZW4vYXJjaC94ODYvbW0v cDJtLXB0LmMKPiA+PiA+PiA+IEBAIC02NjgsNyArNjY4LDYgQEAgcDJtX3B0X3NldF9lbnRyeShz dHJ1Y3QgcDJtX2RvbWFpbiAqcDJtLCBnZm5fdCBnZm5fLCBtZm5fdCBtZm4sCj4gPj4gPj4gPiAg ICAgICAgICB9Cj4gPj4gPj4gPiAgCj4gPj4gPj4gPiAgICAgICAgICBBU1NFUlQocDJtX2ZsYWdz X3RvX3R5cGUoZmxhZ3MpICE9IHAybV9pb3JlcV9zZXJ2ZXIpOwo+ID4+ID4+ID4gLSAgICAgICAg QVNTRVJUKCFtZm5fdmFsaWQobWZuKSB8fCBwMm10ICE9IHAybV9tbWlvX2RpcmVjdCk7Cj4gCj4g SXQgYWxzbyBtYWRlIHN1cmUgdGhhdCAidmFsaWQiIE1GTnMgY2FuJ3QgYmUgdXNlZCBmb3IgbWFw cGluZ3Mgd2l0aAo+IHAybV9tbWlvX2RpcmVjdCB0eXBlLiBFeGNlcHQgdGhhdCBJIHJlYWxpemUg bm93IHRoYXQgdGhpcyBpcyB3cm9uZyBpbgo+IGNlcnRhaW4gY2FzZXMsIGJlY2F1c2UgTU1JTyBw YWdlcyBtYXkgYWN0dWFsbHkgaGF2ZSAidmFsaWQiIE1GTnMuCj4gbWZuX3ZhbGlkKCksIGFmdGVy IGFsbCwgb25seSB0ZWxscyB1cyB3aGV0aGVyIHRoZXJlJ3MgYSBzdHJ1Y3QgcGFnZV9pbmZvCj4g Zm9yIHRoZSBNRk4uIEkgd29uZGVyIGlmIGl0J3MgcmVhbGx5IHRoaXMgYnJva2VubmVzcyB0aGF0 IHlvdSBoaXQsCj4gcmF0aGVyIHRoYW4gd2hhdCBpcyBleHBsYWluZWQgaW4gdGhlIGRlc2NyaXB0 aW9uLgo+IAo+IFdoZW4gdGhlIGFzc2VydGlvbiB3YXMgaW50cm9kdWNlZCwgTU1JTyB3YXNuJ3Qg aGFuZGxlZCBieSB0aGUKPiBjb2RlIGNvcnJlY3RseSBhbnl3YXkgKCFtZm5fdmFsaWQoKSBNRk5z IHdvdWxkIG5vdCBoYXZlIGdvdCBhbnkKPiBtYXBwaW5ncyBhdCBhbGwgaW4gdGhlIDJNIGFuZCAx RyBwYXRocyksIHdoZXJlYXMgbm93IHdlIGhhdmUKPiBwMm1fYWxsb3dzX2ludmFsaWRfbWZuKCkg dGhlcmUuIFNvIHRoZSBzaXR1YXRpb24gaGFzIGJlY29tZSB3b3JzZQo+IHdpdGggb3RoZXIgbmVh cmJ5IGNoYW5nZXMuIEFzIGEgcmVzdWx0IEkgdGhpbmsgd2Ugd2FudCB0byBjb3JyZWN0Cj4gdGhl IGFzc2VydGlvbiBoZXJlIGFsb25nc2lkZSB0aGUgYWRkaXRpb24gb2Ygd2hhdCB5b3Ugc3VnZ2Vz dAo+IGFib3ZlLiBXaGF0IGFib3V0Cj4gCj4gICAgIGlmICggcDJtdCAhPSBwMm1fbW1pb19kaXJl Y3QgKQo+ICAgICAgICAgQVNTRVJUKG1mbl92YWxpZChtZm4pIHx8IChtZm5fZXEobWZuLCBJTlZB TElEX01GTikgJiYKPiAgICAgICAgICAgICAgICBwMm1fYWxsb3dzX2ludmFsaWRfbWZuKHAybXQp KSk7Cj4gICAgIGVsc2UKPiAgICAgICAgIEFTU0VSVCghbWZuX2VxKG1mbiwgSU5WQUxJRF9NRk4p ICYmCj4gICAgICAgICAgICAgICAgIXJhbmdlc2V0X292ZXJsYXBzX3JhbmdlKG1taW9fcm9fcmFu Z2VzLCBtZm5feChtZm4pLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBtZm5feChtZm4pICsgUEZOX0RPV04oTUIoMikpKSk7CgpJIHdvdWxkIHdyaXRlIGl0IGFzICdp ZiAoIHAybXQgPT0gcDJtX21taW9fZGlyZWN0ICkgLi4uIGVsc2UgLi4uJyBidXQKYXBhcnQgZnJv bSB0aGF0IExHVE0uIElmIHlvdSBhcmUgZmluZSB3aXRoIHRoaXMgYWRqdXN0bWVudCBJIHdpbGwK Y2hhbmdlIGl0IGluIHByZXBhcmF0aW9uIGZvciB2Mi4KClRoYW5rcywgUm9nZXIuCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGlu ZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnBy b2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs