Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 05 Feb 2019 14:46:32 -0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by Galois.linutronix.de with esmtps (TLS1.2:RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gr1za-0007SL-LT for speck@linutronix.de; Tue, 05 Feb 2019 15:46:31 +0100 Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gr1zZ-0004Q7-BW for speck@linutronix.de; Tue, 05 Feb 2019 14:46:29 +0000 Date: Tue, 5 Feb 2019 15:46:27 +0100 From: Peter Zijlstra Subject: [MODERATED] Re: [PATCH v1 2/9] PERFv1 6 Message-ID: <20190205144627.GU17528@hirez.programming.kicks-ass.net> References: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Mon, Feb 04, 2019 at 05:14:03PM -0800, speck for Andi Kleen wrote: > From: Andi Kleen > Subject: x86/pmu/intel: Add flags argument to x86_pmu::disable > > Add a flags argument to pass the HEF_* flags down to x86_pmu::disable. > This will be used in a followon patch to avoid some redundant > MSR writes when reprograming counters for updates. Neither this nor that follow up patch explains what disable needs these flags for. Now I could probably reverse engineer it; but you really should know better by now.