Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 05 Feb 2019 14:51:13 -0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by Galois.linutronix.de with esmtps (TLS1.2:RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gr248-0007db-EG for speck@linutronix.de; Tue, 05 Feb 2019 15:51:12 +0100 Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gr246-0004R8-QC for speck@linutronix.de; Tue, 05 Feb 2019 14:51:11 +0000 Date: Tue, 5 Feb 2019 15:51:09 +0100 From: Peter Zijlstra Subject: [MODERATED] Re: [PATCH v1 4/9] PERFv1 2 Message-ID: <20190205145109.GV17528@hirez.programming.kicks-ass.net> References: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Mon, Feb 04, 2019 at 05:14:05PM -0800, speck for Andi Kleen wrote: > @@ -242,6 +242,11 @@ struct cpu_hw_events { > struct intel_excl_cntrs *excl_cntrs; > int excl_thread_id; /* 0 or 1 */ > > + /* > + * Manage using counter 3 on Skylake with TSX. > + */ > + bool force_rtm_abort_active; /* We set the MSR */ > + > /* > * AMD specific bits > */ How often must we repeat; no bool in composite types... and could you really not come up with a longer name?