Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 05 Feb 2019 15:17:03 -0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by Galois.linutronix.de with esmtps (TLS1.2:RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gr2T8-0008SC-3Z for speck@linutronix.de; Tue, 05 Feb 2019 16:17:02 +0100 Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gr2T6-0004XV-AA for speck@linutronix.de; Tue, 05 Feb 2019 15:17:01 +0000 Date: Tue, 5 Feb 2019 16:16:57 +0100 From: Peter Zijlstra Subject: [MODERATED] Re: [PATCH v1 4/9] PERFv1 2 Message-ID: <20190205151657.GW17528@hirez.programming.kicks-ass.net> References: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Mon, Feb 04, 2019 at 05:14:05PM -0800, speck for Andi Kleen wrote: > +static bool __use_counter3(struct perf_event *event) > +{ > + return event->hw.flags & PERF_X86_EVENT_ABORT_TSX; > +} > + > +static bool use_counter3(struct perf_event *event) > +{ > + return __use_counter3(event) || > + (event->group_leader && __use_counter3(event->group_leader)); > +} See; I _really_ hate this per-event noodling. Why not just have the sysctl tell us if PMC3 is available or not and set FRA when PMC3 gets selected, teh end.