Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 05 Feb 2019 16:36:04 -0000 Received: from mga05.intel.com ([192.55.52.43]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gr3hb-0001k3-Hs for speck@linutronix.de; Tue, 05 Feb 2019 17:36:03 +0100 Date: Tue, 5 Feb 2019 08:35:58 -0800 From: Andi Kleen Subject: [MODERATED] Re: [PATCH v1 4/9] PERFv1 2 Message-ID: <20190205163558.GE31598@tassilo.jf.intel.com> References: <20190205145109.GV17528@hirez.programming.kicks-ass.net> MIME-Version: 1.0 In-Reply-To: <20190205145109.GV17528@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Tue, Feb 05, 2019 at 03:51:09PM +0100, speck for Peter Zijlstra wrote: > On Mon, Feb 04, 2019 at 05:14:05PM -0800, speck for Andi Kleen wrote: > > @@ -242,6 +242,11 @@ struct cpu_hw_events { > > struct intel_excl_cntrs *excl_cntrs; > > int excl_thread_id; /* 0 or 1 */ > > > > + /* > > + * Manage using counter 3 on Skylake with TSX. > > + */ > > + bool force_rtm_abort_active; /* We set the MSR */ > > + > > /* > > * AMD specific bits > > */ > > How often must we repeat; no bool in composite types... and could you > really not come up with a longer name? Okay. However let me point to https://blogs.msdn.microsoft.com/oldnewthing/20081126-00/?p=20073 -Andi