Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 05 Feb 2019 16:37:39 -0000 Received: from mga17.intel.com ([192.55.52.151]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gr3j8-0001sN-EO for speck@linutronix.de; Tue, 05 Feb 2019 17:37:38 +0100 Date: Tue, 5 Feb 2019 08:37:36 -0800 From: Andi Kleen Subject: [MODERATED] Re: [PATCH v1 2/9] PERFv1 6 Message-ID: <20190205163736.GG31598@tassilo.jf.intel.com> References: <20190205144627.GU17528@hirez.programming.kicks-ass.net> MIME-Version: 1.0 In-Reply-To: <20190205144627.GU17528@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Tue, Feb 05, 2019 at 03:46:27PM +0100, speck for Peter Zijlstra wrote: > On Mon, Feb 04, 2019 at 05:14:03PM -0800, speck for Andi Kleen wrote: > > From: Andi Kleen > > Subject: x86/pmu/intel: Add flags argument to x86_pmu::disable > > > > Add a flags argument to pass the HEF_* flags down to x86_pmu::disable. > > This will be used in a followon patch to avoid some redundant > > MSR writes when reprograming counters for updates. > > Neither this nor that follow up patch explains what disable needs these > flags for. Now I could probably reverse engineer it; but you really > should know better by now. Just to know that the counter is getting reused, so can skip the extra MSR disable. I'll mention it. -Andi