From: Paul Kocialkowski Subject: [PATCH v4 3/4] drm/vc4: Detect and ignore underruns caused by out-of-sync dlists Date: Wed, 6 Feb 2019 15:49:05 +0100 Message-ID: <20190206144906.24304-4-paul.kocialkowski@bootlin.com> References: <20190206144906.24304-1-paul.kocialkowski@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1AA6A6E978 for ; Wed, 6 Feb 2019 14:50:33 +0000 (UTC) In-Reply-To: <20190206144906.24304-1-paul.kocialkowski@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Maxime Ripard , Eben Upton , David Airlie , Paul Kocialkowski , Thomas Petazzoni List-Id: dri-devel@lists.freedesktop.org V2hlbiB0aGUgcGlwZWxpbmUgaXMgcmVjb25maWd1cmVkIHdpdGggYSBkaWZmZXJlbnQgbW9kZSwg Y2hhbmdlcyB0YWtlCmVmZmVjdCBpbW1lZGlhdGVseSBmb3IgdGhlIENSVEMgYW5kIGVuY29kZXIg d2hpbGUgdGhlIEhWUyB0YWtlcyBzb21lCnRpbWUgdG8gc3dpdGNoIHRoZSBhY3RpdmUgZGlzcGxh eSBsaXN0LiBUaGlzIHJlc3VsdHMgaW4gYSBwZXJpb2Qgb2YKdGltZSB3aGVyZSB0aGUgcGlwZWxp bmUgaXMgb3V0IG9mIHN5bmMsIHRoYXQgaXMgdmVyeSBsaWtlbHkgdG8gY2F1c2UKYW4gdW5kZXJy dW4gdG8gYmUgcmVwb3J0ZWQuIEJlY2F1c2UgdGhlIHVuZGVycnVuIGlzIG5vdCByZWxhdGVkIHRv IHRoZQpuZXcgY29uZmlndXJhdGlvbiwgcmVwb3J0aW5nIGl0IHRvIHVzZXJzcGFjZSBpcyBhIGZh bHNlIHBvc2l0aXZlLgoKU2luY2UgdGhpcyBvbmx5IGNvbmNlcm5zIHRoZSBmaXJzdCBmcmFtZSBh bmQgd2UgaGF2ZSBubyBpbW1lZGlhdGUgZml4CnRvIGF2b2lkIHRoaXMgc2l0dWF0aW9uLCBkZXRl Y3QgYW5kIHdvcmsgYXJvdW5kIGl0LgoKQSBoZWxwZXIgaXMgaW50cm9kdWNlZCB0byByZXR1cm4g d2hldGhlciB0aGUgZW5hYmxlZCBkaXNwbGF5IGNoYW5uZWxzCmhhdmUgdGhlaXIgZGlzcGxheSBs aXN0IGluIHN5bmMuIFRoaXMgaGludCBpcyBzZXQgd2hlbiB1bm1hc2tpbmcgdGhlCnVuZGVycnVu IGludGVycnVwdCBhbmQgaXQgaXMgdXBkYXRlZCBpbiB0aGUgaW50ZXJydXB0IGl0c2VsZi4KCldp dGggdGhhdCwgdW5kZXJydW4gcmVwb3J0cyB0aGF0IGhhcHBlbiB3aGVuIHRoZSBkaXNwbGF5IGxp c3QgaXMgb3V0IG9mCnN5bmMgYXJlIGlnbm9yZWQuIFRoZSBpbnRlcnJ1cHQgaXMga2VwdCBlbmFi bGVkIHNvIHRoYXQgcHJvcGVyIHVuZGVycnVuCmluZGljYXRpb25zIGNhbiBiZSBwaWNrIHVwIGFz IHNvb24gYXMgdGhlIG5ldyBkaXNwbGF5IGxpc3QgdGFrZXMgb3Zlci4KClNpZ25lZC1vZmYtYnk6 IFBhdWwgS29jaWFsa293c2tpIDxwYXVsLmtvY2lhbGtvd3NraUBib290bGluLmNvbT4KLS0tCiBk cml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9kcnYuaCAgfCAgOCArKysrKysrKwogZHJpdmVycy9ncHUv ZHJtL3ZjNC92YzRfaHZzLmMgIHwgMzUgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKyst LQogZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfcmVncy5oIHwgIDIgKysKIDMgZmlsZXMgY2hhbmdl ZCwgNDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vdmM0L3ZjNF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2Rydi5oCmlu ZGV4IGVhNTk2NzkxMjMxZC4uYTZlZDU1ZGEwZDEwIDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9k cm0vdmM0L3ZjNF9kcnYuaAorKysgYi9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9kcnYuaApAQCAt MTkyLDYgKzE5MiwxMyBAQCBzdHJ1Y3QgdmM0X2RldiB7CiAJICovCiAJYXRvbWljX3QgdW5kZXJy dW47CiAKKwkvKiBTdG9yZXMgd2hldGhlciB0aGUgZGlzcGxheSBsaXN0cyB3ZXJlIHN5bmNyb25p emVkIHdoZW4gdW5tYXNraW5nIHRoZQorCSAqIHVuZGVycnVuIElSUS4gVGhpcyBpcyB1c2VkIHRv IHNraXAgdW5kZXJydW5zIHJlcG9ydGVkIHdoZW4gdGhlCisJICogcGlwZWxpbmUgd2FzIHJlY29u ZmlndXJlZCBidXQgdGhlIHByZXZpb3VzIGRpc3BsYXkgbGlzdCBpcyBzdGlsbAorCSAqIGFjdGl2 ZS4KKwkgKi8KKwlib29sIHVuZGVycnVuX2RsaXN0X3N5bmM7CisKIAlzdHJ1Y3Qgd29ya19zdHJ1 Y3Qgb3ZlcmZsb3dfbWVtX3dvcms7CiAKIAlpbnQgcG93ZXJfcmVmY291bnQ7CkBAIC03OTIsNiAr Nzk5LDcgQEAgZXh0ZXJuIHN0cnVjdCBwbGF0Zm9ybV9kcml2ZXIgdmM0X2h2c19kcml2ZXI7CiB2 b2lkIHZjNF9odnNfZHVtcF9zdGF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKIGludCB2YzRf aHZzX2RlYnVnZnNfcmVncyhzdHJ1Y3Qgc2VxX2ZpbGUgKm0sIHZvaWQgKnVudXNlZCk7CiBpbnQg dmM0X2h2c19kZWJ1Z2ZzX3VuZGVycnVuKHN0cnVjdCBzZXFfZmlsZSAqbSwgdm9pZCAqdW51c2Vk KTsKK2Jvb2wgdmM0X2h2c19jaGVja19kbGlzdF9zeW5jKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYp Owogdm9pZCB2YzRfaHZzX3VubWFza191bmRlcnJ1bihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsK IHZvaWQgdmM0X2h2c19tYXNrX3VuZGVycnVuKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwogCmRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9odnMuYyBiL2RyaXZlcnMvZ3B1L2Ry bS92YzQvdmM0X2h2cy5jCmluZGV4IGQ1YmMzYmNkM2U1MS4uNTNiYTI0YWVkOGZkIDEwMDY0NAot LS0gYS9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9odnMuYworKysgYi9kcml2ZXJzL2dwdS9kcm0v dmM0L3ZjNF9odnMuYwpAQCAtMTc5LDYgKzE3OSwyMyBAQCBzdGF0aWMgaW50IHZjNF9odnNfdXBs b2FkX2xpbmVhcl9rZXJuZWwoc3RydWN0IHZjNF9odnMgKmh2cywKIAlyZXR1cm4gMDsKIH0KIAor Ym9vbCB2YzRfaHZzX2NoZWNrX2RsaXN0X3N5bmMoc3RydWN0IGRybV9kZXZpY2UgKmRldikKK3sK KwlzdHJ1Y3QgdmM0X2RldiAqdmM0ID0gdG9fdmM0X2RldihkZXYpOworCXVuc2lnbmVkIGludCBp OworCisJZm9yIChpID0gMDsgaSA8IFNDQUxFUl9DSEFOTkVMU19DT1VOVDsgaSsrKSB7CisJCWlm ICghKEhWU19SRUFEKFNDQUxFUl9ESVNQQ1RSTFgoaSkpICYgU0NBTEVSX0RJU1BDVFJMWF9FTkFC TEUpKQorCQkJY29udGludWU7CisKKwkJaWYgKEhWU19SRUFEKFNDQUxFUl9ESVNQTEFDVFgoaSkp ICE9CisJCSAgICBIVlNfUkVBRChTQ0FMRVJfRElTUExJU1RYKGkpKSkKKwkJCXJldHVybiBmYWxz ZTsKKwl9CisKKwlyZXR1cm4gdHJ1ZTsKK30KKwogdm9pZCB2YzRfaHZzX21hc2tfdW5kZXJydW4o c3RydWN0IGRybV9kZXZpY2UgKmRldikKIHsKIAlzdHJ1Y3QgdmM0X2RldiAqdmM0ID0gdG9fdmM0 X2RldihkZXYpOwpAQCAtMTk2LDYgKzIxMyw5IEBAIHZvaWQgdmM0X2h2c191bm1hc2tfdW5kZXJy dW4oc3RydWN0IGRybV9kZXZpY2UgKmRldikKIAlzdHJ1Y3QgdmM0X2RldiAqdmM0ID0gdG9fdmM0 X2RldihkZXYpOwogCXUzMiBkaXNwY3RybCA9IEhWU19SRUFEKFNDQUxFUl9ESVNQQ1RSTCk7CiAK KwkvKiBBbiB1bmRlcnJ1biB3aWxsIG9jY3VyIHdoZW4gdGhlIGRpc3BsYXkgbGlzdHMgYXJlIG91 dCBvZiBzeW5jLiAqLworCXZjNC0+dW5kZXJydW5fZGxpc3Rfc3luYyA9IHZjNF9odnNfY2hlY2tf ZGxpc3Rfc3luYyhkZXYpOworCiAJZGlzcGN0cmwgfD0gU0NBTEVSX0RJU1BDVFJMX0RTUEVJU0xV UigwKSB8CiAJCSAgICBTQ0FMRVJfRElTUENUUkxfRFNQRUlTTFVSKDEpIHwKIAkJICAgIFNDQUxF Ul9ESVNQQ1RSTF9EU1BFSVNMVVIoMik7CkBAIC0yMjAsMTkgKzI0MCwzMCBAQCBzdGF0aWMgaXJx cmV0dXJuX3QgdmM0X2h2c19pcnFfaGFuZGxlcihpbnQgaXJxLCB2b2lkICpkYXRhKQogCXN0cnVj dCBkcm1fZGV2aWNlICpkZXYgPSBkYXRhOwogCXN0cnVjdCB2YzRfZGV2ICp2YzQgPSB0b192YzRf ZGV2KGRldik7CiAJaXJxcmV0dXJuX3QgaXJxcmV0ID0gSVJRX05PTkU7CisJYm9vbCBkbGlzdF9z eW5jOwogCXUzMiBzdGF0dXM7CiAKKwlkbGlzdF9zeW5jID0gdmM0X2h2c19jaGVja19kbGlzdF9z eW5jKGRldik7CiAJc3RhdHVzID0gSFZTX1JFQUQoU0NBTEVSX0RJU1BTVEFUKTsKIAogCWlmIChz dGF0dXMgJiAoU0NBTEVSX0RJU1BTVEFUX0VVRkxPVygwKSB8CiAJCSAgICAgIFNDQUxFUl9ESVNQ U1RBVF9FVUZMT1coMSkgfAogCQkgICAgICBTQ0FMRVJfRElTUFNUQVRfRVVGTE9XKDIpKSkgewot CQl2YzRfaHZzX21hc2tfdW5kZXJydW4oZGV2KTsKLQkJdmM0X2h2c19yZXBvcnRfdW5kZXJydW4o ZGV2KTsKKwkJLyogQW4gdW5kZXJydW4gd2lsbCBiZSByZXBvcnRlZCB3aGVuIHRoZSBjdXJyZW50 IGRpc3BsYXkgbGlzdAorCQkgKiB3YXMgbm90IHlldCB1cGRhdGVkIGJ5IHRoZSBoYXJkd2FyZSB0 byB0aGUgcmVxdWVzdGVkIG9uZSBhbmQKKwkJICogdGhlIG90aGVyIGVsZW1lbnRzIG9mIHRoZSBw aXBlbGluZSB3ZXJlIGFscmVhZHkgcmVjb25maWd1cmVkLgorCQkgKiBJZ25vcmUgaXQgaW4gdGhh dCBjYXNlLgorCQkgKi8KKwkJaWYgKHZjNC0+dW5kZXJydW5fZGxpc3Rfc3luYyAmJiBkbGlzdF9z eW5jKSB7CisJCQl2YzRfaHZzX21hc2tfdW5kZXJydW4oZGV2KTsKKwkJCXZjNF9odnNfcmVwb3J0 X3VuZGVycnVuKGRldik7CisJCX0KIAogCQlpcnFyZXQgPSBJUlFfSEFORExFRDsKIAl9CiAKKwl2 YzQtPnVuZGVycnVuX2RsaXN0X3N5bmMgPSBkbGlzdF9zeW5jOworCiAJSFZTX1dSSVRFKFNDQUxF Ul9ESVNQU1RBVCwgU0NBTEVSX0RJU1BTVEFUX0lSUU1BU0soMCkgfAogCQkJCSAgIFNDQUxFUl9E SVNQU1RBVF9JUlFNQVNLKDEpIHwKIAkJCQkgICBTQ0FMRVJfRElTUFNUQVRfSVJRTUFTSygyKSk7 CmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9yZWdzLmggYi9kcml2ZXJzL2dw dS9kcm0vdmM0L3ZjNF9yZWdzLmgKaW5kZXggZTA4MzRkZTg0MTBmLi5jMGM1ZmFkYWY3ZTMgMTAw NjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X3JlZ3MuaAorKysgYi9kcml2ZXJzL2dw dS9kcm0vdmM0L3ZjNF9yZWdzLmgKQEAgLTIxMiw2ICsyMTIsOCBAQAogCiAjZGVmaW5lIFBWX0hB Q1RfQUNUCQkJCTB4MzAKIAorI2RlZmluZSBTQ0FMRVJfQ0hBTk5FTFNfQ09VTlQJCQkzCisKICNk ZWZpbmUgU0NBTEVSX0RJU1BDVFJMICAgICAgICAgICAgICAgICAgICAgICAgIDB4MDAwMDAwMDAK IC8qIEdsb2JhbCByZWdpc3RlciBmb3IgY2xvY2sgZ2F0aW5nIHRoZSBIVlMgKi8KICMgZGVmaW5l IFNDQUxFUl9ESVNQQ1RSTF9FTkFCTEUJCQlCSVQoMzEpCi0tIAoyLjIwLjEKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=