Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4114C282C2 for ; Thu, 7 Feb 2019 12:27:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 72C4820818 for ; Thu, 7 Feb 2019 12:27:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726789AbfBGM1b (ORCPT ); Thu, 7 Feb 2019 07:27:31 -0500 Received: from orbyte.nwl.cc ([151.80.46.58]:41890 "EHLO orbyte.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726561AbfBGM1b (ORCPT ); Thu, 7 Feb 2019 07:27:31 -0500 Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.91) (envelope-from ) id 1grim8-0002FW-Hf; Thu, 07 Feb 2019 13:27:28 +0100 Date: Thu, 7 Feb 2019 13:27:28 +0100 From: Phil Sutter To: David Miller Cc: netdev@vger.kernel.org Subject: Re: [net-next PATCH] net: rtnetlink: Support alias interfaces with RTM_GETLINK Message-ID: <20190207122728.GW26388@orbyte.nwl.cc> Mail-Followup-To: Phil Sutter , David Miller , netdev@vger.kernel.org References: <20190207102438.21448-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190207102438.21448-1-phil@nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 07, 2019 at 11:24:38AM +0100, Phil Sutter wrote: > Align interface name handling regarding alias interfaces in > rtnl_getlink() with dev_ioctl() treating SIOCGIFINDEX ioctl calls. The > latter function strips any colon suffix before doing the interface > lookup, do the same for RTM_GETLINK requests. After a second thought, I'll self-NACK this one: Given that netlink API is completely unrelated to ioctl one, there is no inherent need to do things the same way. Looking at RTM_NEWLINK handler, it seems possible to create interface names containing a colon via netlink. Of course those interfaces are not accessible via ioctl() then, but so are secondary interface addresses which don't have a properly chosen label. Sorry for the noise, Phil