Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C74F9C282C2 for ; Thu, 7 Feb 2019 13:02:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A0DC221904 for ; Thu, 7 Feb 2019 13:02:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727182AbfBGNCS (ORCPT ); Thu, 7 Feb 2019 08:02:18 -0500 Received: from orbyte.nwl.cc ([151.80.46.58]:41974 "EHLO orbyte.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726748AbfBGNCS (ORCPT ); Thu, 7 Feb 2019 08:02:18 -0500 Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.91) (envelope-from ) id 1grjJn-0002Z1-9N; Thu, 07 Feb 2019 14:02:15 +0100 Date: Thu, 7 Feb 2019 14:02:15 +0100 From: Phil Sutter To: Michal Kubecek Cc: netdev@vger.kernel.org, David Miller Subject: Re: [net-next PATCH] net: rtnetlink: Support alias interfaces with RTM_GETLINK Message-ID: <20190207130215.GX26388@orbyte.nwl.cc> Mail-Followup-To: Phil Sutter , Michal Kubecek , netdev@vger.kernel.org, David Miller References: <20190207102438.21448-1-phil@nwl.cc> <20190207122728.GW26388@orbyte.nwl.cc> <20190207123939.GE18410@unicorn.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190207123939.GE18410@unicorn.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, On Thu, Feb 07, 2019 at 01:39:39PM +0100, Michal Kubecek wrote: > On Thu, Feb 07, 2019 at 01:27:28PM +0100, Phil Sutter wrote: > > On Thu, Feb 07, 2019 at 11:24:38AM +0100, Phil Sutter wrote: > > > Align interface name handling regarding alias interfaces in > > > rtnl_getlink() with dev_ioctl() treating SIOCGIFINDEX ioctl calls. The > > > latter function strips any colon suffix before doing the interface > > > lookup, do the same for RTM_GETLINK requests. > > > > After a second thought, I'll self-NACK this one: Given that netlink API > > is completely unrelated to ioctl one, there is no inherent need to do > > things the same way. Looking at RTM_NEWLINK handler, it seems possible > > to create interface names containing a colon via netlink. > > Not since commit a4176a939186 ("net: reject creation of netdev names > with colons") which disallowed using such names in general. In my typical afterthought I tried 'ip link add d0:1 type dummy' and was surprised to get EINVAL from kernel side. Just discovered that line in dev_valid_name(), too. > But I still don't think it would be a good idea. It's bad enough that > (as I just learned to my surprise) "ip link del dummy1:0" deletes dummy1 > without any complaint because ip uses SIOCGIFINDEX ioctl for ifindex > lookup. I'm struggling a bit with all this. The original problem is iproute2 commit 50b9950dd9011 ("link dump filter") which changed 'ip link show' to not use if_indextoname() when given just an interface name. So lookup happens by name (via RTM_GETLINK) and consequently 'ip link show eth0:1' doesn't give link stats of eth0 anymore. Given that iproute2 is supposed to be backwards compatible, the only valid option I see is to make sure netlink API calls like the above behave identical to the ioctl ones they replace. Which means allowing for 'ip link show eth0:42' even if there's no address with that label assigned to eth0 as well as your example above. Cheers, Phil