Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 07 Feb 2019 16:20:55 -0000 Received: from mga06.intel.com ([134.134.136.31]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1grmPz-0006U6-Nu for speck@linutronix.de; Thu, 07 Feb 2019 17:20:53 +0100 Date: Thu, 7 Feb 2019 08:20:47 -0800 From: Andi Kleen Subject: [MODERATED] Re: [PATCH v2 0/8] PERFv2 Message-ID: <20190207162047.GR31598@tassilo.jf.intel.com> References: <20190207132709.GA32477@hirez.programming.kicks-ass.net> <20190207143759.GP31598@tassilo.jf.intel.com> <20190207153728.GE32477@hirez.programming.kicks-ass.net> MIME-Version: 1.0 In-Reply-To: <20190207153728.GE32477@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: > > Doesn't that overwrite the global shared constraints constraints? > > Would need to make them non const at least, it will likely fault. > > They are !const; we already update them at init time (for example we add > the GPRs to the fixed ones etc..). Surely not for emptyconstraint ? > > > Okay I see you rely on it being guarded by the global, but for virtualization > > support will need the copy. > > > > Would need a copy at least. > > I've not thought abou virt yet; do we _have_ to expose the thing to > guests? Yes I think so. It's the only way to use all four counters in a guest. -Andi