Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADBA8C169C4 for ; Fri, 8 Feb 2019 22:47:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 84AA821908 for ; Fri, 8 Feb 2019 22:47:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726836AbfBHWrA (ORCPT ); Fri, 8 Feb 2019 17:47:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:34898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726353AbfBHWrA (ORCPT ); Fri, 8 Feb 2019 17:47:00 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 75370218DA; Fri, 8 Feb 2019 22:46:59 +0000 (UTC) Date: Fri, 8 Feb 2019 17:46:58 -0500 From: Steven Rostedt To: Tzvetomir Stoyanov Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH v3 5/7] trace-cmd: Refactored make_instances() and tracecmd_remove_instances() Message-ID: <20190208174658.05fcc0df@gandalf.local.home> In-Reply-To: <20190208174409.74df79a3@gandalf.local.home> References: <20190208134918.5618-1-tstoyanov@vmware.com> <20190208134918.5618-6-tstoyanov@vmware.com> <20190208174409.74df79a3@gandalf.local.home> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Fri, 8 Feb 2019 17:44:09 -0500 Steven Rostedt wrote: > On Fri, 8 Feb 2019 15:49:16 +0200 > Tzvetomir Stoyanov wrote: > > > +static void tracecmd_remove_one_instance(struct buffer_instance *instance) > > +{ > > + char *path; > > + > > + if (instance->tracing_on_fd > 0) { > > + close(instance->tracing_on_fd); > > + instance->tracing_on_fd = 0; > > Also note that uninitialized file descriptors should be a negative > number (-1), because zero is a valid descriptor value. Bah, nevermind. Looks like I was a bit more lenient back in the day... d56f30679 trace-record.c (Steven Rostedt (Red Hat) 2013-03-06 11:31:39 -0500 1938) /* OK, we keep zero for stdin */ d56f30679 trace-record.c (Steven Rostedt (Red Hat) 2013-03-06 11:31:39 -0500 1939) if (fd > 0) 6e7c1dd76 trace-record.c (Steven Rostedt 2011-02-23 13:28:04 -0500 1940) return fd; ;-) -- Steve