From: Tom Rini Date: Mon, 11 Feb 2019 10:30:28 -0500 Subject: [U-Boot] [U-Boot, v4, 1/1] avb: add support for named persistent values In-Reply-To: References: <1548599645-9252-1-git-send-email-igor.opaniuk@linaro.org> <20190209125037.GF16814@bill-the-cat> Message-ID: <20190211153028.GF16814@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Feb 11, 2019 at 04:59:54PM +0200, Igor Opaniuk wrote: > Hi Tom, > > Thanks for pointing that out. > I've done a little investigation, and the interesting thing is that it > never fails when I exclude other tests, for example, running only > ut_dm subset: > ./test/py/test.py --bd sandbox_flattree --build -s -k ut_dm > or even this particular test: > ./test/py/test.py --bd sandbox_flattree --build -s -k ut_dm_tee > > Each time it fails in the same place on trying to allocate a hashtree > (using hash tree funcs from /lib/hashtable.c) with 20 elements when > probing tee device, and seems that > it just a consequence of that fact, that some functionality, which > tested before tee, is not doing a proper cleanup (when full testing is > done). > > Anyway, I can decrease the number of elements for the hashtree, but it > definitely won't fix the root cause. Can you please look into the root cause? It sounds like you're a fair part of the way along on that now, thanks! > > Regards, > Igor > > On Sat, 9 Feb 2019 at 14:50, Tom Rini wrote: > > > > On Sun, Jan 27, 2019 at 04:34:05PM +0200, Igor Opaniuk wrote: > > > > > AVB version 1.1 introduces support for named persistent values > > > that must be tamper evident and allows AVB to store arbitrary key-value > > > pairs [1]. > > > > > > Introduce implementation of two additional AVB operations > > > read_persistent_value()/write_persistent_value() for retrieving/storing > > > named persistent values. > > > > > > Correspondent pull request in the OP-TEE OS project repo [2]. > > > > > > [1]: https://android.googlesource.com/platform/external/avb/+/android-9.0.0_r22 > > > [2]: https://github.com/OP-TEE/optee_os/pull/2699 > > > > > > Signed-off-by: Igor Opaniuk > > > Reviewed-by: Simon Glass > > > > The test fails on some sandbox targets: > > https://travis-ci.org/trini/u-boot/jobs/490809872 > > > > -- > > Tom > > > > -- > Regards, > Igor Opaniuk -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: