From: Sean Paul Subject: Re: [PATCH v2] drm: Merge __drm_atomic_helper_disable_all() into drm_atomic_helper_disable_all() Date: Wed, 13 Feb 2019 11:28:14 -0500 Message-ID: <20190213162814.GM114153@art_vandelay> References: <20190212170816.GJ114153@art_vandelay> <20190212173245.51980-1-sean@poorly.run> <20190213153505.GG20097@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by gabe.freedesktop.org (Postfix) with ESMTPS id 410986E3A5 for ; Wed, 13 Feb 2019 16:28:18 +0000 (UTC) Received: by mail-qt1-x841.google.com with SMTP id n32so3201016qte.11 for ; Wed, 13 Feb 2019 08:28:18 -0800 (PST) Content-Disposition: inline In-Reply-To: <20190213153505.GG20097@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Sinclair Yeh , Maxime Ripard , dri-devel@lists.freedesktop.org, David Airlie , Sean Paul , Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBGZWIgMTMsIDIwMTkgYXQgMDU6MzU6MDVQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFR1ZSwgRmViIDEyLCAyMDE5IGF0IDEyOjMyOjQxUE0gLTA1MDAsIFNlYW4g UGF1bCB3cm90ZToKPiA+IEZyb206IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+ ID4gCj4gPiBUaGUgb25seSBkaWZmZXJlbmNlIGJldHdlZW4gdGhlIGZ1bmN0aW9ucyBpcyB0aGUg Y2xlYW5fb2xkX2ZicyBhcmd1bWVudCwgd2hvc2UKPiA+IHVzZSB3YXMgcmVtb3ZlZCBpbiB0aGUg cGF0Y2ggcmVmZXJlbmNlZCBiZWxvdy4gU28gcmVtb3ZlIHRoZSBpbnRlcm5hbAo+ID4gY29weSBh bmQgZHJvcCB0aGUgZ3V0cyBiYWNrIGludG8gZHJtX2F0b21pY19oZWxwZXJfZGlzYWJsZV9hbGwo KQo+ID4gCj4gPiBDaGFuZ2VzIGluIHYyOgo+ID4gLSBJbnN0ZWFkIG9mIGp1c3QgcmVtb3Zpbmcg dGhlIHVudXNlZCBhcmcsIG1lcmdlIHRoZSBmdW5jdGlvbnMKPiA+IAo+ID4gRml4ZXM6IGUwMGZi ODU2NGVlOSAoImRybTogU3RvcCB1cGRhdGluZyBwbGFuZS0+Y3J0Yy9mYi9vbGRfZmIgb24gYXRv bWljIGRyaXZlcnMiKQo+ID4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20+Cj4gPiBDYzogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0 QGxpbnV4LmludGVsLmNvbT4KPiA+IENjOiBIYXJyeSBXZW50bGFuZCA8aGFycnkud2VudGxhbmRA YW1kLmNvbT4KPiA+IENjOiBTaW5jbGFpciBZZWggPHN5ZWhAdm13YXJlLmNvbT4gIyBUaGlzIGVt YWlsIGJvdW5jZXMgOigKPiA+IENjOiBNYXhpbWUgUmlwYXJkIDxtYXhpbWUucmlwYXJkQGJvb3Rs aW4uY29tPgo+ID4gQ2M6IFNlYW4gUGF1bCA8c2VhbkBwb29ybHkucnVuPgo+ID4gQ2M6IERhdmlk IEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4KPiA+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxA ZmZ3bGwuY2g+Cj4gPiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gU2ln bmVkLW9mZi1ieTogU2VhbiBQYXVsIDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+Cj4gCj4gUmV2aWV3 ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4g CgpQdXNoZWQgdG8gZHJtLW1pc2MtbmV4dC1maXhlcywgdGhhbmtzIGZvciB5b3VyIHJldmlldyEK ClNlYW4KCj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyB8 IDU5ICsrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDI2 IGluc2VydGlvbnMoKyksIDMzIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0 b21pY19oZWxwZXIuYwo+ID4gaW5kZXggYzUzZWNiZDlhYmRkZC4uN2E3MjMxZDAwNzc5MiAxMDA2 NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ID4gQEAgLTMwMzAsOSArMzAz MCwzMSBAQCBpbnQgX19kcm1fYXRvbWljX2hlbHBlcl9zZXRfY29uZmlnKHN0cnVjdCBkcm1fbW9k ZV9zZXQgKnNldCwKPiA+ICAJcmV0dXJuIDA7Cj4gPiAgfQo+ID4gIAo+ID4gLXN0YXRpYyBpbnQg X19kcm1fYXRvbWljX2hlbHBlcl9kaXNhYmxlX2FsbChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ ID4gLQkJCQkJICAgc3RydWN0IGRybV9tb2Rlc2V0X2FjcXVpcmVfY3R4ICpjdHgsCj4gPiAtCQkJ CQkgICBib29sIGNsZWFuX29sZF9mYnMpCj4gPiArLyoqCj4gPiArICogZHJtX2F0b21pY19oZWxw ZXJfZGlzYWJsZV9hbGwgLSBkaXNhYmxlIGFsbCBjdXJyZW50bHkgYWN0aXZlIG91dHB1dHMKPiA+ ICsgKiBAZGV2OiBEUk0gZGV2aWNlCj4gPiArICogQGN0eDogbG9jayBhY3F1aXNpdGlvbiBjb250 ZXh0Cj4gPiArICoKPiA+ICsgKiBMb29wcyB0aHJvdWdoIGFsbCBjb25uZWN0b3JzLCBmaW5kaW5n IHRob3NlIHRoYXQgYXJlbid0IHR1cm5lZCBvZmYgYW5kIHRoZW4KPiA+ICsgKiB0dXJucyB0aGVt IG9mZiBieSBzZXR0aW5nIHRoZWlyIERQTVMgbW9kZSB0byBPRkYgYW5kIGRlYWN0aXZhdGluZyB0 aGUgQ1JUQwo+ID4gKyAqIHRoYXQgdGhleSBhcmUgY29ubmVjdGVkIHRvLgo+ID4gKyAqCj4gPiAr ICogVGhpcyBpcyB1c2VkIGZvciBleGFtcGxlIGluIHN1c3BlbmQvcmVzdW1lIHRvIGRpc2FibGUg YWxsIGN1cnJlbnRseSBhY3RpdmUKPiA+ICsgKiBmdW5jdGlvbnMgd2hlbiBzdXNwZW5kaW5nLiBJ ZiB5b3UganVzdCB3YW50IHRvIHNodXQgZG93biBldmVyeXRoaW5nIGF0IGUuZy4KPiA+ICsgKiBk cml2ZXIgdW5sb2FkLCBsb29rIGF0IGRybV9hdG9taWNfaGVscGVyX3NodXRkb3duKCkuCj4gPiAr ICoKPiA+ICsgKiBOb3RlIHRoYXQgaWYgY2FsbGVycyBoYXZlbid0IGFscmVhZHkgYWNxdWlyZWQg YWxsIG1vZGVzZXQgbG9ja3MgdGhpcyBtaWdodAo+ID4gKyAqIHJldHVybiAtRURFQURMSywgd2hp Y2ggbXVzdCBiZSBoYW5kbGVkIGJ5IGNhbGxpbmcgZHJtX21vZGVzZXRfYmFja29mZigpLgo+ID4g KyAqCj4gPiArICogUmV0dXJuczoKPiA+ICsgKiAwIG9uIHN1Y2Nlc3Mgb3IgYSBuZWdhdGl2ZSBl cnJvciBjb2RlIG9uIGZhaWx1cmUuCj4gPiArICoKPiA+ICsgKiBTZWUgYWxzbzoKPiA+ICsgKiBk cm1fYXRvbWljX2hlbHBlcl9zdXNwZW5kKCksIGRybV9hdG9taWNfaGVscGVyX3Jlc3VtZSgpIGFu ZAo+ID4gKyAqIGRybV9hdG9taWNfaGVscGVyX3NodXRkb3duKCkuCj4gPiArICovCj4gPiAraW50 IGRybV9hdG9taWNfaGVscGVyX2Rpc2FibGVfYWxsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4g PiArCQkJCSAgc3RydWN0IGRybV9tb2Rlc2V0X2FjcXVpcmVfY3R4ICpjdHgpCj4gPiAgewo+ID4g IAlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGU7Cj4gPiAgCXN0cnVjdCBkcm1fY29ubmVj dG9yX3N0YXRlICpjb25uX3N0YXRlOwo+ID4gQEAgLTMwOTAsMzUgKzMxMTIsNiBAQCBzdGF0aWMg aW50IF9fZHJtX2F0b21pY19oZWxwZXJfZGlzYWJsZV9hbGwoc3RydWN0IGRybV9kZXZpY2UgKmRl diwKPiA+ICAJZHJtX2F0b21pY19zdGF0ZV9wdXQoc3RhdGUpOwo+ID4gIAlyZXR1cm4gcmV0Owo+ ID4gIH0KPiA+IC0KPiA+IC0vKioKPiA+IC0gKiBkcm1fYXRvbWljX2hlbHBlcl9kaXNhYmxlX2Fs bCAtIGRpc2FibGUgYWxsIGN1cnJlbnRseSBhY3RpdmUgb3V0cHV0cwo+ID4gLSAqIEBkZXY6IERS TSBkZXZpY2UKPiA+IC0gKiBAY3R4OiBsb2NrIGFjcXVpc2l0aW9uIGNvbnRleHQKPiA+IC0gKgo+ ID4gLSAqIExvb3BzIHRocm91Z2ggYWxsIGNvbm5lY3RvcnMsIGZpbmRpbmcgdGhvc2UgdGhhdCBh cmVuJ3QgdHVybmVkIG9mZiBhbmQgdGhlbgo+ID4gLSAqIHR1cm5zIHRoZW0gb2ZmIGJ5IHNldHRp bmcgdGhlaXIgRFBNUyBtb2RlIHRvIE9GRiBhbmQgZGVhY3RpdmF0aW5nIHRoZSBDUlRDCj4gPiAt ICogdGhhdCB0aGV5IGFyZSBjb25uZWN0ZWQgdG8uCj4gPiAtICoKPiA+IC0gKiBUaGlzIGlzIHVz ZWQgZm9yIGV4YW1wbGUgaW4gc3VzcGVuZC9yZXN1bWUgdG8gZGlzYWJsZSBhbGwgY3VycmVudGx5 IGFjdGl2ZQo+ID4gLSAqIGZ1bmN0aW9ucyB3aGVuIHN1c3BlbmRpbmcuIElmIHlvdSBqdXN0IHdh bnQgdG8gc2h1dCBkb3duIGV2ZXJ5dGhpbmcgYXQgZS5nLgo+ID4gLSAqIGRyaXZlciB1bmxvYWQs IGxvb2sgYXQgZHJtX2F0b21pY19oZWxwZXJfc2h1dGRvd24oKS4KPiA+IC0gKgo+ID4gLSAqIE5v dGUgdGhhdCBpZiBjYWxsZXJzIGhhdmVuJ3QgYWxyZWFkeSBhY3F1aXJlZCBhbGwgbW9kZXNldCBs b2NrcyB0aGlzIG1pZ2h0Cj4gPiAtICogcmV0dXJuIC1FREVBRExLLCB3aGljaCBtdXN0IGJlIGhh bmRsZWQgYnkgY2FsbGluZyBkcm1fbW9kZXNldF9iYWNrb2ZmKCkuCj4gPiAtICoKPiA+IC0gKiBS ZXR1cm5zOgo+ID4gLSAqIDAgb24gc3VjY2VzcyBvciBhIG5lZ2F0aXZlIGVycm9yIGNvZGUgb24g ZmFpbHVyZS4KPiA+IC0gKgo+ID4gLSAqIFNlZSBhbHNvOgo+ID4gLSAqIGRybV9hdG9taWNfaGVs cGVyX3N1c3BlbmQoKSwgZHJtX2F0b21pY19oZWxwZXJfcmVzdW1lKCkgYW5kCj4gPiAtICogZHJt X2F0b21pY19oZWxwZXJfc2h1dGRvd24oKS4KPiA+IC0gKi8KPiA+IC1pbnQgZHJtX2F0b21pY19o ZWxwZXJfZGlzYWJsZV9hbGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+IC0JCQkJICBzdHJ1 Y3QgZHJtX21vZGVzZXRfYWNxdWlyZV9jdHggKmN0eCkKPiA+IC17Cj4gPiAtCXJldHVybiBfX2Ry bV9hdG9taWNfaGVscGVyX2Rpc2FibGVfYWxsKGRldiwgY3R4LCBmYWxzZSk7Cj4gPiAtfQo+ID4g IEVYUE9SVF9TWU1CT0woZHJtX2F0b21pY19oZWxwZXJfZGlzYWJsZV9hbGwpOwo+ID4gIAo+ID4g IC8qKgo+ID4gQEAgLTMxMzksNyArMzEzMiw3IEBAIHZvaWQgZHJtX2F0b21pY19oZWxwZXJfc2h1 dGRvd24oc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+ICAKPiA+ICAJRFJNX01PREVTRVRfTE9D S19BTExfQkVHSU4oZGV2LCBjdHgsIDAsIHJldCk7Cj4gPiAgCj4gPiAtCXJldCA9IF9fZHJtX2F0 b21pY19oZWxwZXJfZGlzYWJsZV9hbGwoZGV2LCAmY3R4LCB0cnVlKTsKPiA+ICsJcmV0ID0gZHJt X2F0b21pY19oZWxwZXJfZGlzYWJsZV9hbGwoZGV2LCAmY3R4KTsKPiA+ICAJaWYgKHJldCkKPiA+ ICAJCURSTV9FUlJPUigiRGlzYWJsaW5nIGFsbCBjcnRjJ3MgZHVyaW5nIHVubG9hZCBmYWlsZWQg d2l0aCAlaVxuIiwgcmV0KTsKPiA+ICAKPiA+IC0tIAo+ID4gU2VhbiBQYXVsLCBTb2Z0d2FyZSBF bmdpbmVlciwgR29vZ2xlIC8gQ2hyb21pdW0gT1MKPiAKPiAtLSAKPiBWaWxsZSBTeXJqw6Rsw6QK PiBJbnRlbAoKLS0gClNlYW4gUGF1bCwgU29mdHdhcmUgRW5naW5lZXIsIEdvb2dsZSAvIENocm9t aXVtIE9TCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==