From: Paul Durrant Subject: [PATCH v2] viridian: fix the HvFlushVirtualAddress/List hypercall implementation Date: Thu, 14 Feb 2019 12:10:04 +0000 Message-ID: <20190214121004.2193-1-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1guFqF-0006Si-Oz for xen-devel@lists.xenproject.org; Thu, 14 Feb 2019 12:10:11 +0000 List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Paul Durrant , Wei Liu , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= List-Id: xen-devel@lists.xenproject.org VGhlIGN1cnJlbnQgY29kZSB1c2VzIGh2bV9hc2lkX2ZsdXNoX3ZjcHUoKSBidXQgdGhpcyBpcyBp bnN1ZmZpY2llbnQgZm9yCmEgZ3Vlc3QgcnVubmluZyBpbiBzaGFkb3cgbW9kZSwgd2hpY2ggcmVz dWx0cyBpbiBndWVzdCBjcmFzaGVzIGVhcmx5IGluCmJvb3QgaWYgdGhlICdoY2FsbF9yZW1vdGVf dGxiX2ZsdXNoJyBpcyBlbmFibGVkLgoKVGhpcyBwYXRjaCwgaW5zdGVhZCBvZiBvcGVuIGNvZGlu ZyBhIG5ldyBmbHVzaCBhbGdvcml0aG0sIGFkYXB0cyB0aGUgb25lCmFscmVhZHkgdXNlZCBieSB0 aGUgSFZNT1BfZmx1c2hfdGxicyBYZW4gaHlwZXJjYWxsLiBUaGUgaW1wbGVtZW50YXRpb24gaXMK bW9kaWZpZWQgdG8gYWxsb3cgVExCIGZsdXNoaW5nIGEgc3Vic2V0IG9mIGEgZG9tYWluJ3MgdkNQ VXMuIEEgY2FsbGJhY2sKZnVuY3Rpb24gZGV0ZXJtaW5lcyB3aGV0aGVyIG9yIG5vdCBhIHZDUFUg cmVxdWlyZXMgZmx1c2hpbmcuIFRoaXMgbWVjaGFuaXNtCndhcyBjaG9zZW4gYmVjYXVzZSwgd2hp bGUgaXQgaXMgdGhlIGNhc2UgdGhhdCB0aGUgY3VycmVudGx5IGltcGxlbWVudGVkCnZpcmlkaWFu IGh5cGVyY2FsbHMgc3BlY2lmeSBhIHZDUFUgbWFzaywgdGhlcmUgYXJlIG5ld2VyIHZhcmlhbnRz IHdoaWNoCnNwZWNpZnkgYSBzcGFyc2UgSFZfVlBfU0VUIGFuZCB0aHVzIHVzZSBvZiBhIGNhbGxi YWNrIHdpbGwgYXZvaWQgbmVlZGluZyB0bwpleHBvc2UgZGV0YWlscyBvZiB0aGlzIG91dHNpZGUg b2YgdGhlIHZpcmlkaWFuIHN1YnN5c3RlbSBpZiBhbmQgd2hlbiB0aG9zZQpuZXdlciB2YXJpYW50 cyBhcmUgaW1wbGVtZW50ZWQuCgpOT1RFOiBVc2Ugb2YgdGhlIGNvbW1vbiBmbHVzaCBmdW5jdGlv biByZXF1aXJlcyB0aGF0IHRoZSBoeXBlcmNhbGxzIGFyZQogICAgICByZXN0YXJ0YWJsZSBhbmQg c28sIHdpdGggdGhpcyBwYXRjaCBhcHBsaWVkLCB2aXJpZGlhbl9oeXBlcmNhbGwoKQogICAgICBj YW4gbm93IHJldHVybiBIVk1fSENBTExfcHJlZW1wdGVkLiBUaGlzIGlzIHNhZmUgYXMgbm8gbW9k aWZpY2F0aW9uCiAgICAgIHRvIHN0cnVjdCBjcHVfdXNlcl9yZWdzIGlzIGRvbmUgYmVmb3JlIHRo ZSByZXR1cm4uCgpTaWduZWQtb2ZmLWJ5OiBQYXVsIER1cnJhbnQgPHBhdWwuZHVycmFudEBjaXRy aXguY29tPgotLS0KQ2M6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KQ2M6IEFuZHJl dyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+CkNjOiBXZWkgTGl1IDx3ZWkubGl1 MkBjaXRyaXguY29tPgpDYzogIlJvZ2VyIFBhdSBNb25uw6kiIDxyb2dlci5wYXVAY2l0cml4LmNv bT4KCnYyOgogLSBVc2UgY3B1bWFza19zY3JhdGNoCiAtIE1ha2Ugc3VyZSBsb2NhbCBDUFUgZmx1 c2ggaXNuJ3QgbWlzc2VkCi0tLQogeGVuL2FyY2gveDg2L2h2bS9odm0uYyAgICAgICAgICAgICAg IHwgNDggKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLQogeGVuL2FyY2gveDg2L2h2bS92aXJp ZGlhbi92aXJpZGlhbi5jIHwgNDUgKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0KIHhlbi9pbmNs dWRlL2FzbS14ODYvaHZtL2h2bS5oICAgICAgICB8ICAyICsrCiAzIGZpbGVzIGNoYW5nZWQsIDUz IGluc2VydGlvbnMoKyksIDQyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4 Ni9odm0vaHZtLmMgYi94ZW4vYXJjaC94ODYvaHZtL2h2bS5jCmluZGV4IDQxMDYyM2Q0MzcuLjRh YjQ0MDkyNDIgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vaHZtLmMKKysrIGIveGVuL2Fy Y2gveDg2L2h2bS9odm0uYwpAQCAtMzgsNiArMzgsNyBAQAogI2luY2x1ZGUgPHhlbi93YXJuaW5n Lmg+CiAjaW5jbHVkZSA8eGVuL3ZwY2kuaD4KICNpbmNsdWRlIDx4ZW4vbm9zcGVjLmg+CisjaW5j bHVkZSA8eGVuL3NjaGVkLWlmLmg+CiAjaW5jbHVkZSA8YXNtL3NoYWRvdy5oPgogI2luY2x1ZGUg PGFzbS9oYXAuaD4KICNpbmNsdWRlIDxhc20vY3VycmVudC5oPgpAQCAtMzk2NCwyNiArMzk2NSwy NyBAQCBzdGF0aWMgdm9pZCBodm1fczNfcmVzdW1lKHN0cnVjdCBkb21haW4gKmQpCiAgICAgfQog fQogCi1zdGF0aWMgaW50IGh2bW9wX2ZsdXNoX3RsYl9hbGwodm9pZCkKK2Jvb2wgaHZtX2ZsdXNo X3ZjcHVfdGxiKGJvb2wgKCpmbHVzaF92Y3B1KSh2b2lkICpjdHh0LCBzdHJ1Y3QgdmNwdSAqdiks CisgICAgICAgICAgICAgICAgICAgICAgICB2b2lkICpjdHh0KQogeworICAgIGNwdW1hc2tfdCAq bWFzayA9IGNwdW1hc2tfc2NyYXRjaDsKICAgICBzdHJ1Y3QgZG9tYWluICpkID0gY3VycmVudC0+ ZG9tYWluOwogICAgIHN0cnVjdCB2Y3B1ICp2OwogCi0gICAgaWYgKCAhaXNfaHZtX2RvbWFpbihk KSApCi0gICAgICAgIHJldHVybiAtRUlOVkFMOwotCiAgICAgLyogQXZvaWQgZGVhZGxvY2sgaWYg bW9yZSB0aGFuIG9uZSB2Y3B1IHRyaWVzIHRoaXMgYXQgdGhlIHNhbWUgdGltZS4gKi8KICAgICBp ZiAoICFzcGluX3RyeWxvY2soJmQtPmh5cGVyY2FsbF9kZWFkbG9ja19tdXRleCkgKQotICAgICAg ICByZXR1cm4gLUVSRVNUQVJUOworICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICAvKiBQYXVz ZSBhbGwgb3RoZXIgdmNwdXMuICovCiAgICAgZm9yX2VhY2hfdmNwdSAoIGQsIHYgKQotICAgICAg ICBpZiAoIHYgIT0gY3VycmVudCApCisgICAgICAgIGlmICggdiAhPSBjdXJyZW50ICYmIGZsdXNo X3ZjcHUoY3R4dCwgdikgKQogICAgICAgICAgICAgdmNwdV9wYXVzZV9ub3N5bmModik7CiAKKyAg ICBjcHVtYXNrX2NsZWFyKG1hc2spOworCiAgICAgLyogTm93IHRoYXQgYWxsIFZDUFVzIGFyZSBz aWduYWxsZWQgdG8gZGVzY2hlZHVsZSwgd2Ugd2FpdC4uLiAqLwogICAgIGZvcl9lYWNoX3ZjcHUg KCBkLCB2ICkKLSAgICAgICAgaWYgKCB2ICE9IGN1cnJlbnQgKQorICAgICAgICBpZiAoIHYgIT0g Y3VycmVudCAmJiBmbHVzaF92Y3B1KGN0eHQsIHYpICkKICAgICAgICAgICAgIHdoaWxlICggIXZj cHVfcnVubmFibGUodikgJiYgdi0+aXNfcnVubmluZyApCiAgICAgICAgICAgICAgICAgY3B1X3Jl bGF4KCk7CiAKQEAgLTM5OTIsMTcgKzM5OTQsNDEgQEAgc3RhdGljIGludCBodm1vcF9mbHVzaF90 bGJfYWxsKHZvaWQpCiAKICAgICAvKiBGbHVzaCBwYWdpbmctbW9kZSBzb2Z0IHN0YXRlIChlLmcu LCB2YS0+Z2ZuIGNhY2hlOyBQQUUgUERQRSBjYWNoZSkuICovCiAgICAgZm9yX2VhY2hfdmNwdSAo IGQsIHYgKQorICAgIHsKKyAgICAgICAgdW5zaWduZWQgaW50IGNwdTsKKworICAgICAgICBpZiAo ICFmbHVzaF92Y3B1KGN0eHQsIHYpICkKKyAgICAgICAgICAgIGNvbnRpbnVlOworCiAgICAgICAg IHBhZ2luZ191cGRhdGVfY3IzKHYsIGZhbHNlKTsKIAotICAgIC8qIEZsdXNoIGFsbCBkaXJ0eSBU TEJzLiAqLwotICAgIGZsdXNoX3RsYl9tYXNrKGQtPmRpcnR5X2NwdW1hc2spOworICAgICAgICBj cHUgPSByZWFkX2F0b21pYygmdi0+ZGlydHlfY3B1KTsKKyAgICAgICAgaWYgKCBpc192Y3B1X2Rp cnR5X2NwdShjcHUpICkKKyAgICAgICAgICAgIF9fY3B1bWFza19zZXRfY3B1KGNwdSwgbWFzayk7 CisgICAgfQorCisgICAgLyogRmx1c2ggVExCcyBvbiBhbGwgQ1BVcyB3aXRoIGRpcnR5IHZjcHUg c3RhdGUuICovCisgICAgZmx1c2hfdGxiX21hc2sobWFzayk7CiAKICAgICAvKiBEb25lLiAqLwog ICAgIGZvcl9lYWNoX3ZjcHUgKCBkLCB2ICkKLSAgICAgICAgaWYgKCB2ICE9IGN1cnJlbnQgKQor ICAgICAgICBpZiAoIHYgIT0gY3VycmVudCAmJiBmbHVzaF92Y3B1KGN0eHQsIHYpICkKICAgICAg ICAgICAgIHZjcHVfdW5wYXVzZSh2KTsKIAotICAgIHJldHVybiAwOworICAgIHJldHVybiB0cnVl OworfQorCitzdGF0aWMgYm9vbCBhbHdheXNfZmx1c2godm9pZCAqY3R4dCwgc3RydWN0IHZjcHUg KnYpCit7CisgICAgcmV0dXJuIHRydWU7Cit9CisKK3N0YXRpYyBpbnQgaHZtb3BfZmx1c2hfdGxi X2FsbCh2b2lkKQoreworICAgIGlmICggIWlzX2h2bV9kb21haW4oY3VycmVudC0+ZG9tYWluKSAp CisgICAgICAgIHJldHVybiAtRUlOVkFMOworCisgICAgcmV0dXJuIGh2bV9mbHVzaF92Y3B1X3Rs YihhbHdheXNfZmx1c2gsIE5VTEwpID8gMCA6IC1FUkVTVEFSVDsKIH0KIAogc3RhdGljIGludCBo dm1vcF9zZXRfZXZ0Y2huX3VwY2FsbF92ZWN0b3IoCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYv aHZtL3ZpcmlkaWFuL3ZpcmlkaWFuLmMgYi94ZW4vYXJjaC94ODYvaHZtL3ZpcmlkaWFuL3Zpcmlk aWFuLmMKaW5kZXggYzc4YjI5MThkOS4uNDI1YWY1Njg1NiAxMDA2NDQKLS0tIGEveGVuL2FyY2gv eDg2L2h2bS92aXJpZGlhbi92aXJpZGlhbi5jCisrKyBiL3hlbi9hcmNoL3g4Ni9odm0vdmlyaWRp YW4vdmlyaWRpYW4uYwpAQCAtNDMwLDcgKzQzMCwxNiBAQCB2b2lkIHZpcmlkaWFuX2RvbWFpbl9k ZWluaXQoc3RydWN0IGRvbWFpbiAqZCkKICAgICAgICAgdmlyaWRpYW5fdmNwdV9kZWluaXQodik7 CiB9CiAKLXN0YXRpYyBERUZJTkVfUEVSX0NQVShjcHVtYXNrX3QsIGlwaV9jcHVtYXNrKTsKKy8q CisgKiBXaW5kb3dzIHNob3VsZCBub3QgaXNzdWUgdGhlIGh5cGVyY2FsbHMgcmVxdWlyaW5nIHRo aXMgY2FsbGJhY2sgaW4gdGhlCisgKiBjYXNlIHdoZXJlIHZjcHVfaWQgd291bGQgZXhjZWVkIHRo ZSBzaXplIG9mIHRoZSBtYXNrLgorICovCitzdGF0aWMgYm9vbCBuZWVkX2ZsdXNoKHZvaWQgKmN0 eHQsIHN0cnVjdCB2Y3B1ICp2KQoreworICAgIHVpbnQ2NF90IHZjcHVfbWFzayA9ICoodWludDY0 X3QgKiljdHh0OworCisgICAgcmV0dXJuIHZjcHVfbWFzayAmICgxdWwgPDwgdi0+dmNwdV9pZCk7 Cit9CiAKIGludCB2aXJpZGlhbl9oeXBlcmNhbGwoc3RydWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3Mp CiB7CkBAIC00OTQsOCArNTAzLDYgQEAgaW50IHZpcmlkaWFuX2h5cGVyY2FsbChzdHJ1Y3QgY3B1 X3VzZXJfcmVncyAqcmVncykKICAgICBjYXNlIEh2Rmx1c2hWaXJ0dWFsQWRkcmVzc1NwYWNlOgog ICAgIGNhc2UgSHZGbHVzaFZpcnR1YWxBZGRyZXNzTGlzdDoKICAgICB7Ci0gICAgICAgIGNwdW1h c2tfdCAqcGNwdV9tYXNrOwotICAgICAgICBzdHJ1Y3QgdmNwdSAqdjsKICAgICAgICAgc3RydWN0 IHsKICAgICAgICAgICAgIHVpbnQ2NF90IGFkZHJlc3Nfc3BhY2U7CiAgICAgICAgICAgICB1aW50 NjRfdCBmbGFnczsKQEAgLTUyMSwzNiArNTI4LDEyIEBAIGludCB2aXJpZGlhbl9oeXBlcmNhbGwo c3RydWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3MpCiAgICAgICAgIGlmICggaW5wdXRfcGFyYW1zLmZs YWdzICYgSFZfRkxVU0hfQUxMX1BST0NFU1NPUlMgKQogICAgICAgICAgICAgaW5wdXRfcGFyYW1z LnZjcHVfbWFzayA9IH4wdWw7CiAKLSAgICAgICAgcGNwdV9tYXNrID0gJnRoaXNfY3B1KGlwaV9j cHVtYXNrKTsKLSAgICAgICAgY3B1bWFza19jbGVhcihwY3B1X21hc2spOwotCi0gICAgICAgIC8q Ci0gICAgICAgICAqIEZvciBlYWNoIHNwZWNpZmllZCB2aXJ0dWFsIENQVSBmbHVzaCBhbGwgQVNJ RHMgdG8gaW52YWxpZGF0ZQotICAgICAgICAgKiBUTEIgZW50cmllcyB0aGUgbmV4dCB0aW1lIGl0 IGlzIHNjaGVkdWxlZCBhbmQgdGhlbiwgaWYgaXQKLSAgICAgICAgICogaXMgY3VycmVudGx5IHJ1 bm5pbmcsIGFkZCBpdHMgcGh5c2ljYWwgQ1BVIHRvIGEgbWFzayBvZgotICAgICAgICAgKiB0aG9z ZSB3aGljaCBuZWVkIHRvIGJlIGludGVycnVwdGVkIHRvIGZvcmNlIGEgZmx1c2guCi0gICAgICAg ICAqLwotICAgICAgICBmb3JfZWFjaF92Y3B1ICggY3VycmQsIHYgKQotICAgICAgICB7Ci0gICAg ICAgICAgICBpZiAoIHYtPnZjcHVfaWQgPj0gKHNpemVvZihpbnB1dF9wYXJhbXMudmNwdV9tYXNr KSAqIDgpICkKLSAgICAgICAgICAgICAgICBicmVhazsKLQotICAgICAgICAgICAgaWYgKCAhKGlu cHV0X3BhcmFtcy52Y3B1X21hc2sgJiAoMXVsIDw8IHYtPnZjcHVfaWQpKSApCi0gICAgICAgICAg ICAgICAgY29udGludWU7Ci0KLSAgICAgICAgICAgIGh2bV9hc2lkX2ZsdXNoX3ZjcHUodik7Ci0g ICAgICAgICAgICBpZiAoIHYgIT0gY3VyciAmJiB2LT5pc19ydW5uaW5nICkKLSAgICAgICAgICAg ICAgICBfX2NwdW1hc2tfc2V0X2NwdSh2LT5wcm9jZXNzb3IsIHBjcHVfbWFzayk7Ci0gICAgICAg IH0KLQogICAgICAgICAvKgotICAgICAgICAgKiBTaW5jZSBBU0lEcyBoYXZlIG5vdyBiZWVuIGZs dXNoZWQgaXQganVzdCByZW1haW5zIHRvCi0gICAgICAgICAqIGZvcmNlIGFueSBDUFVzIGN1cnJl bnRseSBydW5uaW5nIHRhcmdldCB2Q1BVcyBvdXQgb2Ygbm9uLQotICAgICAgICAgKiByb290IG1v ZGUuIEl0J3MgcG9zc2libGUgdGhhdCByZS1zY2hlZHVsaW5nIGhhcyB0YWtlbiBwbGFjZQotICAg ICAgICAgKiBzbyB3ZSBtYXkgdW5uZWNlc3NhcmlseSBJUEkgc29tZSBDUFVzLgorICAgICAgICAg KiBBIGZhbHNlIHJldHVybiBtZWFucyB0aGF0IGFub3RoZXIgdmNwdSBpcyBjdXJyZW50bHkgdHJ5 aW5nCisgICAgICAgICAqIGEgc2ltaWxhciBvcGVyYXRpb24sIHNvIGJhY2sgb2ZmLgogICAgICAg ICAgKi8KLSAgICAgICAgaWYgKCAhY3B1bWFza19lbXB0eShwY3B1X21hc2spICkKLSAgICAgICAg ICAgIHNtcF9zZW5kX2V2ZW50X2NoZWNrX21hc2socGNwdV9tYXNrKTsKKyAgICAgICAgaWYgKCAh aHZtX2ZsdXNoX3ZjcHVfdGxiKG5lZWRfZmx1c2gsICZpbnB1dF9wYXJhbXMudmNwdV9tYXNrKSAp CisgICAgICAgICAgICByZXR1cm4gSFZNX0hDQUxMX3ByZWVtcHRlZDsKIAogICAgICAgICBvdXRw dXQucmVwX2NvbXBsZXRlID0gaW5wdXQucmVwX2NvdW50OwogCmRpZmYgLS1naXQgYS94ZW4vaW5j bHVkZS9hc20teDg2L2h2bS9odm0uaCBiL3hlbi9pbmNsdWRlL2FzbS14ODYvaHZtL2h2bS5oCmlu ZGV4IDBhMTBiNTE1NTQuLjUzZmZlYmIyYzUgMTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14 ODYvaHZtL2h2bS5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvaHZtL2h2bS5oCkBAIC0zMzgs NiArMzM4LDggQEAgY29uc3QgY2hhciAqaHZtX2VmZXJfdmFsaWQoY29uc3Qgc3RydWN0IHZjcHUg KnYsIHVpbnQ2NF90IHZhbHVlLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgc2lnbmVkIGlu dCBjcjBfcGcpOwogdW5zaWduZWQgbG9uZyBodm1fY3I0X2d1ZXN0X3ZhbGlkX2JpdHMoY29uc3Qg c3RydWN0IGRvbWFpbiAqZCwgYm9vbCByZXN0b3JlKTsKIAorYm9vbCBodm1fZmx1c2hfdmNwdV90 bGIoYm9vbCAoKmZsdXNoX3ZjcHUpKHZvaWQgKmN0eHQsIHN0cnVjdCB2Y3B1ICp2KSwKKyAgICAg ICAgICAgICAgICAgICAgICAgIHZvaWQgKmN0eHQpOwogCiAjaWZkZWYgQ09ORklHX0hWTQogCi0t IAoyLjIwLjEuMi5nYjIxZWJiNjcxCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVu cHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZv L3hlbi1kZXZlbA==