From: Paul Durrant Subject: [PATCH v3] viridian: fix the HvFlushVirtualAddress/List hypercall implementation Date: Thu, 14 Feb 2019 12:49:07 +0000 Message-ID: <20190214124907.12011-1-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1guGS7-0001MX-08 for xen-devel@lists.xenproject.org; Thu, 14 Feb 2019 12:49:19 +0000 List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Paul Durrant , Wei Liu , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= List-Id: xen-devel@lists.xenproject.org VGhlIGN1cnJlbnQgY29kZSB1c2VzIGh2bV9hc2lkX2ZsdXNoX3ZjcHUoKSBidXQgdGhpcyBpcyBp bnN1ZmZpY2llbnQgZm9yCmEgZ3Vlc3QgcnVubmluZyBpbiBzaGFkb3cgbW9kZSwgd2hpY2ggcmVz dWx0cyBpbiBndWVzdCBjcmFzaGVzIGVhcmx5IGluCmJvb3QgaWYgdGhlICdoY2FsbF9yZW1vdGVf dGxiX2ZsdXNoJyBpcyBlbmFibGVkLgoKVGhpcyBwYXRjaCwgaW5zdGVhZCBvZiBvcGVuIGNvZGlu ZyBhIG5ldyBmbHVzaCBhbGdvcml0aG0sIGFkYXB0cyB0aGUgb25lCmFscmVhZHkgdXNlZCBieSB0 aGUgSFZNT1BfZmx1c2hfdGxicyBYZW4gaHlwZXJjYWxsLiBUaGUgaW1wbGVtZW50YXRpb24gaXMK bW9kaWZpZWQgdG8gYWxsb3cgVExCIGZsdXNoaW5nIGEgc3Vic2V0IG9mIGEgZG9tYWluJ3MgdkNQ VXMuIEEgY2FsbGJhY2sKZnVuY3Rpb24gZGV0ZXJtaW5lcyB3aGV0aGVyIG9yIG5vdCBhIHZDUFUg cmVxdWlyZXMgZmx1c2hpbmcuIFRoaXMgbWVjaGFuaXNtCndhcyBjaG9zZW4gYmVjYXVzZSwgd2hp bGUgaXQgaXMgdGhlIGNhc2UgdGhhdCB0aGUgY3VycmVudGx5IGltcGxlbWVudGVkCnZpcmlkaWFu IGh5cGVyY2FsbHMgc3BlY2lmeSBhIHZDUFUgbWFzaywgdGhlcmUgYXJlIG5ld2VyIHZhcmlhbnRz IHdoaWNoCnNwZWNpZnkgYSBzcGFyc2UgSFZfVlBfU0VUIGFuZCB0aHVzIHVzZSBvZiBhIGNhbGxi YWNrIHdpbGwgYXZvaWQgbmVlZGluZyB0bwpleHBvc2UgZGV0YWlscyBvZiB0aGlzIG91dHNpZGUg b2YgdGhlIHZpcmlkaWFuIHN1YnN5c3RlbSBpZiBhbmQgd2hlbiB0aG9zZQpuZXdlciB2YXJpYW50 cyBhcmUgaW1wbGVtZW50ZWQuCgpOT1RFOiBVc2Ugb2YgdGhlIGNvbW1vbiBmbHVzaCBmdW5jdGlv biByZXF1aXJlcyB0aGF0IHRoZSBoeXBlcmNhbGxzIGFyZQogICAgICByZXN0YXJ0YWJsZSBhbmQg c28sIHdpdGggdGhpcyBwYXRjaCBhcHBsaWVkLCB2aXJpZGlhbl9oeXBlcmNhbGwoKQogICAgICBj YW4gbm93IHJldHVybiBIVk1fSENBTExfcHJlZW1wdGVkLiBUaGlzIGlzIHNhZmUgYXMgbm8gbW9k aWZpY2F0aW9uCiAgICAgIHRvIHN0cnVjdCBjcHVfdXNlcl9yZWdzIGlzIGRvbmUgYmVmb3JlIHRo ZSByZXR1cm4uCgpTaWduZWQtb2ZmLWJ5OiBQYXVsIER1cnJhbnQgPHBhdWwuZHVycmFudEBjaXRy aXguY29tPgotLS0KQ2M6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KQ2M6IEFuZHJl dyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+CkNjOiBXZWkgTGl1IDx3ZWkubGl1 MkBjaXRyaXguY29tPgpDYzogIlJvZ2VyIFBhdSBNb25uw6kiIDxyb2dlci5wYXVAY2l0cml4LmNv bT4KCnYzOgogLSBEb24ndCB1c2UgY3B1bWFza19zY3JhdGNoIGFzIGl0IGlzIG5vdCBzYWZlCiAt IFJlLWludHJvZHVjZSBmbHVzaF9jcHVtYXNrLCBidXQgcmVzdHJpY3Qgc2NvcGUKCnYyOgogLSBV c2UgY3B1bWFza19zY3JhdGNoCiAtIE1ha2Ugc3VyZSBsb2NhbCBDUFUgZmx1c2ggaXNuJ3QgbWlz c2VkCi0tLQogeGVuL2FyY2gveDg2L2h2bS9odm0uYyAgICAgICAgICAgICAgIHwgNDggKysrKysr KysrKysrKysrKysrKysrLS0tLS0tLQogeGVuL2FyY2gveDg2L2h2bS92aXJpZGlhbi92aXJpZGlh bi5jIHwgNDUgKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0KIHhlbi9pbmNsdWRlL2FzbS14ODYv aHZtL2h2bS5oICAgICAgICB8ICAyICsrCiAzIGZpbGVzIGNoYW5nZWQsIDUzIGluc2VydGlvbnMo KyksIDQyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9odm0vaHZtLmMg Yi94ZW4vYXJjaC94ODYvaHZtL2h2bS5jCmluZGV4IDQxMDYyM2Q0MzcuLjlhOTU2NmM3YWIgMTAw NjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vaHZtLmMKKysrIGIveGVuL2FyY2gveDg2L2h2bS9o dm0uYwpAQCAtMzk2NCwyNiArMzk2NCwyOCBAQCBzdGF0aWMgdm9pZCBodm1fczNfcmVzdW1lKHN0 cnVjdCBkb21haW4gKmQpCiAgICAgfQogfQogCi1zdGF0aWMgaW50IGh2bW9wX2ZsdXNoX3RsYl9h bGwodm9pZCkKK2Jvb2wgaHZtX2ZsdXNoX3ZjcHVfdGxiKGJvb2wgKCpmbHVzaF92Y3B1KSh2b2lk ICpjdHh0LCBzdHJ1Y3QgdmNwdSAqdiksCisgICAgICAgICAgICAgICAgICAgICAgICB2b2lkICpj dHh0KQogeworICAgIHN0YXRpYyBERUZJTkVfUEVSX0NQVShjcHVtYXNrX3QsIGZsdXNoX2NwdW1h c2spOworICAgIGNwdW1hc2tfdCAqbWFzayA9ICZ0aGlzX2NwdShmbHVzaF9jcHVtYXNrKTsKICAg ICBzdHJ1Y3QgZG9tYWluICpkID0gY3VycmVudC0+ZG9tYWluOwogICAgIHN0cnVjdCB2Y3B1ICp2 OwogCi0gICAgaWYgKCAhaXNfaHZtX2RvbWFpbihkKSApCi0gICAgICAgIHJldHVybiAtRUlOVkFM OwotCiAgICAgLyogQXZvaWQgZGVhZGxvY2sgaWYgbW9yZSB0aGFuIG9uZSB2Y3B1IHRyaWVzIHRo aXMgYXQgdGhlIHNhbWUgdGltZS4gKi8KICAgICBpZiAoICFzcGluX3RyeWxvY2soJmQtPmh5cGVy Y2FsbF9kZWFkbG9ja19tdXRleCkgKQotICAgICAgICByZXR1cm4gLUVSRVNUQVJUOworICAgICAg ICByZXR1cm4gZmFsc2U7CiAKICAgICAvKiBQYXVzZSBhbGwgb3RoZXIgdmNwdXMuICovCiAgICAg Zm9yX2VhY2hfdmNwdSAoIGQsIHYgKQotICAgICAgICBpZiAoIHYgIT0gY3VycmVudCApCisgICAg ICAgIGlmICggdiAhPSBjdXJyZW50ICYmIGZsdXNoX3ZjcHUoY3R4dCwgdikgKQogICAgICAgICAg ICAgdmNwdV9wYXVzZV9ub3N5bmModik7CiAKKyAgICBjcHVtYXNrX2NsZWFyKG1hc2spOworCiAg ICAgLyogTm93IHRoYXQgYWxsIFZDUFVzIGFyZSBzaWduYWxsZWQgdG8gZGVzY2hlZHVsZSwgd2Ug d2FpdC4uLiAqLwogICAgIGZvcl9lYWNoX3ZjcHUgKCBkLCB2ICkKLSAgICAgICAgaWYgKCB2ICE9 IGN1cnJlbnQgKQorICAgICAgICBpZiAoIHYgIT0gY3VycmVudCAmJiBmbHVzaF92Y3B1KGN0eHQs IHYpICkKICAgICAgICAgICAgIHdoaWxlICggIXZjcHVfcnVubmFibGUodikgJiYgdi0+aXNfcnVu bmluZyApCiAgICAgICAgICAgICAgICAgY3B1X3JlbGF4KCk7CiAKQEAgLTM5OTIsMTcgKzM5OTQs NDEgQEAgc3RhdGljIGludCBodm1vcF9mbHVzaF90bGJfYWxsKHZvaWQpCiAKICAgICAvKiBGbHVz aCBwYWdpbmctbW9kZSBzb2Z0IHN0YXRlIChlLmcuLCB2YS0+Z2ZuIGNhY2hlOyBQQUUgUERQRSBj YWNoZSkuICovCiAgICAgZm9yX2VhY2hfdmNwdSAoIGQsIHYgKQorICAgIHsKKyAgICAgICAgdW5z aWduZWQgaW50IGNwdTsKKworICAgICAgICBpZiAoICFmbHVzaF92Y3B1KGN0eHQsIHYpICkKKyAg ICAgICAgICAgIGNvbnRpbnVlOworCiAgICAgICAgIHBhZ2luZ191cGRhdGVfY3IzKHYsIGZhbHNl KTsKIAotICAgIC8qIEZsdXNoIGFsbCBkaXJ0eSBUTEJzLiAqLwotICAgIGZsdXNoX3RsYl9tYXNr KGQtPmRpcnR5X2NwdW1hc2spOworICAgICAgICBjcHUgPSByZWFkX2F0b21pYygmdi0+ZGlydHlf Y3B1KTsKKyAgICAgICAgaWYgKCBpc192Y3B1X2RpcnR5X2NwdShjcHUpICkKKyAgICAgICAgICAg IF9fY3B1bWFza19zZXRfY3B1KGNwdSwgbWFzayk7CisgICAgfQorCisgICAgLyogRmx1c2ggVExC cyBvbiBhbGwgQ1BVcyB3aXRoIGRpcnR5IHZjcHUgc3RhdGUuICovCisgICAgZmx1c2hfdGxiX21h c2sobWFzayk7CiAKICAgICAvKiBEb25lLiAqLwogICAgIGZvcl9lYWNoX3ZjcHUgKCBkLCB2ICkK LSAgICAgICAgaWYgKCB2ICE9IGN1cnJlbnQgKQorICAgICAgICBpZiAoIHYgIT0gY3VycmVudCAm JiBmbHVzaF92Y3B1KGN0eHQsIHYpICkKICAgICAgICAgICAgIHZjcHVfdW5wYXVzZSh2KTsKIAot ICAgIHJldHVybiAwOworICAgIHJldHVybiB0cnVlOworfQorCitzdGF0aWMgYm9vbCBhbHdheXNf Zmx1c2godm9pZCAqY3R4dCwgc3RydWN0IHZjcHUgKnYpCit7CisgICAgcmV0dXJuIHRydWU7Cit9 CisKK3N0YXRpYyBpbnQgaHZtb3BfZmx1c2hfdGxiX2FsbCh2b2lkKQoreworICAgIGlmICggIWlz X2h2bV9kb21haW4oY3VycmVudC0+ZG9tYWluKSApCisgICAgICAgIHJldHVybiAtRUlOVkFMOwor CisgICAgcmV0dXJuIGh2bV9mbHVzaF92Y3B1X3RsYihhbHdheXNfZmx1c2gsIE5VTEwpID8gMCA6 IC1FUkVTVEFSVDsKIH0KIAogc3RhdGljIGludCBodm1vcF9zZXRfZXZ0Y2huX3VwY2FsbF92ZWN0 b3IoCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaHZtL3ZpcmlkaWFuL3ZpcmlkaWFuLmMgYi94 ZW4vYXJjaC94ODYvaHZtL3ZpcmlkaWFuL3ZpcmlkaWFuLmMKaW5kZXggYzc4YjI5MThkOS4uNDI1 YWY1Njg1NiAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L2h2bS92aXJpZGlhbi92aXJpZGlhbi5j CisrKyBiL3hlbi9hcmNoL3g4Ni9odm0vdmlyaWRpYW4vdmlyaWRpYW4uYwpAQCAtNDMwLDcgKzQz MCwxNiBAQCB2b2lkIHZpcmlkaWFuX2RvbWFpbl9kZWluaXQoc3RydWN0IGRvbWFpbiAqZCkKICAg ICAgICAgdmlyaWRpYW5fdmNwdV9kZWluaXQodik7CiB9CiAKLXN0YXRpYyBERUZJTkVfUEVSX0NQ VShjcHVtYXNrX3QsIGlwaV9jcHVtYXNrKTsKKy8qCisgKiBXaW5kb3dzIHNob3VsZCBub3QgaXNz dWUgdGhlIGh5cGVyY2FsbHMgcmVxdWlyaW5nIHRoaXMgY2FsbGJhY2sgaW4gdGhlCisgKiBjYXNl IHdoZXJlIHZjcHVfaWQgd291bGQgZXhjZWVkIHRoZSBzaXplIG9mIHRoZSBtYXNrLgorICovCitz dGF0aWMgYm9vbCBuZWVkX2ZsdXNoKHZvaWQgKmN0eHQsIHN0cnVjdCB2Y3B1ICp2KQoreworICAg IHVpbnQ2NF90IHZjcHVfbWFzayA9ICoodWludDY0X3QgKiljdHh0OworCisgICAgcmV0dXJuIHZj cHVfbWFzayAmICgxdWwgPDwgdi0+dmNwdV9pZCk7Cit9CiAKIGludCB2aXJpZGlhbl9oeXBlcmNh bGwoc3RydWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3MpCiB7CkBAIC00OTQsOCArNTAzLDYgQEAgaW50 IHZpcmlkaWFuX2h5cGVyY2FsbChzdHJ1Y3QgY3B1X3VzZXJfcmVncyAqcmVncykKICAgICBjYXNl IEh2Rmx1c2hWaXJ0dWFsQWRkcmVzc1NwYWNlOgogICAgIGNhc2UgSHZGbHVzaFZpcnR1YWxBZGRy ZXNzTGlzdDoKICAgICB7Ci0gICAgICAgIGNwdW1hc2tfdCAqcGNwdV9tYXNrOwotICAgICAgICBz dHJ1Y3QgdmNwdSAqdjsKICAgICAgICAgc3RydWN0IHsKICAgICAgICAgICAgIHVpbnQ2NF90IGFk ZHJlc3Nfc3BhY2U7CiAgICAgICAgICAgICB1aW50NjRfdCBmbGFnczsKQEAgLTUyMSwzNiArNTI4 LDEyIEBAIGludCB2aXJpZGlhbl9oeXBlcmNhbGwoc3RydWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3Mp CiAgICAgICAgIGlmICggaW5wdXRfcGFyYW1zLmZsYWdzICYgSFZfRkxVU0hfQUxMX1BST0NFU1NP UlMgKQogICAgICAgICAgICAgaW5wdXRfcGFyYW1zLnZjcHVfbWFzayA9IH4wdWw7CiAKLSAgICAg ICAgcGNwdV9tYXNrID0gJnRoaXNfY3B1KGlwaV9jcHVtYXNrKTsKLSAgICAgICAgY3B1bWFza19j bGVhcihwY3B1X21hc2spOwotCi0gICAgICAgIC8qCi0gICAgICAgICAqIEZvciBlYWNoIHNwZWNp ZmllZCB2aXJ0dWFsIENQVSBmbHVzaCBhbGwgQVNJRHMgdG8gaW52YWxpZGF0ZQotICAgICAgICAg KiBUTEIgZW50cmllcyB0aGUgbmV4dCB0aW1lIGl0IGlzIHNjaGVkdWxlZCBhbmQgdGhlbiwgaWYg aXQKLSAgICAgICAgICogaXMgY3VycmVudGx5IHJ1bm5pbmcsIGFkZCBpdHMgcGh5c2ljYWwgQ1BV IHRvIGEgbWFzayBvZgotICAgICAgICAgKiB0aG9zZSB3aGljaCBuZWVkIHRvIGJlIGludGVycnVw dGVkIHRvIGZvcmNlIGEgZmx1c2guCi0gICAgICAgICAqLwotICAgICAgICBmb3JfZWFjaF92Y3B1 ICggY3VycmQsIHYgKQotICAgICAgICB7Ci0gICAgICAgICAgICBpZiAoIHYtPnZjcHVfaWQgPj0g KHNpemVvZihpbnB1dF9wYXJhbXMudmNwdV9tYXNrKSAqIDgpICkKLSAgICAgICAgICAgICAgICBi cmVhazsKLQotICAgICAgICAgICAgaWYgKCAhKGlucHV0X3BhcmFtcy52Y3B1X21hc2sgJiAoMXVs IDw8IHYtPnZjcHVfaWQpKSApCi0gICAgICAgICAgICAgICAgY29udGludWU7Ci0KLSAgICAgICAg ICAgIGh2bV9hc2lkX2ZsdXNoX3ZjcHUodik7Ci0gICAgICAgICAgICBpZiAoIHYgIT0gY3VyciAm JiB2LT5pc19ydW5uaW5nICkKLSAgICAgICAgICAgICAgICBfX2NwdW1hc2tfc2V0X2NwdSh2LT5w cm9jZXNzb3IsIHBjcHVfbWFzayk7Ci0gICAgICAgIH0KLQogICAgICAgICAvKgotICAgICAgICAg KiBTaW5jZSBBU0lEcyBoYXZlIG5vdyBiZWVuIGZsdXNoZWQgaXQganVzdCByZW1haW5zIHRvCi0g ICAgICAgICAqIGZvcmNlIGFueSBDUFVzIGN1cnJlbnRseSBydW5uaW5nIHRhcmdldCB2Q1BVcyBv dXQgb2Ygbm9uLQotICAgICAgICAgKiByb290IG1vZGUuIEl0J3MgcG9zc2libGUgdGhhdCByZS1z Y2hlZHVsaW5nIGhhcyB0YWtlbiBwbGFjZQotICAgICAgICAgKiBzbyB3ZSBtYXkgdW5uZWNlc3Nh cmlseSBJUEkgc29tZSBDUFVzLgorICAgICAgICAgKiBBIGZhbHNlIHJldHVybiBtZWFucyB0aGF0 IGFub3RoZXIgdmNwdSBpcyBjdXJyZW50bHkgdHJ5aW5nCisgICAgICAgICAqIGEgc2ltaWxhciBv cGVyYXRpb24sIHNvIGJhY2sgb2ZmLgogICAgICAgICAgKi8KLSAgICAgICAgaWYgKCAhY3B1bWFz a19lbXB0eShwY3B1X21hc2spICkKLSAgICAgICAgICAgIHNtcF9zZW5kX2V2ZW50X2NoZWNrX21h c2socGNwdV9tYXNrKTsKKyAgICAgICAgaWYgKCAhaHZtX2ZsdXNoX3ZjcHVfdGxiKG5lZWRfZmx1 c2gsICZpbnB1dF9wYXJhbXMudmNwdV9tYXNrKSApCisgICAgICAgICAgICByZXR1cm4gSFZNX0hD QUxMX3ByZWVtcHRlZDsKIAogICAgICAgICBvdXRwdXQucmVwX2NvbXBsZXRlID0gaW5wdXQucmVw X2NvdW50OwogCmRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20teDg2L2h2bS9odm0uaCBiL3hl bi9pbmNsdWRlL2FzbS14ODYvaHZtL2h2bS5oCmluZGV4IDBhMTBiNTE1NTQuLjUzZmZlYmIyYzUg MTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvaHZtL2h2bS5oCisrKyBiL3hlbi9pbmNs dWRlL2FzbS14ODYvaHZtL2h2bS5oCkBAIC0zMzgsNiArMzM4LDggQEAgY29uc3QgY2hhciAqaHZt X2VmZXJfdmFsaWQoY29uc3Qgc3RydWN0IHZjcHUgKnYsIHVpbnQ2NF90IHZhbHVlLAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgc2lnbmVkIGludCBjcjBfcGcpOwogdW5zaWduZWQgbG9uZyBo dm1fY3I0X2d1ZXN0X3ZhbGlkX2JpdHMoY29uc3Qgc3RydWN0IGRvbWFpbiAqZCwgYm9vbCByZXN0 b3JlKTsKIAorYm9vbCBodm1fZmx1c2hfdmNwdV90bGIoYm9vbCAoKmZsdXNoX3ZjcHUpKHZvaWQg KmN0eHQsIHN0cnVjdCB2Y3B1ICp2KSwKKyAgICAgICAgICAgICAgICAgICAgICAgIHZvaWQgKmN0 eHQpOwogCiAjaWZkZWYgQ09ORklHX0hWTQogCi0tIAoyLjIwLjEuMi5nYjIxZWJiNjcxCgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1h aWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54 ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==