Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37F11C43381 for ; Thu, 14 Feb 2019 13:51:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F398222D4 for ; Thu, 14 Feb 2019 13:51:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407153AbfBNNvc (ORCPT ); Thu, 14 Feb 2019 08:51:32 -0500 Received: from mx2.suse.de ([195.135.220.15]:46392 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2407162AbfBNNvb (ORCPT ); Thu, 14 Feb 2019 08:51:31 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 686DCAFBB; Thu, 14 Feb 2019 13:51:30 +0000 (UTC) Received: by unicorn.suse.cz (Postfix, from userid 1000) id 14F8AE0139; Thu, 14 Feb 2019 14:51:30 +0100 (CET) Date: Thu, 14 Feb 2019 14:51:30 +0100 From: Michal Kubecek To: netdev@vger.kernel.org Cc: Hangbin Liu , David Ahern , Eric Dumazet , Stephen Hemminger , Phil Sutter Subject: Re: [PATCH iproute2] lib/libnetlink: ensure a minimum of 32KB for the buffer used in rtnl_recvmsg() Message-ID: <20190214135130.GK25518@unicorn.suse.cz> References: <20190213015841.140383-1-edumazet@google.com> <5f91bd70-98af-8108-859b-d0482f80674e@gmail.com> <20190213062012.GC10051@dhcp-12-139.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190213062012.GC10051@dhcp-12-139.nay.redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 13, 2019 at 02:20:12PM +0800, Hangbin Liu wrote: > > > > Do we know of any single message sizes > 32k? 2d34851cd341 cites > > > increasing VF's but at some point there is a limit. If not, the whole > > > PEEK thing should go away and we just malloc 32k (or 64k) buffers for > > > each recvmsg. > > Apart from the 200 VFs example, I think there will be more and more virtual > interfaces be used in cloud environment, like openstack/OVS, so useing 32K > or 64K is still not safe. Many intefraces are not a problem. Those will have separate messages so that they don't need to fit into one buffer. Michal Kubecek