From: Roger Pau =?utf-8?B?TW9ubsOp?= Subject: Re: [PATCH for-4.12 v2 2/7] amd/npt/shadow: replace assert that prevents creating 2M/1G MMIO entries Date: Thu, 14 Feb 2019 14:59:10 +0100 Message-ID: <20190214135910.egdaixdbv6zogwfx@mac> References: <20190211174642.38046-1-roger.pau@citrix.com> <20190211174642.38046-3-roger.pau@citrix.com> <5C643D6A020000780021661A@prv1-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1guHXs-00083d-EI for xen-devel@lists.xenproject.org; Thu, 14 Feb 2019 13:59:20 +0000 Content-Disposition: inline In-Reply-To: <5C643D6A020000780021661A@prv1-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Jan Beulich Cc: Juergen Gross , Wei Liu , George Dunlap , Andrew Cooper , george.dunlap@citrix.com, xen-devel List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBGZWIgMTMsIDIwMTkgYXQgMDg6NTM6MTRBTSAtMDcwMCwgSmFuIEJldWxpY2ggd3Jv dGU6Cj4gPj4+IE9uIDExLjAyLjE5IGF0IDE4OjQ2LCA8cm9nZXIucGF1QGNpdHJpeC5jb20+IHdy b3RlOgo+ID4gVGhlIGFzc2VydCB3YXMgb3JpZ2luYWxseSBhZGRlZCB0byBtYWtlIHN1cmUgdGhh dCBoaWdoZXIgb3JkZXIKPiA+IHJlZ2lvbnMgKD4gUEFHRV9PUkRFUl80SykgY291bGQgbm90IGJl IHVzZWQgdG8gYnlwYXNzIHRoZQo+ID4gbW1pb19yb19yYW5nZXMgY2hlY2sgcGVyZm9ybWVkIGJ5 IHAybV90eXBlX3RvX2ZsYWdzLgo+ID4gCj4gPiBUaGlzIGhvd2V2ZXIgaXMgYWxyZWFkeSBjaGVj a2VkIGluIHNldF9tbWlvX3AybV9lbnRyeSwgd2hpY2ggbWFrZXMKPiA+IHN1cmUgdGhhdCBoaWdo ZXIgb3JkZXIgbWFwcGluZ3MgZG9uJ3Qgb3ZlcmxhcCB3aXRoIG1taW9fcm9fcmFuZ2VzLAo+ID4g dGh1cyBhbGxvd2luZyB0aGUgY3JlYXRpb24gb2YgaGlnaCBvcmRlciBNTUlPIG1hcHBpbmdzIHNh ZmVseS4KPiA+IAo+ID4gUmVwbGFjZSB0aGUgYXNzZXJ0IHRvIGFsbG93IDJNLzFHIGVudHJpZXMg dG8gYmUgY3JlYXRlZCBmb3IgTU1JTwo+ID4gcmVnaW9ucyBhbmQgYWRkIHNvbWUgZXh0cmEgYXNz ZXJ0cyBhcyBhIHJlcGxhY2VtZW50IHRvIG1ha2Ugc3VyZQo+ID4gdGhlcmUncyBubyBvdmVybGFw cGluZyB3aXRoIE1NSU8gcmVhZC1vbmx5IHJhbmdlcy4KPiA+IAo+ID4gTm90ZSB0aGF0IDFHIE1N SU8gZW50cmllcyB3aWxsIG5vdCBiZSBjcmVhdGVkIHVubGVzcyBtbWlvX29yZGVyIGlzCj4gPiBj aGFuZ2VkIHRvIGFsbG93IGl0Lgo+ID4gCj4gPiBTdWdnZXN0ZWQtYnk6IEdlb3JnZSBEdW5sYXAg PGdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbT4KPiAKPiBJcyB0aGlzIHN0aWxsIHRoZSBjYXNlPyBJ aXJjIHRoZSBvcmlnaW5hbCBzdWdnZXN0aW9uIHdhcyB0byByZW1vdmUKPiB0aGUgYXNzZXJ0aW9u IGFsdG9nZXRoZXI/CgpSaWdodCwgc2hvdWxkIEkgaW5zdGVhZCBhZGQgeW91ciBzdWdnZXN0ZWQt YnkgdGFnPwoKPiA+IC0tLSBhL3hlbi9hcmNoL3g4Ni9tbS9wMm0tcHQuYwo+ID4gKysrIGIveGVu L2FyY2gveDg2L21tL3AybS1wdC5jCj4gPiBAQCAtNTc2LDcgKzU3NiwxNSBAQCBwMm1fcHRfc2V0 X2VudHJ5KHN0cnVjdCBwMm1fZG9tYWluICpwMm0sIGdmbl90IGdmbl8sIG1mbl90IG1mbiwKPiA+ ICAgICAgICAgIH0KPiA+ICAKPiA+ICAgICAgICAgIEFTU0VSVChwMm1fZmxhZ3NfdG9fdHlwZShm bGFncykgIT0gcDJtX2lvcmVxX3NlcnZlcik7Cj4gPiAtICAgICAgICBBU1NFUlQoIW1mbl92YWxp ZChtZm4pIHx8IHAybXQgIT0gcDJtX21taW9fZGlyZWN0KTsKPiA+ICsgICAgICAgIGlmICggcDJt dCA9PSBwMm1fbW1pb19kaXJlY3QgKQo+ID4gKyAgICAgICAgICAgIEFTU0VSVCghbWZuX2VxKG1m biwgSU5WQUxJRF9NRk4pICYmCj4gPiArICAgICAgICAgICAgICAgICAgICFyYW5nZXNldF9vdmVy bGFwc19yYW5nZShtbWlvX3JvX3JhbmdlcywgbWZuX3gobWZuKSwKPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1mbl94KG1mbikgKyBQRk5fRE9XTihNQigy KSkpKTsKPiA+ICsgICAgICAgIGVsc2UgaWYgKCBwMm1fYWxsb3dzX2ludmFsaWRfbWZuKHAybXQp IHx8IHAybXQgPT0gcDJtX2ludmFsaWQgfHwKPiA+ICsgICAgICAgICAgICAgICAgICBwMm10ID09 IHAybV9tbWlvX2RtICkKPiA+ICsgICAgICAgICAgICBBU1NFUlQobWZuX3ZhbGlkKG1mbikgfHwg bWZuX2VxKG1mbiwgSU5WQUxJRF9NRk4pKTsKPiA+ICsgICAgICAgIGVsc2UKPiA+ICsgICAgICAg ICAgICBBU1NFUlQobWZuX3ZhbGlkKG1mbikpOwo+ID4gICAgICAgICAgbDNlX2NvbnRlbnQgPSBt Zm5fdmFsaWQobWZuKSB8fCBwMm1fYWxsb3dzX2ludmFsaWRfbWZuKHAybXQpCj4gPiAgICAgICAg ICAgICAgPyBwMm1fbDNlX2Zyb21fcGZuKG1mbl94KG1mbiksCj4gPiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHAybV90eXBlX3RvX2ZsYWdzKHAybSwgcDJtdCwgbWZuLCAyKSkKPiA+ IEBAIC02NjgsNyArNjc2LDE1IEBAIHAybV9wdF9zZXRfZW50cnkoc3RydWN0IHAybV9kb21haW4g KnAybSwgZ2ZuX3QgZ2ZuXywgbWZuX3QgbWZuLAo+ID4gICAgICAgICAgfQo+ID4gIAo+ID4gICAg ICAgICAgQVNTRVJUKHAybV9mbGFnc190b190eXBlKGZsYWdzKSAhPSBwMm1faW9yZXFfc2VydmVy KTsKPiA+IC0gICAgICAgIEFTU0VSVCghbWZuX3ZhbGlkKG1mbikgfHwgcDJtdCAhPSBwMm1fbW1p b19kaXJlY3QpOwo+ID4gKyAgICAgICAgaWYgKCBwMm10ID09IHAybV9tbWlvX2RpcmVjdCApCj4g PiArICAgICAgICAgICAgQVNTRVJUKCFtZm5fZXEobWZuLCBJTlZBTElEX01GTikgJiYKPiA+ICsg ICAgICAgICAgICAgICAgICAgIXJhbmdlc2V0X292ZXJsYXBzX3JhbmdlKG1taW9fcm9fcmFuZ2Vz LCBtZm5feChtZm4pLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgbWZuX3gobWZuKSArIFBGTl9ET1dOKE1CKDIpKSkpOwo+ID4gKyAgICAgICAgZWxzZSBp ZiAoIHAybV9hbGxvd3NfaW52YWxpZF9tZm4ocDJtdCkgfHwgcDJtdCA9PSBwMm1faW52YWxpZCB8 fAo+ID4gKyAgICAgICAgICAgICAgICAgIHAybXQgPT0gcDJtX21taW9fZG0gKQo+ID4gKyAgICAg ICAgICAgIEFTU0VSVChtZm5fdmFsaWQobWZuKSB8fCBtZm5fZXEobWZuLCBJTlZBTElEX01GTikp Owo+ID4gKyAgICAgICAgZWxzZQo+ID4gKyAgICAgICAgICAgIEFTU0VSVChtZm5fdmFsaWQobWZu KSk7Cj4gCj4gU2VlaW5nIHRoaXMgc3VwcG9zZWRseSBhbG1vc3QgdGhlIHNhbWUgKGJ1dCBhY3R1 YWxseSBlbnRpcmVseSB0aGUgc2FtZSwKPiBkdWUgdG8gdGhlIHdyb25nIE1CKDIpIGluIHRoZSBm aXJzdCBodW5rKSBjb2RlIEkgd29uZGVyIHdoZXRoZXIgdGhpcwo+IHdvdWxkbid0IGJldHRlciBi ZSBwdXQgaW4gYSBoZWxwZXIgKG1hY3JvIG9yIGZ1bmN0aW9uKSwgdG9nZXRoZXIgd2l0aAo+IGFk amFjZW50IGFzc2VydGlvbiBpbiBjb250ZXh0LCBpbW1lZGlhdGVseSBhaGVhZCBvZiB0aGUgbGlu ZSB5b3UgYWx0ZXIuCgpUaGFua3MsIEkndmUgcGxhY2VkIHRoaXMgaW50byBhIGhlbHBlciBmdW5j dGlvbiBuYW1lZCBjaGVja19lbnRyeSwKd2hpY2ggaXMgdGhlIGJlc3QgbmFtZSBJIGNvdWxkIGNv bWUgdXAgd2l0aC4KClJvZ2VyLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJv amVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hl bi1kZXZlbA==