Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 16 Feb 2019 17:12:53 -0000 Received: from mga17.intel.com ([192.55.52.151]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gv3WG-0001T5-7O for speck@linutronix.de; Sat, 16 Feb 2019 18:12:52 +0100 Date: Sat, 16 Feb 2019 09:12:49 -0800 From: Andi Kleen Subject: [MODERATED] Re: [PATCH v5 14/27] MDSv5 3 Message-ID: <20190216171249.GI16922@tassilo.jf.intel.com> References: <8b89fce6dd87638a00078082141d3ce5fe13d0ea.1547858934.git.ak@linux.intel.com> <20190216020039.GG16922@tassilo.jf.intel.com> <20190216165828.GH16922@tassilo.jf.intel.com> MIME-Version: 1.0 In-Reply-To: <20190216165828.GH16922@tassilo.jf.intel.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Sat, Feb 16, 2019 at 08:58:28AM -0800, speck for Andi Kleen wrote: > > Ergo, this can be completely done in switch_mm_irqs_off() and does not at > > all require any of that propagation logic in switch_to(). > > And why is that a benefit? > > Ok it's just moving one if with a single condition to another function > to turn it into another condition > > if (prev_mm != next_mm) Ok it's actually if (prev_mm != next_mm || prev_mm == NULL) Oh well. I will do the change. But anyone else who has to understand this later will not love you. -Andi