Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E8A0C43381 for ; Sun, 17 Feb 2019 16:34:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 151832190C for ; Sun, 17 Feb 2019 16:34:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="WzLEqmTa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726087AbfBQQem (ORCPT ); Sun, 17 Feb 2019 11:34:42 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:39770 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725810AbfBQQel (ORCPT ); Sun, 17 Feb 2019 11:34:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HZirw7f0lgZ7Bd8UW4NAOTbwHGCY5wHMjgt6Bfb7Pi4=; b=WzLEqmTaW/svUOhm3nYVM+vrG IFPJaPgprK6ctvU6fYRhvmnX4nf7XSM70soOi3AL1CgdFjMV0iRdFFpp7fE2vy5C9fqWHNATRPFJo wtgKedEIfbLw3siEsrPs73aPW8dP674l3qT76s+AYjpVbvCQaEFcLutlAPYFvZyDp+tXFDoeLgJ3L l1ONlgaOqg6xuZx6EmwAIkH9MPAq2rklnv8LrkJPCE6LqNTiYDJ/SqNXid+D9PFgFnZRrB1EVd1uH EZLc22J/iNaXdQVN1ON2gcdgaaRfo7HKLfHSDjEQKJf4jAPVHc2nJugFh8YL8VBmdSnbm/c3k2/SD 1jWRc/n8Q==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:36842) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1gvPOm-0001Jz-3M; Sun, 17 Feb 2019 16:34:36 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.89) (envelope-from ) id 1gvPOk-0006QT-Kw; Sun, 17 Feb 2019 16:34:34 +0000 Date: Sun, 17 Feb 2019 16:34:34 +0000 From: Russell King - ARM Linux admin To: Andrew Lunn , Florian Fainelli , Vivien Didelot Cc: "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: defautl to multicast and unicast flooding Message-ID: <20190217163434.xo3ojbny4dnfqqwq@shell.armlinux.org.uk> References: <20190217142414.cjtmpi5y2l5rtdlb@shell.armlinux.org.uk> <20190217142716.gsrq5k2gnw3hsnhu@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190217142716.gsrq5k2gnw3hsnhu@shell.armlinux.org.uk> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Feb 17, 2019 at 02:27:16PM +0000, Russell King - ARM Linux admin wrote: > On Sun, Feb 17, 2019 at 02:25:17PM +0000, Russell King wrote: > > Switches work by learning the MAC address for each attached station by > > monitoring traffic from each station. When a station sends a packet, > > the switch records which port the MAC address is connected to. > > > > With IPv4 networking, before communication commences with a neighbour, > > an ARP packet is broadcasted to all stations asking for the MAC address > > corresponding with the IPv4. The desired station responds with an ARP > > reply, and the ARP reply causes the switch to learn which port the > > station is connected to. > > > > With IPv6 networking, the situation is rather different. Rather than > > broadcasting ARP packets, a "neighbour solicitation" is multicasted > > rather than broadcasted. This multicast needs to reach the intended > > station in order for the neighbour to be discovered. > > > > Once a neighbour has been discovered, and entered into the sending > > stations neighbour cache, communication can restart at a point later > > without sending a new neighbour solicitation, even if the entry in > > the neighbour cache is marked as stale. This can be after the MAC > > address has expired from the forwarding cache of the DSA switch - > > when that occurs, there is a long pause in communication. > > > > Our DSA implementation for mv88e6xxx switches has defaulted to having > > multicast and unicast flooding disabled. As per the above description, > > this is fine for IPv4 networking, since the broadcasted ARP queries > > will be sent to and received by all stations on the same network. > > However, this breaks IPv6 very badly - blocking neighbour solicitations > > and later causing connections to stall. > > > > The defaults that the Linux bridge code expect from bridges are that > > unknown unicast frames and unknown multicast frames are flooded to > > all stations, which is at odds to the defaults adopted by our DSA > > implementation for mv88e6xxx switches. > > > > This commit enables by default flooding of both unknown unicast and > > unknown multicast frames. This means that mv88e6xxx DSA switches now > > behave as per the bridge(8) man page, and IPv6 works flawlessly through > > such a switch. > > Note that there is the open question whether this affects the case where > each port is used as a separate network interface: that case has not yet > been tested. I've checked with a mv88e6131 on the clearfog gt8k board. lan1 connected to my lan with plenty of traffic on, and configured as part of a bridge. lan2 connected to the zii board, but not part of the bridge. Monitoring lan2 from the zii board shows no traffic that was received from lan1. So it looks fine. > > > > > Signed-off-by: Russell King > > --- > > drivers/net/dsa/mv88e6xxx/chip.c | 9 +++++---- > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c > > index b75a865a293d..eb5e3d88374f 100644 > > --- a/drivers/net/dsa/mv88e6xxx/chip.c > > +++ b/drivers/net/dsa/mv88e6xxx/chip.c > > @@ -2144,13 +2144,14 @@ static int mv88e6xxx_setup_message_port(struct mv88e6xxx_chip *chip, int port) > > static int mv88e6xxx_setup_egress_floods(struct mv88e6xxx_chip *chip, int port) > > { > > struct dsa_switch *ds = chip->ds; > > - bool flood; > > > > - /* Upstream ports flood frames with unknown unicast or multicast DA */ > > - flood = dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port); > > + /* Linux bridges are expected to flood unknown multicast and > > + * unicast frames to all ports - as per the defaults specified > > + * in the iproute2 bridge(8) man page. Not doing this causes > > + * stalls and failures with IPv6 over Marvell bridges. */ > > if (chip->info->ops->port_set_egress_floods) > > return chip->info->ops->port_set_egress_floods(chip, port, > > - flood, flood); > > + true, true); > > > > return 0; > > } > > -- > > 2.7.4 > > > > > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up > According to speedtest.net: 11.9Mbps down 500kbps up -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up