Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC0ECC43381 for ; Sun, 17 Feb 2019 17:04:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC31921934 for ; Sun, 17 Feb 2019 17:04:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="AzOXKMf5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727572AbfBQREE (ORCPT ); Sun, 17 Feb 2019 12:04:04 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:40102 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725810AbfBQREE (ORCPT ); Sun, 17 Feb 2019 12:04:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yIdN7SadBHtB2D40bNNJTxjUwFlLVOIRwReaZzl/Mzo=; b=AzOXKMf51DUxD/ax8FUk63ghK XKW2QdV4m1IKV1l3tXof5cpkuoUCUBd0uczdbknfTyN83YJtazVdLSTG66NGZPydsnVudGfzj0Cqr Y0LgSbi3O0+Rs4RaWV4bN4ABDyM9AU9mbn0PSHZcpKFjZouHNSF3fklaUBXhptKnws5UpPlUIHBrQ mionyz40eDLDW5ogMqKP098Uk1Gdg04D4uc/70mBIAUmqX1m09fHpYY4s+MzQEYBDF2E4OVjzCeIj wQdOOXFcYsoOKBHrP6rUWrccskyOE2JluEGma9vd1M/Xvq2Jtt+fUmo3N6A7HxE2Q6ieV5PWZYYF1 0U24jm2YA==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:36846) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1gvPrC-0001Ti-J4; Sun, 17 Feb 2019 17:03:58 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.89) (envelope-from ) id 1gvPrA-0006Re-JZ; Sun, 17 Feb 2019 17:03:56 +0000 Date: Sun, 17 Feb 2019 17:03:56 +0000 From: Russell King - ARM Linux admin To: Andrew Lunn Cc: Florian Fainelli , Vivien Didelot , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH net] net: dsa: fix lockdep warning Message-ID: <20190217170356.4odo3q42l2ahm3zm@shell.armlinux.org.uk> References: <20190217164629.GE5968@lunn.ch> <20190217165140.3zyy24vi6mier2tt@shell.armlinux.org.uk> <20190217170024.GG5968@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190217170024.GG5968@lunn.ch> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Feb 17, 2019 at 06:00:24PM +0100, Andrew Lunn wrote: > On Sun, Feb 17, 2019 at 04:51:40PM +0000, Russell King - ARM Linux admin wrote: > > On Sun, Feb 17, 2019 at 05:46:29PM +0100, Andrew Lunn wrote: > > > On Sun, Feb 17, 2019 at 04:27:32PM +0000, Russell King wrote: > > > > ====================================================== > > > > WARNING: possible circular locking dependency detected > > > > 4.20.0+ #302 Not tainted > > > > ------------------------------------------------------ > > > > > > Hi Russell > > > > > > Thanks for turning this into a proper patch. I had just started to try > > > to reproduce this and confirm your fix. I will add a tested-by once i > > > do. > > > > Do you have a clearfog board? If so, just add: > > > > + interrupt-parent = <&gpio0>; > > + interrupts = <23 IRQ_TYPE_LEVEL_LOW>; > > > > to the DSA switch definitions in > > arch/arm/boot/dts/armada-388-clearfog.dts > > Hi Russell > > I'm using a different board, but i have a similar interrupt > configuration. I just expect that turning on LOCKDEP should be enough. > I don't think EPROBE_DEFFER is playing a part here. Yep, lockdep should be enough. In case it does matter, I have DSA built as modules here. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up