Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F521C43381 for ; Sun, 17 Feb 2019 22:19:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F141521773 for ; Sun, 17 Feb 2019 22:19:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="nkM4ELVr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726892AbfBQWTf (ORCPT ); Sun, 17 Feb 2019 17:19:35 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:43508 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726304AbfBQWTf (ORCPT ); Sun, 17 Feb 2019 17:19:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=D7Exn8sciVSDPmPzLtlBKB49qjQRTtF62pRlrnHwCYs=; b=nkM4ELVr8NV5stgGdebR3Hahg /nLJI3cv7R5g5q5v3Y0vDBBG9FQLXO4dVhcUP1YZWRfducUF8lnSxP5HazS8q1++ZIexMpE5Dvs9t TzodvUwPLHtI0/oFbuN6L9BC9HU16KoWKmp58+g6Fsxubz7h28xMWA8xphQsWikswdKPY3TBlbmDg HgLp33Xp4Bjlpf6KO6iD5BTZvibetcyTwiNFDbv994F3naVbRLwWhW5uUbewl/4IJs9hSXj23uH77 1EfdHQcCaJWxDY5TjqvCBVJf3Wfp2xM4OznhLxFPP2MzjmyTa6dB6J7PJMtsIWJ8VLBMXViM9kfox kwh6fdLOg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:51202) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1gvUmX-0002xS-Hp; Sun, 17 Feb 2019 22:19:29 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.89) (envelope-from ) id 1gvUmV-0006dB-5y; Sun, 17 Feb 2019 22:19:27 +0000 Date: Sun, 17 Feb 2019 22:19:27 +0000 From: Russell King - ARM Linux admin To: Florian Fainelli Cc: Andrew Lunn , Vivien Didelot , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: defautl to multicast and unicast flooding Message-ID: <20190217221927.5efgzd5buy6e4sg3@shell.armlinux.org.uk> References: <20190217142414.cjtmpi5y2l5rtdlb@shell.armlinux.org.uk> <20190217142716.gsrq5k2gnw3hsnhu@shell.armlinux.org.uk> <20190217163434.xo3ojbny4dnfqqwq@shell.armlinux.org.uk> <1a956aeb-f195-90ca-a5a5-fabac450feac@gmail.com> <20190217215827.2iavpy4xyh3viqup@shell.armlinux.org.uk> <39dbb59c-0c67-95f8-6703-d3e628d8c50e@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <39dbb59c-0c67-95f8-6703-d3e628d8c50e@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Feb 17, 2019 at 02:03:40PM -0800, Florian Fainelli wrote: > > > On 2/17/2019 1:58 PM, Russell King - ARM Linux admin wrote: > > On Sun, Feb 17, 2019 at 01:45:24PM -0800, Florian Fainelli wrote: > >> > >> > >> On 2/17/2019 8:34 AM, Russell King - ARM Linux admin wrote: > >>> On Sun, Feb 17, 2019 at 02:27:16PM +0000, Russell King - ARM Linux admin wrote: > >>>> On Sun, Feb 17, 2019 at 02:25:17PM +0000, Russell King wrote: > >>>>> Switches work by learning the MAC address for each attached station by > >>>>> monitoring traffic from each station. When a station sends a packet, > >>>>> the switch records which port the MAC address is connected to. > >>>>> > >>>>> With IPv4 networking, before communication commences with a neighbour, > >>>>> an ARP packet is broadcasted to all stations asking for the MAC address > >>>>> corresponding with the IPv4. The desired station responds with an ARP > >>>>> reply, and the ARP reply causes the switch to learn which port the > >>>>> station is connected to. > >>>>> > >>>>> With IPv6 networking, the situation is rather different. Rather than > >>>>> broadcasting ARP packets, a "neighbour solicitation" is multicasted > >>>>> rather than broadcasted. This multicast needs to reach the intended > >>>>> station in order for the neighbour to be discovered. > >>>>> > >>>>> Once a neighbour has been discovered, and entered into the sending > >>>>> stations neighbour cache, communication can restart at a point later > >>>>> without sending a new neighbour solicitation, even if the entry in > >>>>> the neighbour cache is marked as stale. This can be after the MAC > >>>>> address has expired from the forwarding cache of the DSA switch - > >>>>> when that occurs, there is a long pause in communication. > >>>>> > >>>>> Our DSA implementation for mv88e6xxx switches has defaulted to having > >>>>> multicast and unicast flooding disabled. As per the above description, > >>>>> this is fine for IPv4 networking, since the broadcasted ARP queries > >>>>> will be sent to and received by all stations on the same network. > >>>>> However, this breaks IPv6 very badly - blocking neighbour solicitations > >>>>> and later causing connections to stall. > >>>>> > >>>>> The defaults that the Linux bridge code expect from bridges are that > >>>>> unknown unicast frames and unknown multicast frames are flooded to > >>>>> all stations, which is at odds to the defaults adopted by our DSA > >>>>> implementation for mv88e6xxx switches. > >>>>> > >>>>> This commit enables by default flooding of both unknown unicast and > >>>>> unknown multicast frames. This means that mv88e6xxx DSA switches now > >>>>> behave as per the bridge(8) man page, and IPv6 works flawlessly through > >>>>> such a switch. > >>>> > >>>> Note that there is the open question whether this affects the case where > >>>> each port is used as a separate network interface: that case has not yet > >>>> been tested. > >>> > >>> I've checked with a mv88e6131 on the clearfog gt8k board. lan1 > >>> connected to my lan with plenty of traffic on, and configured as > >>> part of a bridge. lan2 connected to the zii board, but not part > >>> of the bridge. Monitoring lan2 from the zii board shows no traffic > >>> that was received from lan1. > >>> > >>> So it looks fine. > >> > >> With the current state whereby we do not have the necessary hooks to > >> perform filtering on non-bridged/standalone ports, this is entirely fine > >> indeed. > >> > >> In the future this is part of something I want to address because it is > >> IMHO highly undesirable to have non-bridged ports be flooded with > >> unknown multicast or unknown unicast for that matter because that makes > >> them deviate from a standard NIC interface. Unknown unicast is not > >> necessarily a low hanging fruit, but still, if we have switches capable > >> of filtering, we might as well make use of that. Of course, one > >> difficulty is that we must not break running tcpdump on those DSA slave > >> network interfaces. > > > > Sorry, I think you have the wrong end of the stick. > > > > For a non-bridged port, I am seeing _no_ traffic apart from that > > explicitly sent out through that port. In other words, there are > > _no_ flooded frames coming out of the non-bridged port. > > > > This patch appears to have no material effect on non-bridged ports. > > Presumably because that non-bridged port and the CPU port are part of > the same domain with only those 2 ports and that is what we want. > > Now what happens if say you have a station that sends multicast traffic > through that port to e.g.: 226.94.1.1, I bet that port happily sends > that multicast traffic to the CPU port with no filtering what so ever > and this ends-up being dropped in the network stack because there is a > socket look up failure there. IMHO unless you have a receiver/server on > that network interface on the DSA network interface and a matching > socket you should not be receiving that multicast traffic and the switch > should be filtering it. Since the network stack will call into > ndo_set_rx_mode() for those cases, we really just need to make that > multicast traffic known, instead of unknown to the switch. If the port is not bridged, then it's operating as network interface, and traffic to/from that port needs to be routed to the CPU port so that it appears as it would do from a real network interface. Doing anything else makes breaks the idea that you can use a set of DSA ports as individual interfaces and run anything but IPv4 non-multicast over them. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up