Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7992C43381 for ; Thu, 21 Feb 2019 03:38:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6BD22086D for ; Thu, 21 Feb 2019 03:38:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726137AbfBUDiw (ORCPT ); Wed, 20 Feb 2019 22:38:52 -0500 Received: from mga17.intel.com ([192.55.52.151]:27660 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726121AbfBUDiw (ORCPT ); Wed, 20 Feb 2019 22:38:52 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2019 19:38:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,393,1544515200"; d="scan'208";a="145244810" Received: from joy-optiplex-7040.sh.intel.com (HELO joy-OptiPlex-7040) ([10.239.13.9]) by fmsmga002.fm.intel.com with ESMTP; 20 Feb 2019 19:38:50 -0800 Date: Wed, 20 Feb 2019 22:33:36 -0500 From: Zhao Yan To: Zhenyu Wang Cc: intel-gvt-dev@lists.freedesktop.org, stable@vger.kernel.org Subject: Re: [PATCH v2] drm/i915/gvt: Fix MI_FLUSH_DW parsing with correct index check Message-ID: <20190221033336.GM16456@joy-OptiPlex-7040> References: <20190218064653.26020-1-zhenyuw@linux.intel.com> <20190220082504.15132-1-zhenyuw@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190220082504.15132-1-zhenyuw@linux.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Looks good to me. Reviewed-by: Yan Zhao On Wed, Feb 20, 2019 at 04:25:04PM +0800, Zhenyu Wang wrote: > When MI_FLUSH_DW post write hw status page in index mode, the index > value is in dword step and turned into address offset in cmd dword1. > As status page size is 4K, so can't exceed that. > > This fixed upper bound check in cmd parser code which incorrectly > stopped VM for reason of invalid MI_FLUSH_DW write index. > > v2: > - Fix upper bound as 4K page size because index value is address offset. > > Fixes: be1da7070aea ("drm/i915/gvt: vGPU command scanner") > Cc: stable@vger.kernel.org # v4.10+ > Cc: "Zhao, Yan Y" > Signed-off-by: Zhenyu Wang > --- > drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c > index 35b4ec3f7618..3592d04c33b2 100644 > --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c > +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c > @@ -1441,7 +1441,7 @@ static inline int cmd_address_audit(struct parser_exec_state *s, > } > > if (index_mode) { > - if (guest_gma >= I915_GTT_PAGE_SIZE / sizeof(u64)) { > + if (guest_gma >= I915_GTT_PAGE_SIZE) { > ret = -EFAULT; > goto err; > } > -- > 2.20.1 >