Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 284FAC43381 for ; Thu, 21 Feb 2019 12:23:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E14C22086C for ; Thu, 21 Feb 2019 12:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550751827; bh=6rUtgbLR8Y/YSz6jN6GKaGh8ot8q4j4KNDyo/kn0Bps=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zY1saafDaqA1ykLI7G4aJjxPxu3ctKf+B7SDfuRr5BPQSfNpfqsL8MCe2zs+2oGDg RPW6lxz7ZeOwZ9M7x7QcGzM/CQsjrMkCeqasmZ7QcjqmEnSECtilZcSV9nbOwGZMk8 KxiZxhP6PIhPJab8r3pCQDVXgxCK20BO1KCrQR5M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725831AbfBUMXq (ORCPT ); Thu, 21 Feb 2019 07:23:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:50626 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725814AbfBUMXq (ORCPT ); Thu, 21 Feb 2019 07:23:46 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5BEB62084D; Thu, 21 Feb 2019 12:23:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550751825; bh=6rUtgbLR8Y/YSz6jN6GKaGh8ot8q4j4KNDyo/kn0Bps=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lcp2xymSY933+7GvfCKOmn6FPa9lgfLzOJzC0TgWltjgUXUvXEW/FyK2xdMU5/2Bg kBuDLnqRTxb+k2hu1cAY/G2PCVTHHBMFAlj5H7MsfJ+DWW0JE9tupdcjwLZeKAs5ka WMs1e/i3u88vaHWv0spJVCaGeP5yUbkYxiqnqmlc= Date: Thu, 21 Feb 2019 13:23:42 +0100 From: Greg KH To: Scott Mayhew Cc: stable@vger.kernel.org, bfields@redhat.com Subject: Re: [PATCH 4.19] sunrpc: fix 4 more call sites that were using stack memory with a scatterlist Message-ID: <20190221122342.GA12382@kroah.com> References: <20190219193627.15619-1-smayhew@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190219193627.15619-1-smayhew@redhat.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Feb 19, 2019 at 02:36:27PM -0500, Scott Mayhew wrote: > (cherry picked from commit e7afe6c1d486b516ed586dcc10b3e7e3e85a9c2b) > > While trying to reproduce a reported kernel panic on arm64, I discovered > that AUTH_GSS basically doesn't work at all with older enctypes on arm64 > systems with CONFIG_VMAP_STACK enabled. It turns out there still a few > places using stack memory with scatterlists, causing krb5_encrypt() and > krb5_decrypt() to produce incorrect results (or a BUG if CONFIG_DEBUG_SG > is enabled). > > Tested with cthon on v4.0/v4.1/v4.2 with krb5/krb5i/krb5p using > des3-cbc-sha1 and arcfour-hmac-md5. > > Signed-off-by: Scott Mayhew > Cc: stable@vger.kernel.org > Signed-off-by: J. Bruce Fields > > Conflicts: > net/sunrpc/auth_gss/gss_krb5_seqnum.c These two lines are not needed :) Anyway, thanks for the backport, now queued up for both trees. greg k-h