Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75DC9C43381 for ; Thu, 21 Feb 2019 15:58:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 438E92084F for ; Thu, 21 Feb 2019 15:58:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550764697; bh=jnfblnvzpcOe8w+JDNqPpjNAwy9zczrur4oLKML/PzE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=bBsB5miINlPEq8zBSkLlmOggVM5JlgPag35+/ewVqaN37D0iK/Mc+IWi97hzj0a5/ N3qJXSsC1I89VrSWTeqxQOIpDn2ieKQNSBS2OcFax9UdWAs0STSx66rY92/qg2TASm WksPOnZRci3NF8jEyPRtPXSClAor0tggfSGUVOCc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726527AbfBUP6Q (ORCPT ); Thu, 21 Feb 2019 10:58:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:51002 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbfBUP6Q (ORCPT ); Thu, 21 Feb 2019 10:58:16 -0500 Received: from devbox (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A9C902083E; Thu, 21 Feb 2019 15:58:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550764695; bh=jnfblnvzpcOe8w+JDNqPpjNAwy9zczrur4oLKML/PzE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lB/UEbzdYv7UjQdMXTesjehHmr4YKHz12hmAGSLVY+t8aHjm6WbrMaPGBPLFFbK8p FJAaoN+tyquS5G7jPZ93qf0DDuGPAFGygmgRUPeX4tpgGOPgYjqkUhi1K72wRFEXI6 c0/0GZowHESpxUTaG/kQdPBGbJaei0ggmtNqPSHk= Date: Fri, 22 Feb 2019 00:58:12 +0900 From: Masami Hiramatsu To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Ingo Molnar , Andrew Morton , stable@vger.kernel.org, Changbin Du Subject: Re: [PATCH 1/2 v2] kprobe: Do not use uaccess functions to access kernel memory that can fault Message-Id: <20190222005812.04c5940c693b14cfdbe6ede7@kernel.org> In-Reply-To: <20190221093625.56afccd2@gandalf.local.home> References: <20190215174712.372898450@goodmis.org> <20190215174945.557218316@goodmis.org> <20190221165252.4a9033b3348f30f9d973dbc4@kernel.org> <20190221093625.56afccd2@gandalf.local.home> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, 21 Feb 2019 09:36:25 -0500 Steven Rostedt wrote: > On Thu, 21 Feb 2019 16:52:52 +0900 > Masami Hiramatsu wrote: > > > Basically OK to me. > > Could you use probe_kernel_read() in this context, since probe_mem_read() is a > > wrapper function for template code. > > > > With that change, > > > > Acked-by: Masami Hiramatsu > > This already hit Linus's tree. I was able to reproduce the crash, so I > streamlined it. I should have still pushed more for your ack first. > Sorry about that. Oh, never mind. That seems urgent issue for kprobe event. Thank you very much for fixing it! > For some reason, I thought the change was in the generic probe code, > and accepted the probe_mem_read(). Anyway, did you want to send a patch > to change it to probe_kernel_read(), for the merge window? No problem. > > And for the long term, I need to find more efficient (or smarter) way to do it, > > like strnlen_user() does. > > Agreed. Thank you, -- Masami Hiramatsu