From: Marc Zyngier Subject: Re: [PATCH] KVM: arm64: Fix architecturally invalid reset value for FPEXC32_EL2 Date: Fri, 22 Feb 2019 10:01:03 +0000 Message-ID: <20190222100103.03fb773d@why.wild-wind.fr.eu.org> References: <1550749352-2315-1-git-send-email-Dave.Martin@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1550749352-2315-1-git-send-email-Dave.Martin@arm.com> Sender: stable-owner@vger.kernel.org To: Dave Martin Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Julien Thierry , James Morse , Suzuki K Poulose , stable@vger.kernel.org, Christoffer Dall List-Id: kvmarm@lists.cs.columbia.edu On Thu, 21 Feb 2019 11:42:32 +0000 Dave Martin wrote: > Due to what looks like a typo dating back to the original addition > of FPEXC32_EL2 handling, KVM currently initialises this register to > an architecturally invalid value. > > As a result, the VECITR field (RES1) in bits [10:8] is initialised > with 0, and the two reserved (RES0) bits [6:5] are initialised with > 1. (In the Common VFP Subarchitecture as specified by ARMv7-A, > these two bits were IMP DEF. ARMv8-A removes them.) > > This patch changes the reset value from 0x70 to 0x700, which > reflects the architectural constraints and is presumably what was > originally intended. > > Cc: # 4.12.x- > Cc: Marc Zyngier > Cc: Christoffer Dall > Fixes: 62a89c44954f ("arm64: KVM: 32bit handling of coprocessor traps") > Signed-off-by: Dave Martin Applied to -next. Thanks, M. -- Without deviation from the norm, progress is not possible.