From: juerg.haefliger@canonical.com (Juerg Haefliger) Date: Fri, 22 Feb 2019 21:52:36 +0100 Subject: [RESEND PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf In-Reply-To: <20190222205237.606-1-juergh@canonical.com> References: <20190222091021.10178-1-juergh@canonical.com> <20190222205237.606-1-juergh@canonical.com> Message-ID: <20190222205237.606-2-juergh@canonical.com> Content-Type: text/plain; charset="UTF-8" Message-ID: <20190222205236.EwzD-NrrSH736wInbJyzY1QjcAyaj83PfnkijpGv2x8@z> echo -e is not POSIX. Depending on what /bin/sh is, we can get incorrect output like: $ -e -n [1] Basic trace file check $ -e [PASS] Fix that by using printf instead. Acked-by: Steven Rostedt (VMware) Acked-by: Masami Hiramatsu Signed-off-by: Juerg Haefliger --- tools/testing/selftests/ftrace/ftracetest | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest index fc755e1b50f1..20c9c0ad8682 100755 --- a/tools/testing/selftests/ftrace/ftracetest +++ b/tools/testing/selftests/ftrace/ftracetest @@ -173,8 +173,13 @@ strip_esc() { } prlog() { # messages - echo -e "$@" - [ "$LOG_FILE" ] && echo -e "$@" | strip_esc >> $LOG_FILE + newline="\n" + if [ "$1" = "-n" ] ; then + newline= + shift + fi + printf "$*$newline" + [ "$LOG_FILE" ] && printf "$*$newline" | strip_esc >> $LOG_FILE } catlog() { #file cat $1 -- 2.19.1