Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34BB9C43381 for ; Wed, 27 Feb 2019 14:12:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3AA22133D for ; Wed, 27 Feb 2019 14:12:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="cYr9hjOz"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="GgbQHwoS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729323AbfB0OME (ORCPT ); Wed, 27 Feb 2019 09:12:04 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:45587 "EHLO wout2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729136AbfB0OME (ORCPT ); Wed, 27 Feb 2019 09:12:04 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 4281D2DEE; Wed, 27 Feb 2019 09:12:03 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 27 Feb 2019 09:12:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm3; bh=V yQp79kYsHxfGqKB8/OdrarAixSyYAIZoDJrGLQ6SjY=; b=cYr9hjOzCfWi+gFHs aQ9PHDspXi7B7QnwhP16QLpDE4hVzZjzsBNYuxao7wmqXOHtr9g1Xd1/CiZqcwGt wB9+YWrOaEufLzSa/kxDMIhJ7rV+Bsr9Ldr68zxGjMWljXTzbEikhnc+0iTCM9Vs L6LJV5aq8ECd5OamgLffqcNU4Adw16jhQ0AER6eK6FhjRmHwlyTJT+E2ya/dmNGV dGeYmgPtJ2bHiHjo1dU+7HuBqoOsEsgqwc7DqxoLQnR1J4CHYBl0meT0ti2uUMBf e0md3TB9kwEOvDsSj73cOmys9gwIWV0ybHyk3ajPM2RShQhAFwJ5tOFIyN/lW9E9 9uMmg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=VyQp79kYsHxfGqKB8/OdrarAixSyYAIZoDJrGLQ6S jY=; b=GgbQHwoSX3Uhllt24i/sq2lr9mo+vI0nEBmdaJrR/0ZVjIpmZGrhB9Wnr zGyiCg2hioGJzHutBDgDaovo7Qr7WQC3umQOaMkCYnKT/EJ1PhUr1Ei0YOTCdmcl X3vi8OAZxylZCuJiue5M4CJeJjJXKbdluNvBIM+9+S5bwq/HpaPeWC+W/lLc5Axe pujW32u8uU/Ze/z/iKz/5xXKpruwmXDnTVl/ePmzO2YVFqI4cAsOtoFOiEu8yz1b 6VoVyeTfW7/BlIvz3sI6jnSE0BEL9v4SJonx5blnDBwrXGv5UzRDy0NkKgfPtgFX 28gZx10fx08K17jOcgJtegKN5N5HA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrvddugdeivdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggugfgjfgesthekredttderudenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecukfhppeekfedrkeeirdekledrud dtjeenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhmnecu vehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (5356596b.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id C39E9E4A34; Wed, 27 Feb 2019 09:12:01 -0500 (EST) Date: Wed, 27 Feb 2019 15:11:58 +0100 From: Greg KH To: Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= Cc: stable@vger.kernel.org, Johannes Berg Subject: Re: [PATCH for-4.19] mac80211: Change sk_pacing_shift to 7 Message-ID: <20190227141158.GA10320@kroah.com> References: <20190227100807.4015-1-toke@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190227100807.4015-1-toke@redhat.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Feb 27, 2019 at 11:08:07AM +0100, Toke Høiland-Jørgensen wrote: > commit 5c14a4d05f68415af9e41a4e667d1748d41d1baf upstream. > > When we did the original tests for the optimal value of sk_pacing_shift, we > came up with 6 ms of buffering as the default. Sadly, 6 is not a power of > two, so when picking the shift value I erred on the size of less buffering > and picked 4 ms instead of 8. This was probably wrong; those 2 ms of extra > buffering makes a larger difference than I thought. > > So, change the default pacing shift to 7, which corresponds to 8 ms of > buffering. The point of diminishing returns really kicks in after 8 ms, and > so having this as a default should cut down on the need for extensive > per-device testing and overrides needed in the drivers. > > Stable backport moves the change to where the value was set before the > addition of per-device override support in 4.20. Now queued up, thanks. greg k-h