From: Dan Carpenter Date: Thu, 28 Feb 2019 13:34:36 +0000 Subject: Re: [PATCH] cifs: Clean up an error code in cifs_root_iget() Message-Id: <20190228133435.GB9806@kadam> List-Id: References: <20190228052659.GA3253@kadam> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Steve French Cc: Steve French , CIFS , kernel-janitors , samba-technical On Wed, Feb 27, 2019 at 11:44:14PM -0600, Steve French wrote: > Won't that change behavior and cause the success case (server returned > 0, and does support POSIX and &inode pointer is ok) to now return > -EINVAL. > You're right. I'm really sorry. I don't know why I misread the code... Also looking at it now, this was a false positive in Smatch. I have been working on that code in the past couple days and I don't have the warning in my latest build. regards, dan carpenter