Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DCCFC43381 for ; Fri, 1 Mar 2019 03:06:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2EA8520830 for ; Fri, 1 Mar 2019 03:06:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="H6oKb6By" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728052AbfCADGy (ORCPT ); Thu, 28 Feb 2019 22:06:54 -0500 Received: from mail-qt1-f194.google.com ([209.85.160.194]:33004 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726088AbfCADGy (ORCPT ); Thu, 28 Feb 2019 22:06:54 -0500 Received: by mail-qt1-f194.google.com with SMTP id z39so26239244qtz.0 for ; Thu, 28 Feb 2019 19:06:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=e+H9KQsviFXY30fCs9aE7UhmYLY4RF0u5FnCnoLfm9g=; b=H6oKb6Byn3cUP7PaO4jZ1iBGw4Io1bDR2v75HofzVq2+g1kQEk6oELwN8adWFpfFMx rTjF5B2mA774LqguCUw4EDU94L/bX4U5QjlsSBnGrM3wfo+MlGc+myIyj6hMGtl8seOO jRy/vUzq9SYiDgZ+bTjZD138/mzcnP3ZfdmC/1BtdahOW5hfGzP8a20KWXfZLwNjKiO9 tAw5lt8aZwR99ePM5/YjKtnE47wihDcP5SgUKIVF+o+OjtjypN5p5kDFAP+euTbDR/5A fPbL3OYHmauz7RVAl8Rk2YKSmY5MHANuqgW7jToYY+p5Yj1QMlyq9jI0dFYhPmZ0cTzS ZCdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=e+H9KQsviFXY30fCs9aE7UhmYLY4RF0u5FnCnoLfm9g=; b=jJn2wd/7XJSku8U82MUxQI4pMy0WU13DyA3gpFc1mIp+YksgAOjDqgLfXoIRVB6A3A 9TRpv/GuWeRVk75yPgbo0SAgDo/fFre68RVTrSk5sRwgLrSXwK8e5sStwzgSF8BLj49j sTHf/TMxv3eps2XJiz6bYEc0VXeT8uBz+bUXeDMNczCImS+9wAMYjr3rRMGnYb8sHBR3 KOMc6Tvi0uoB8xDkdfwrXjg/+BCUOqmEhLqQAFxE7afhja7i4hk6TjUYMfDuUo00Y4sw fq75cYifLCNai6xEKcyNRvaOoPLHxxcUaRIcAgkyY/a3ePxfWBZ0V6fVtrnh9FJEHLek 3SvQ== X-Gm-Message-State: APjAAAULOZ0aM49gNu5ZFpsPtrzT27razxzkDVUgUsFzx6BV4IW1VeC5 H7XSTb9kxTai+Y45s0OsZ3jTD/nww7w= X-Google-Smtp-Source: APXvYqwSXA9nhp4doWUP3aAzDLZeXSHmx9VVCMU/H2ZUcw6v3EvUHEXyHJ0g/KyhGChAhFqn5+A08Q== X-Received: by 2002:ac8:1a6e:: with SMTP id q43mr2083771qtk.69.1551409613835; Thu, 28 Feb 2019 19:06:53 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id o3sm12351126qte.55.2019.02.28.19.06.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Feb 2019 19:06:53 -0800 (PST) Date: Thu, 28 Feb 2019 19:06:45 -0800 From: Jakub Kicinski To: Stephen Hemminger Cc: netdev@vger.kernel.org Subject: Re: [RFC v2 3/6] i40e: use extack for bpf errors Message-ID: <20190228190645.34c21d8b@cakuba.netronome.com> In-Reply-To: <20190228215441.28275-4-stephen@networkplumber.org> References: <20190228215441.28275-1-stephen@networkplumber.org> <20190228215441.28275-4-stephen@networkplumber.org> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 28 Feb 2019 13:54:38 -0800, Stephen Hemminger wrote: > @@ -12140,12 +12144,14 @@ static int i40e_xdp(struct net_device *dev, > struct i40e_netdev_priv *np = netdev_priv(dev); > struct i40e_vsi *vsi = np->vsi; > > - if (vsi->type != I40E_VSI_MAIN) > + if (vsi->type != I40E_VSI_MAIN) { > + NL_SET_ERR_MSG_MOD(xdp->extack, "XDP not allowed on VF"); Is that right? Intel tends to have separate drivers for VFs, I think the i40evf got renamed to iavf. I think it would be a good idea to CC maintainers on the driver patches. > return -EINVAL; > + } >