Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E74D8C43381 for ; Sun, 3 Mar 2019 16:02:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB70E206DD for ; Sun, 3 Mar 2019 16:02:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="k6IIMXf/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726382AbfCCP6V (ORCPT ); Sun, 3 Mar 2019 10:58:21 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:44989 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726374AbfCCP6U (ORCPT ); Sun, 3 Mar 2019 10:58:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MR/9+GcR6M0qMB2cu3S/TEZ4mrP1J7c6oCYnElGKiwI=; b=k6IIMXf/JdN34Vj8eX7W9Yivg3 WuX/v0xUsa0ijufxA2llsO4cRA+VFAdj9W74RIVU+bUPmzVV39MU7elFg8Cp9otalt9c9gbFYNqXr XFAjxN6mHopOLHnB1IRu7VCNUn84vEOwaJMRivIu7QYotKGwnqZkUxjaKpon+7NJv0oQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1h0TVJ-0003Ma-An; Sun, 03 Mar 2019 16:58:17 +0100 Date: Sun, 3 Mar 2019 16:58:17 +0100 From: Andrew Lunn To: Heiner Kallweit Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next 4/5] net: phy: don't export gen10g_read_status Message-ID: <20190303155817.GF11621@lunn.ch> References: <7c0ef5fe-2f4f-d365-a028-d96179e9fab4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Mar 02, 2019 at 05:15:56PM +0100, Heiner Kallweit wrote: > gen10g_read_status is deprecated, therefore stop exporting it. > We don't want to encourage anybody to use it. Hi Florian, Heiner We should consider what we want to do with the generic 10G driver. Can a c45 PHY be expected to work using a generic driver? We know 1000BaseT is not going to work, that needs vendor registers. But the rest might? I think we either need to drop the generic 10G driver, or make it use all the new code which has been added over the last month. Andrew