Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFD08C43381 for ; Mon, 4 Mar 2019 15:52:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C0B3E206B8 for ; Mon, 4 Mar 2019 15:52:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="eEKe6BpN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727092AbfCDPwI (ORCPT ); Mon, 4 Mar 2019 10:52:08 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:45927 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726552AbfCDPwI (ORCPT ); Mon, 4 Mar 2019 10:52:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AnTIOtoEvE5qOaqFxyud8TbMG+p7zKKRQcjeqXk1+uc=; b=eEKe6BpNMSf8ZWKqitKn51PxgX upekztm1EEgDVY6D12r/dl+d7HWrMJ3IwAQx3jmeZ9jyS8l3P8RJoUD3sCk0fzbwdDdcv4rjeRQ2o GygOTDMfTYg774BkqbUOG/VoS+vjvfBqs287u32fJ9nksCIX7nupWb5WcdeUSYLy95yU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1h0pso-0005JP-Hb; Mon, 04 Mar 2019 16:52:02 +0100 Date: Mon, 4 Mar 2019 16:52:02 +0100 From: Andrew Lunn To: Jose Abreu Cc: Heiner Kallweit , Florian Fainelli , David Miller , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next 4/5] net: phy: don't export gen10g_read_status Message-ID: <20190304155202.GE18622@lunn.ch> References: <7c0ef5fe-2f4f-d365-a028-d96179e9fab4@gmail.com> <20190303155817.GF11621@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 04, 2019 at 03:26:56PM +0000, Jose Abreu wrote: > On 3/3/2019 4:12 PM, Heiner Kallweit wrote: > > Not sure whether anybody is relying on the gen10g driver currently. > > I do for stmmac (code not upstreamed yet) and it works okay. For > debug purposes I ended up writing my own phy driver but this is a > plain copy of Generic 10G driver + reset and suspend/resume > callbacks. I strongly suggest you write a proper PHY driver. There are horrible assumptions in the gen10g, like only 10G support. In order to make it more general purpose, asking the PHY what it actually supports, etc might break your use case. We then need to decided, is that a regression, are we forced to leave it alone, or since your code is not yet upstream, it is not a regression, and we are O.K. breaking it, in order to make upstream code better? Andrew