Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2423C43381 for ; Wed, 6 Mar 2019 11:04:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD0B620675 for ; Wed, 6 Mar 2019 11:04:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730257AbfCFLEP (ORCPT ); Wed, 6 Mar 2019 06:04:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58452 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729177AbfCFLEP (ORCPT ); Wed, 6 Mar 2019 06:04:15 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0ADE4307D867; Wed, 6 Mar 2019 11:04:15 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-121.ams2.redhat.com [10.36.116.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 08CE05C28C; Wed, 6 Mar 2019 11:04:12 +0000 (UTC) From: Thomas Haller To: netdev@vger.kernel.org Cc: stephen@networkplumber.org, Thomas Haller Subject: [PATCH iproute2] iprule: fix printing hint about unresolved iifname and oifname Date: Wed, 6 Mar 2019 12:04:00 +0100 Message-Id: <20190306110400.25252-1-thaller@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Wed, 06 Mar 2019 11:04:15 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org # ip rule add priority 10 iif eth1 goto 10000 protocol 10 was displayed as 10: from all iif eth1 [detached] goto 10000unresolved proto mrt now: 10: from all iif eth1 [detached] goto 10000 [unresolved] proto mrt Fixes: 0dd4ccc56c0e ("iprule: add json support") Signed-off-by: Thomas Haller --- ip/iprule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iprule.c b/ip/iprule.c index 4e9437de..0bd4c636 100644 --- a/ip/iprule.c +++ b/ip/iprule.c @@ -455,7 +455,7 @@ int print_rule(struct nlmsghdr *n, void *arg) print_string(PRINT_ANY, "goto", "goto %s", "none"); if (frh->flags & FIB_RULE_UNRESOLVED) - print_null(PRINT_ANY, "unresolved", "unresolved", NULL); + print_null(PRINT_ANY, "unresolved", " [unresolved]", NULL); } else if (frh->action == FR_ACT_NOP) { print_null(PRINT_ANY, "nop", "nop", NULL); } else if (frh->action != FR_ACT_TO_TBL) { -- 2.20.1