From: Evan Quan Subject: [PATCH 2/2] drm/amdgpu: drop unnecessary dereference Date: Mon, 11 Mar 2019 12:30:46 +0800 Message-ID: <20190311043046.10184-2-evan.quan@amd.com> References: <20190311043046.10184-1-evan.quan@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190311043046.10184-1-evan.quan-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Alexander.Deucher-5C7GfCeVMHo@public.gmane.org, xinhui.pan-5C7GfCeVMHo@public.gmane.org, Evan Quan SXQncyB1bm5lY2Vzc2FyeSBhbmQgY29uZnVzaW5nLgoKQ2hhbmdlLUlkOiBJNzdmZTU0YTEwOGI3 ZWUyMDMxODUxYjNlMTFkNjNjNGZiNzRjMGQ0MwpTaWduZWQtb2ZmLWJ5OiBFdmFuIFF1YW4gPGV2 YW4ucXVhbkBhbWQuY29tPgotLS0KIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dmeF92OV8w LmMgIHwgMjYgKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0KIGRyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2dtY192OV8wLmMgIHwgMjYgKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0KIGRyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L3NkbWFfdjRfMC5jIHwgMjYgKysrKysrKysrKysrKy0tLS0t LS0tLS0tLS0KIDMgZmlsZXMgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKSwgMzkgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ2Z4X3Y5XzAuYyBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dmeF92OV8wLmMKaW5kZXggM2ZiNzJiZjQyMGUw Li4zMTk5NmQ0NDg4MTcgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dm eF92OV8wLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ2Z4X3Y5XzAuYwpAQCAt MzUzMiw3ICszNTMyLDcgQEAgc3RhdGljIGludCBnZnhfdjlfMF9wcm9jZXNzX3Jhc19kYXRhX2Ni KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LAogc3RhdGljIGludCBnZnhfdjlfMF9lY2NfbGF0 ZV9pbml0KHZvaWQgKmhhbmRsZSkKIHsKIAlzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiA9IChz dHJ1Y3QgYW1kZ3B1X2RldmljZSAqKWhhbmRsZTsKLQlzdHJ1Y3QgcmFzX2NvbW1vbl9pZiAqKnJh c19pZiA9ICZhZGV2LT5nZngucmFzX2lmOworCXN0cnVjdCByYXNfY29tbW9uX2lmICpyYXNfaWYg PSBhZGV2LT5nZngucmFzX2lmOwogCXN0cnVjdCByYXNfaWhfaWYgaWhfaW5mbyA9IHsKIAkJLmNi ID0gZ2Z4X3Y5XzBfcHJvY2Vzc19yYXNfZGF0YV9jYiwKIAl9OwpAQCAtMzU1MywyMSArMzU1Mywy MSBAQCBzdGF0aWMgaW50IGdmeF92OV8wX2VjY19sYXRlX2luaXQodm9pZCAqaGFuZGxlKQogCQly ZXR1cm4gMDsKIAl9CiAKLQlpZiAoKnJhc19pZikKKwlpZiAocmFzX2lmKQogCQlnb3RvIHJlc3Vt ZTsKIAotCSpyYXNfaWYgPSBrbWFsbG9jKHNpemVvZigqKnJhc19pZiksIEdGUF9LRVJORUwpOwot CWlmICghKnJhc19pZikKKwlyYXNfaWYgPSBrbWFsbG9jKHNpemVvZigqcmFzX2lmKSwgR0ZQX0tF Uk5FTCk7CisJaWYgKCFyYXNfaWYpCiAJCXJldHVybiAtRU5PTUVNOwogCi0JKipyYXNfaWYgPSBy YXNfYmxvY2s7CisJKnJhc19pZiA9IHJhc19ibG9jazsKIAotCXIgPSBhbWRncHVfcmFzX2ZlYXR1 cmVfZW5hYmxlKGFkZXYsICpyYXNfaWYsIDEpOworCXIgPSBhbWRncHVfcmFzX2ZlYXR1cmVfZW5h YmxlKGFkZXYsIHJhc19pZiwgMSk7CiAJaWYgKHIpCiAJCWdvdG8gZmVhdHVyZTsKIAotCWloX2lu Zm8uaGVhZCA9ICoqcmFzX2lmOwotCWZzX2luZm8uaGVhZCA9ICoqcmFzX2lmOworCWloX2luZm8u aGVhZCA9ICpyYXNfaWY7CisJZnNfaW5mby5oZWFkID0gKnJhc19pZjsKIAogCXIgPSBhbWRncHVf cmFzX2ludGVycnVwdF9hZGRfaGFuZGxlcihhZGV2LCAmaWhfaW5mbyk7CiAJaWYgKHIpCkBAIC0z NTg3LDE2ICszNTg3LDE2IEBAIHN0YXRpYyBpbnQgZ2Z4X3Y5XzBfZWNjX2xhdGVfaW5pdCh2b2lk ICpoYW5kbGUpCiAKIAlyZXR1cm4gMDsKIGlycToKLQlhbWRncHVfcmFzX3N5c2ZzX3JlbW92ZShh ZGV2LCAqcmFzX2lmKTsKKwlhbWRncHVfcmFzX3N5c2ZzX3JlbW92ZShhZGV2LCByYXNfaWYpOwog c3lzZnM6Ci0JYW1kZ3B1X3Jhc19kZWJ1Z2ZzX3JlbW92ZShhZGV2LCAqcmFzX2lmKTsKKwlhbWRn cHVfcmFzX2RlYnVnZnNfcmVtb3ZlKGFkZXYsIHJhc19pZik7CiBkZWJ1Z2ZzOgogCWFtZGdwdV9y YXNfaW50ZXJydXB0X3JlbW92ZV9oYW5kbGVyKGFkZXYsICZpaF9pbmZvKTsKIGludGVycnVwdDoK LQlhbWRncHVfcmFzX2ZlYXR1cmVfZW5hYmxlKGFkZXYsICpyYXNfaWYsIDApOworCWFtZGdwdV9y YXNfZmVhdHVyZV9lbmFibGUoYWRldiwgcmFzX2lmLCAwKTsKIGZlYXR1cmU6Ci0Ja2ZyZWUoKnJh c19pZik7Ci0JKnJhc19pZiA9IE5VTEw7CisJa2ZyZWUocmFzX2lmKTsKKwlyYXNfaWYgPSBOVUxM OwogCXJldHVybiAtRUlOVkFMOwogfQogCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9nbWNfdjlfMC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ21jX3Y5XzAu YwppbmRleCA1ZDFhYzUzZjdkZGIuLjIyOWU2MTRkMWI3NiAxMDA2NDQKLS0tIGEvZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvZ21jX3Y5XzAuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9nbWNfdjlfMC5jCkBAIC03MTQsNyArNzE0LDcgQEAgc3RhdGljIGludCBnbWNfdjlfMF9h bGxvY2F0ZV92bV9pbnZfZW5nKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQogc3RhdGljIGlu dCBnbWNfdjlfMF9lY2NfbGF0ZV9pbml0KHZvaWQgKmhhbmRsZSkKIHsKIAlzdHJ1Y3QgYW1kZ3B1 X2RldmljZSAqYWRldiA9IChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqKWhhbmRsZTsKLQlzdHJ1Y3Qg cmFzX2NvbW1vbl9pZiAqKnJhc19pZiA9ICZhZGV2LT5nbWMucmFzX2lmOworCXN0cnVjdCByYXNf Y29tbW9uX2lmICpyYXNfaWYgPSBhZGV2LT5nbWMucmFzX2lmOwogCXN0cnVjdCByYXNfaWhfaWYg aWhfaW5mbyA9IHsKIAkJLmNiID0gZ21jX3Y5XzBfcHJvY2Vzc19yYXNfZGF0YV9jYiwKIAl9OwpA QCAtNzM1LDIxICs3MzUsMjEgQEAgc3RhdGljIGludCBnbWNfdjlfMF9lY2NfbGF0ZV9pbml0KHZv aWQgKmhhbmRsZSkKIAkJcmV0dXJuIDA7CiAJfQogCS8qIGhhbmRsZSByZXN1bWUgcGF0aC4gKi8K LQlpZiAoKnJhc19pZikKKwlpZiAocmFzX2lmKQogCQlnb3RvIHJlc3VtZTsKIAotCSpyYXNfaWYg PSBrbWFsbG9jKHNpemVvZigqKnJhc19pZiksIEdGUF9LRVJORUwpOwotCWlmICghKnJhc19pZikK KwlyYXNfaWYgPSBrbWFsbG9jKHNpemVvZigqcmFzX2lmKSwgR0ZQX0tFUk5FTCk7CisJaWYgKCFy YXNfaWYpCiAJCXJldHVybiAtRU5PTUVNOwogCi0JKipyYXNfaWYgPSByYXNfYmxvY2s7CisJKnJh c19pZiA9IHJhc19ibG9jazsKIAotCXIgPSBhbWRncHVfcmFzX2ZlYXR1cmVfZW5hYmxlKGFkZXYs ICpyYXNfaWYsIDEpOworCXIgPSBhbWRncHVfcmFzX2ZlYXR1cmVfZW5hYmxlKGFkZXYsIHJhc19p ZiwgMSk7CiAJaWYgKHIpCiAJCWdvdG8gZmVhdHVyZTsKIAotCWloX2luZm8uaGVhZCA9ICoqcmFz X2lmOwotCWZzX2luZm8uaGVhZCA9ICoqcmFzX2lmOworCWloX2luZm8uaGVhZCA9ICpyYXNfaWY7 CisJZnNfaW5mby5oZWFkID0gKnJhc19pZjsKIAogCXIgPSBhbWRncHVfcmFzX2ludGVycnVwdF9h ZGRfaGFuZGxlcihhZGV2LCAmaWhfaW5mbyk7CiAJaWYgKHIpCkBAIC03NjksMTYgKzc2OSwxNiBA QCBzdGF0aWMgaW50IGdtY192OV8wX2VjY19sYXRlX2luaXQodm9pZCAqaGFuZGxlKQogCiAJcmV0 dXJuIDA7CiBpcnE6Ci0JYW1kZ3B1X3Jhc19zeXNmc19yZW1vdmUoYWRldiwgKnJhc19pZik7CisJ YW1kZ3B1X3Jhc19zeXNmc19yZW1vdmUoYWRldiwgcmFzX2lmKTsKIHN5c2ZzOgotCWFtZGdwdV9y YXNfZGVidWdmc19yZW1vdmUoYWRldiwgKnJhc19pZik7CisJYW1kZ3B1X3Jhc19kZWJ1Z2ZzX3Jl bW92ZShhZGV2LCByYXNfaWYpOwogZGVidWdmczoKIAlhbWRncHVfcmFzX2ludGVycnVwdF9yZW1v dmVfaGFuZGxlcihhZGV2LCAmaWhfaW5mbyk7CiBpbnRlcnJ1cHQ6Ci0JYW1kZ3B1X3Jhc19mZWF0 dXJlX2VuYWJsZShhZGV2LCAqcmFzX2lmLCAwKTsKKwlhbWRncHVfcmFzX2ZlYXR1cmVfZW5hYmxl KGFkZXYsIHJhc19pZiwgMCk7CiBmZWF0dXJlOgotCWtmcmVlKCpyYXNfaWYpOwotCSpyYXNfaWYg PSBOVUxMOworCWtmcmVlKHJhc19pZik7CisJcmFzX2lmID0gTlVMTDsKIAlyZXR1cm4gLUVJTlZB TDsKIH0KIApkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvc2RtYV92NF8w LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9zZG1hX3Y0XzAuYwppbmRleCAzYWM1YWJl OTM3ZjQuLjUyMTIxODA1MzQ3NyAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvc2RtYV92NF8wLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvc2RtYV92NF8w LmMKQEAgLTE1MDEsNyArMTUwMSw3IEBAIHN0YXRpYyBpbnQgc2RtYV92NF8wX3Byb2Nlc3NfcmFz X2RhdGFfY2Ioc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsCiBzdGF0aWMgaW50IHNkbWFfdjRf MF9sYXRlX2luaXQodm9pZCAqaGFuZGxlKQogewogCXN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2 ID0gKHN0cnVjdCBhbWRncHVfZGV2aWNlICopaGFuZGxlOwotCXN0cnVjdCByYXNfY29tbW9uX2lm ICoqcmFzX2lmID0gJmFkZXYtPnNkbWEucmFzX2lmOworCXN0cnVjdCByYXNfY29tbW9uX2lmICpy YXNfaWYgPSBhZGV2LT5zZG1hLnJhc19pZjsKIAlzdHJ1Y3QgcmFzX2loX2lmIGloX2luZm8gPSB7 CiAJCS5jYiA9IHNkbWFfdjRfMF9wcm9jZXNzX3Jhc19kYXRhX2NiLAogCX07CkBAIC0xNTIzLDIx ICsxNTIzLDIxIEBAIHN0YXRpYyBpbnQgc2RtYV92NF8wX2xhdGVfaW5pdCh2b2lkICpoYW5kbGUp CiAJfQogCiAJLyogaGFuZGxlIHJlc3VtZSBwYXRoLiAqLwotCWlmICgqcmFzX2lmKQorCWlmIChy YXNfaWYpCiAJCWdvdG8gcmVzdW1lOwogCi0JKnJhc19pZiA9IGttYWxsb2Moc2l6ZW9mKCoqcmFz X2lmKSwgR0ZQX0tFUk5FTCk7Ci0JaWYgKCEqcmFzX2lmKQorCXJhc19pZiA9IGttYWxsb2Moc2l6 ZW9mKCpyYXNfaWYpLCBHRlBfS0VSTkVMKTsKKwlpZiAoIXJhc19pZikKIAkJcmV0dXJuIC1FTk9N RU07CiAKLQkqKnJhc19pZiA9IHJhc19ibG9jazsKKwkqcmFzX2lmID0gcmFzX2Jsb2NrOwogCi0J ciA9IGFtZGdwdV9yYXNfZmVhdHVyZV9lbmFibGUoYWRldiwgKnJhc19pZiwgMSk7CisJciA9IGFt ZGdwdV9yYXNfZmVhdHVyZV9lbmFibGUoYWRldiwgcmFzX2lmLCAxKTsKIAlpZiAocikKIAkJZ290 byBmZWF0dXJlOwogCi0JaWhfaW5mby5oZWFkID0gKipyYXNfaWY7Ci0JZnNfaW5mby5oZWFkID0g KipyYXNfaWY7CisJaWhfaW5mby5oZWFkID0gKnJhc19pZjsKKwlmc19pbmZvLmhlYWQgPSAqcmFz X2lmOwogCiAJciA9IGFtZGdwdV9yYXNfaW50ZXJydXB0X2FkZF9oYW5kbGVyKGFkZXYsICZpaF9p bmZvKTsKIAlpZiAocikKQEAgLTE1NjMsMTYgKzE1NjMsMTYgQEAgc3RhdGljIGludCBzZG1hX3Y0 XzBfbGF0ZV9pbml0KHZvaWQgKmhhbmRsZSkKIAogCXJldHVybiAwOwogaXJxOgotCWFtZGdwdV9y YXNfc3lzZnNfcmVtb3ZlKGFkZXYsICpyYXNfaWYpOworCWFtZGdwdV9yYXNfc3lzZnNfcmVtb3Zl KGFkZXYsIHJhc19pZik7CiBzeXNmczoKLQlhbWRncHVfcmFzX2RlYnVnZnNfcmVtb3ZlKGFkZXYs ICpyYXNfaWYpOworCWFtZGdwdV9yYXNfZGVidWdmc19yZW1vdmUoYWRldiwgcmFzX2lmKTsKIGRl YnVnZnM6CiAJYW1kZ3B1X3Jhc19pbnRlcnJ1cHRfcmVtb3ZlX2hhbmRsZXIoYWRldiwgJmloX2lu Zm8pOwogaW50ZXJydXB0OgotCWFtZGdwdV9yYXNfZmVhdHVyZV9lbmFibGUoYWRldiwgKnJhc19p ZiwgMCk7CisJYW1kZ3B1X3Jhc19mZWF0dXJlX2VuYWJsZShhZGV2LCByYXNfaWYsIDApOwogZmVh dHVyZToKLQlrZnJlZSgqcmFzX2lmKTsKLQkqcmFzX2lmID0gTlVMTDsKKwlrZnJlZShyYXNfaWYp OworCXJhc19pZiA9IE5VTEw7CiAJcmV0dXJuIC1FSU5WQUw7CiB9CiAKLS0gCjIuMjEuMAoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWls aW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4