From: Andre Przywara Subject: Re: [PATCH] KVM: arm64: fix potential bug Date: Tue, 12 Mar 2019 09:52:22 +0000 Message-ID: <20190312095222.45227d05@donnerap.cambridge.arm.com> References: <20190312003243.6712-1-johngong0791@gmail.com> <2405014d-9370-c0d5-7a44-7ec336098c45@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Gong John Cc: christoffer.dall@arm.com, Shengmin Gong , Marc Zyngier , Julien Thierry , Jia He , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org List-Id: kvmarm@lists.cs.columbia.edu On Tue, 12 Mar 2019 11:15:14 +0800 Gong John wrote: Hi, > On Tue, Mar 12, 2019 at 9:44 AM André Przywara wrote: > > > > On 12/03/2019 00:32, John Gong wrote: > > Hi, > > > > > Since intid always >= VGIC_NR_PRIVATE_IRQS, > > > > How so? The PMU and the arch timer emulation use PPIs, so intid is > > definitely < VGIC_NR_PRIVATE_IRQS there. > > > > > so then even vcpu == NULL, it never return -EINVAL. > > > > I am not sure I follow. > > To uniquely identify an SPI interrupt, we just need the interrupt ID > > (which is always >= 32). For PPIs and SGIs, we additionally need the > > vCPU ID this private interrupt belongs to, as there are multiple > > interrupts with the same INTID (one per VCPU). > > The VCPU ID passed in for SPIs is just a dummy value (because we use the > > same function to inject private and shared interrupts), so we don't need > > to check for its validity. > > > > Cheers, > > Andre. > > > Thanks for your explanation. It's my fault to not consider the PPIs > and SGIs injection. Don't worry, we are glad when people actually look at the code. And we rather have a false positive report than a bug slipping through. Cheers, Andre. > Sorry for polluting the mail list. > > Cheers, > John Gong > > > > > > Signed-off-by: Shengmin Gong > > > Signed-off-by: John Gong > > > --- > > > virt/kvm/arm/vgic/vgic.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/virt/kvm/arm/vgic/vgic.c b/virt/kvm/arm/vgic/vgic.c > > > index abd9c7352677..d3cb1ce880e2 100644 > > > --- a/virt/kvm/arm/vgic/vgic.c > > > +++ b/virt/kvm/arm/vgic/vgic.c > > > @@ -424,7 +424,7 @@ int kvm_vgic_inject_irq(struct kvm *kvm, int cpuid, unsigned int intid, > > > return ret; > > > > > > vcpu = kvm_get_vcpu(kvm, cpuid); > > > - if (!vcpu && intid < VGIC_NR_PRIVATE_IRQS) > > > + if (!vcpu) > > > return -EINVAL; > > > > > > irq = vgic_get_irq(kvm, vcpu, intid); > > > > >